d1619bceb3142f3ab8c134365e18a150fbd5b9bf
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 9 | ||
| Pull Up Method public testNoCodecAsync() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testNoCodec() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testRTEDuringConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testRTEDuringConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testRpcScheduler() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testRpcScheduler() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testNoCodec() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testNoCodec() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method private doSimpleTest(client RpcClientImpl) : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testCompressCellBlock() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testRTEDuringAsyncBlockingConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testRTEDuringConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testRpcSchedulerAsync() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testRpcScheduler() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method private doAsyncSimpleTest(client AsyncRpcClient) : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testCompressCellBlock() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Method public testCompressCellBlock() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testCompressCellBlock() : void from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Move Method | 2 | ||
| Move Method public testAsyncConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testAsyncConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestAsyncIPC | From | To | |
| Move Method public testRTEDuringAsyncConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestIPC to public testRTEDuringAsyncConnectionSetup() : void from class org.apache.hadoop.hbase.ipc.TestAsyncIPC | From | To | |
| Rename Variable | 1 | ||
| Rename Variable socketChannelClass : Class<? extends Channel> to eventLoopGroupAndChannelClass : Pair<EventLoopGroup,Class<? extends Channel>> in method package AsyncRpcClient(configuration Configuration, clusterId String, localAddress SocketAddress, channelInitializer ChannelInitializer<SocketChannel>) in class org.apache.hadoop.hbase.ipc.AsyncRpcClient | From | To | |
| Pull Up Attribute | 4 | ||
| Pull Up Attribute package CELL_BYTES : byte[] from class org.apache.hadoop.hbase.ipc.TestIPC to private CELL_BYTES : byte[] from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Attribute private SERVICE : BlockingService from class org.apache.hadoop.hbase.ipc.TestIPC to package SERVICE : BlockingService from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Attribute package BIG_CELL_BYTES : byte[] from class org.apache.hadoop.hbase.ipc.TestIPC to package BIG_CELL_BYTES : byte[] from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Pull Up Attribute private CONF : Configuration from class org.apache.hadoop.hbase.ipc.TestIPC to package CONF : Configuration from class org.apache.hadoop.hbase.ipc.AbstractTestIPC | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.ipc.TestIPC to private TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.ipc.TestAsyncIPC | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.hadoop.hbase.ipc.AbstractTestIPC from class org.apache.hadoop.hbase.ipc.TestIPC | From | To | |
| Extract Class org.apache.hadoop.hbase.ipc.TestAsyncIPC from class org.apache.hadoop.hbase.ipc.TestIPC | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.hbase.ipc.TestIPC.TestRpcServer moved to org.apache.hadoop.hbase.ipc.AbstractTestIPC.TestRpcServer | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.hbase.ipc.AbstractTestIPC from classes [org.apache.hadoop.hbase.ipc.TestIPC] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type socketChannelClass : Class<? extends Channel> to eventLoopGroupAndChannelClass : Pair<EventLoopGroup,Class<? extends Channel>> in method package AsyncRpcClient(configuration Configuration, clusterId String, localAddress SocketAddress, channelInitializer ChannelInitializer<SocketChannel>) in class org.apache.hadoop.hbase.ipc.AsyncRpcClient | From | To | |
| Extract Method | 3 | ||
| Extract Method protected createRpcClient(conf Configuration) : AsyncRpcClient extracted from public testAsyncConnectionSetup() : void in class org.apache.hadoop.hbase.ipc.TestAsyncIPC | From | To | |
| Extract Method protected createRpcClientRTEDuringConnectionSetup(conf Configuration) : AsyncRpcClient extracted from public testRTEDuringAsyncConnectionSetup() : void in class org.apache.hadoop.hbase.ipc.TestAsyncIPC | From | To | |
| Extract Method private createEventLoopGroup(conf Configuration) : Pair<EventLoopGroup,Class<? extends Channel>> extracted from package AsyncRpcClient(configuration Configuration, clusterId String, localAddress SocketAddress, channelInitializer ChannelInitializer<SocketChannel>) in class org.apache.hadoop.hbase.ipc.AsyncRpcClient | From | To |