d822ee3a7ccc4959ed5a4b85bb54ff6142aa7d6e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method protected shouldFlushInMemory() : boolean renamed to package inMemoryCompaction() : void in class org.apache.hadoop.hbase.regionserver.TestHStore.MyCompactingMemStoreWithCustomCompactor | From | To | |
| Rename Method protected checkActiveSize() : void renamed to protected postUpdate(currentActive MutableSegment) : void in class org.apache.hadoop.hbase.regionserver.DefaultMemStore | From | To | |
| Rename Method protected abstract checkActiveSize() : void renamed to protected abstract postUpdate(currentActive MutableSegment) : void in class org.apache.hadoop.hbase.regionserver.AbstractMemStore | From | To | |
| Rename Method protected checkActiveSize() : void renamed to private checkAndAddToActiveSize(currActive MutableSegment, cellToAdd Cell, memstoreSizing MemStoreSizing) : boolean in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Inline Method | 1 | ||
| Inline Method protected shouldFlushInMemory() : boolean inlined to private checkAndAddToActiveSize(currActive MutableSegment, cellToAdd Cell, memstoreSizing MemStoreSizing) : boolean in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Change Return Type | 2 | ||
| Change Return Type boolean to void in method package inMemoryCompaction() : void in class org.apache.hadoop.hbase.regionserver.TestHStore.MyCompactingMemStoreWithCustomCompactor | From | To | |
| Change Return Type void to boolean in method private checkAndAddToActiveSize(currActive MutableSegment, cellToAdd Cell, memstoreSizing MemStoreSizing) : boolean in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.hbase.regionserver.CompactingMemStore.InMemoryFlushRunnable renamed to org.apache.hadoop.hbase.regionserver.CompactingMemStore.InMemoryCompactionRunnable | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute inMemoryFlushInProgress : AtomicBoolean to inMemoryCompactionInProgress : AtomicBoolean in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Extract Variable | 2 | ||
| Extract Variable delta : long in method protected updateMetaInfo(cellToAdd Cell, succ boolean, mslabUsed boolean, memstoreSizing MemStoreSizing, sizeAddedPreOperation boolean) : void from class org.apache.hadoop.hbase.regionserver.Segment | From | To | |
| Extract Variable segments : List<ImmutableSegment> in method private createSubstitution(action MemStoreCompactionStrategy.Action) : ImmutableSegment from class org.apache.hadoop.hbase.regionserver.MemStoreCompactor | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type runnable : InMemoryFlushRunnable to runnable : InMemoryCompactionRunnable in method private checkAndAddToActiveSize(currActive MutableSegment, cellToAdd Cell, memstoreSizing MemStoreSizing) : boolean in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Extract Method | 6 | ||
| Extract Method private doAdd(currentActive MutableSegment, cell Cell, memstoreSizing MemStoreSizing) : void extracted from public add(cell Cell, memstoreSizing MemStoreSizing) : void in class org.apache.hadoop.hbase.regionserver.AbstractMemStore | From | To | |
| Extract Method private doAddOrUpsert(cell Cell, readpoint long, memstoreSizing MemStoreSizing, doAdd boolean) : void extracted from private upsert(cell Cell, readpoint long, memstoreSizing MemStoreSizing) : void in class org.apache.hadoop.hbase.regionserver.AbstractMemStore | From | To | |
| Extract Method private doUpsert(currentActive MutableSegment, cell Cell, readpoint long, memstoreSizing MemStoreSizing) : void extracted from private upsert(cell Cell, readpoint long, memstoreSizing MemStoreSizing) : void in class org.apache.hadoop.hbase.regionserver.AbstractMemStore | From | To | |
| Extract Method package inMemoryCompaction() : void extracted from package flushInMemory() : void in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Extract Method private flushInMemory(currActive MutableSegment) : void extracted from package flushInMemory() : void in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To | |
| Extract Method private doAddOrUpsert(cell Cell, readpoint long, memstoreSizing MemStoreSizing, doAdd boolean) : void extracted from public add(cell Cell, memstoreSizing MemStoreSizing) : void in class org.apache.hadoop.hbase.regionserver.AbstractMemStore | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter succ : boolean to allocated : boolean in method protected offHeapSizeChange(cell Cell, allocated boolean) : long in class org.apache.hadoop.hbase.regionserver.Segment | From | To | |
| Rename Parameter succ : boolean to allocated : boolean in method protected heapSizeChange(cell Cell, allocated boolean) : long in class org.apache.hadoop.hbase.regionserver.Segment | From | To | |
| Rename Parameter memstoreSizing : MemStoreSizing to mss : MemStoreSizing in method protected CellArrayImmutableSegment(segment CSLMImmutableSegment, mss MemStoreSizing, action MemStoreCompactionStrategy.Action) in class org.apache.hadoop.hbase.regionserver.CellArrayImmutableSegment | From | To | |
| Rename Parameter active : MutableSegment to currActive : MutableSegment in method protected pushActiveToPipeline(currActive MutableSegment) : void in class org.apache.hadoop.hbase.regionserver.CompactingMemStore | From | To |