hbase ec92a8a705dfec076a93454e1042645d466758f0

ec92a8a705dfec076a93454e1042645d466758f0

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 7

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	4
Rename Method private doMiniBatchMutation(batchOp BatchOperationInProgress<?>) : long renamed to private doMiniBatchMutate(batchOp BatchOperation<?>) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Method private doPreMutationHook(batchOp BatchOperationInProgress<?>) : void renamed to private doPreBatchMutateHook(batchOp BatchOperation<?>) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Method private syncOrDefer(txid long, durability Durability) : void renamed to private sync(txid long, durability Durability) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Method private writeMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, edit WALEdit, mvcc MultiVersionConcurrencyControl, sync boolean) : long renamed to public doFullAppendTransaction(wal WAL, htd HTableDescriptor, hri HRegionInfo, edit WALEdit, mvcc MultiVersionConcurrencyControl, sync boolean) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Parameter Type	3
Change Parameter Type batchOp : BatchOperationInProgress<?> to batchOp : BatchOperation<?> in method private doPreBatchMutateHook(batchOp BatchOperation<?>) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Parameter Type batchOp : BatchOperationInProgress<?> to batchOp : BatchOperation<?> in method package batchMutate(batchOp BatchOperation<?>) : OperationStatus[] in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Parameter Type batchOp : BatchOperationInProgress<?> to batchOp : BatchOperation<?> in method private doMiniBatchMutate(batchOp BatchOperation<?>) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Variable	8
Rename Variable trx : long to walKey : WALKey in method public writeCompactionMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, c CompactionDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Rename Variable doRollBackMemstore : boolean to skip : boolean in method private checkBatchOp(batchOp BatchOperation<?>, lastIndexExclusive int, familyMaps Map<byte[],List<Cell>>[], now long) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Variable listSize : int to count : int in method private applyToMemstore(store Store, cells List<Cell>, delta boolean, replay boolean, sequenceId long) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Variable walSyncSuccessful : boolean to success : boolean in method public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Variable trx : long to walKey : WALKey in method public writeBulkLoadMarkerAndSync(wal WAL, htd HTableDescriptor, hri HRegionInfo, desc WALProtos.BulkLoadDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Rename Variable key : WALKey to walKey : WALKey in method public doFullAppendTransaction(wal WAL, htd HTableDescriptor, hri HRegionInfo, edit WALEdit, mvcc MultiVersionConcurrencyControl, sync boolean) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Rename Variable mvccNum : long to sequenceId : long in method public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Variable trx : long to walKey : WALKey in method public writeRegionEventMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, r RegionEventDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Return Type	5
Change Return Type long to WALKey in method public writeRegionEventMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, r RegionEventDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Return Type long to WALKey in method public writeBulkLoadMarkerAndSync(wal WAL, htd HTableDescriptor, hri HRegionInfo, desc WALProtos.BulkLoadDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Return Type long to WALKey in method public doFullAppendTransaction(wal WAL, htd HTableDescriptor, hri HRegionInfo, edit WALEdit, mvcc MultiVersionConcurrencyControl, sync boolean) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Return Type long to WALKey in method public writeCompactionMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, c CompactionDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Return Type long to WALKey in method public writeFlushMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, f FlushDescriptor, sync boolean, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Rename Class	1
Rename Class org.apache.hadoop.hbase.regionserver.HRegion.BatchOperationInProgress renamed to org.apache.hadoop.hbase.regionserver.HRegion.BatchOperation	From	To
Parameterize Variable	2
Parameterize Variable m : Mutation to mutation : Mutation in method private appendCurrentNonces(mutation Mutation, replay boolean, walEdit WALEdit, now long, currentNonceGroup long, currentNonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Parameterize Variable isInReplay : boolean to replay : boolean in method private appendCurrentNonces(mutation Mutation, replay boolean, walEdit WALEdit, now long, currentNonceGroup long, currentNonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Attribute	1
Rename Attribute seqNumAssignedLatch : CountDownLatch to sequenceIdAssignedLatch : CountDownLatch in class org.apache.hadoop.hbase.wal.WALKey	From	To
Change Variable Type	6
Change Variable Type trx : long to walKey : WALKey in method public writeCompactionMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, c CompactionDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Variable Type writeEntry : MultiVersionConcurrencyControl.WriteEntry to writeEntry : WriteEntry in method private doMiniBatchMutate(batchOp BatchOperation<?>) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Variable Type writeEntry : MultiVersionConcurrencyControl.WriteEntry to writeEntry : WriteEntry in method private doWALAppend(walEdit WALEdit, durability Durability, clusterIds List<UUID>, now long, nonceGroup long, nonce long) : WriteEntry in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Variable Type writeEntry : MultiVersionConcurrencyControl.WriteEntry to writeEntry : WriteEntry in method public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Variable Type trx : long to walKey : WALKey in method public writeBulkLoadMarkerAndSync(wal WAL, htd HTableDescriptor, hri HRegionInfo, desc WALProtos.BulkLoadDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Change Variable Type trx : long to walKey : WALKey in method public writeRegionEventMarker(wal WAL, htd HTableDescriptor, hri HRegionInfo, r RegionEventDescriptor, mvcc MultiVersionConcurrencyControl) : WALKey in class org.apache.hadoop.hbase.regionserver.wal.WALUtil	From	To
Inline Variable	3
Inline Variable replaySeqId : long in method private doMiniBatchMutation(batchOp BatchOperationInProgress<?>) : long from class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Inline Variable key : WALKey in method package stampRegionSequenceId() : long from class org.apache.hadoop.hbase.regionserver.wal.FSWALEntry	From	To
Inline Variable mvccNum : long in method private doMiniBatchMutation(batchOp BatchOperationInProgress<?>) : long from class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method	14
Extract Method private doAbortFlushToWAL(wal WAL, flushOpSeqId long, committedFiles Map<byte[],List<Path>>) : void extracted from protected internalPrepareFlushCache(wal WAL, myseqid long, storesToFlush Collection<Store>, status MonitoredTask, writeFlushWalMarker boolean) : PrepareFlushResult in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private preProcess(processor RowProcessor<?,?>, walEdit WALEdit) : void extracted from public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private checkBatchOp(batchOp BatchOperation<?>, lastIndexExclusive int, familyMaps Map<byte[],List<Cell>>[], now long) : boolean extracted from private doMiniBatchMutation(batchOp BatchOperationInProgress<?>) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private applyToMemstore(store Store, cell Cell, sequenceId long) : long extracted from public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method protected setSequenceId(sequenceId long) : void extracted from public readFieldsFromPb(walKey WALProtos.WALKey, uncompressor WALCellCodec.ByteStringUncompressor) : void in class org.apache.hadoop.hbase.wal.WALKey	From	To
Extract Method private doSyncOfUnflushedWALChanges(wal WAL, hri HRegionInfo) : void extracted from protected internalPrepareFlushCache(wal WAL, myseqid long, storesToFlush Collection<Store>, status MonitoredTask, writeFlushWalMarker boolean) : PrepareFlushResult in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private matches(compareOp CompareOp, compareResult int) : boolean extracted from public checkAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rm RowMutations, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private doWALAppend(walEdit WALEdit, durability Durability, clusterIds List<UUID>, now long, nonceGroup long, nonce long) : WriteEntry extracted from public processRowsWithLocks(processor RowProcessor<?,?>, timeout long, nonceGroup long, nonce long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private matches(compareOp CompareOp, compareResult int) : boolean extracted from public checkAndMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, w Mutation, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private applyToMemstore(store Store, cells List<Cell>, delta boolean, replay boolean, sequenceId long) : long extracted from private applyFamilyMapToMemstore(familyMap Map<byte[],List<Cell>>, mvccNum long, isInReplay boolean) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private doCheckAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rowMutations RowMutations, mutation Mutation, writeToWAL boolean) : boolean extracted from public checkAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rm RowMutations, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private logFatLineOnFlush(storesToFlush Collection<Store>, sequenceId long) : void extracted from protected internalPrepareFlushCache(wal WAL, myseqid long, storesToFlush Collection<Store>, status MonitoredTask, writeFlushWalMarker boolean) : PrepareFlushResult in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private doCheckAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rowMutations RowMutations, mutation Mutation, writeToWAL boolean) : boolean extracted from public checkAndMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, w Mutation, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract Method private appendCurrentNonces(mutation Mutation, replay boolean, walEdit WALEdit, now long, currentNonceGroup long, currentNonce long) : void extracted from private doMiniBatchMutation(batchOp BatchOperationInProgress<?>) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Extract And Move Method	2
Extract And Move Method protected setSequenceId(sequenceId long) : void extracted from public readFields(in DataInput) : void in class org.apache.hadoop.hbase.regionserver.wal.HLogKey & moved to class org.apache.hadoop.hbase.wal.WALKey	From	To
Extract And Move Method private sort(cells List<Cell>, comparator Comparator<Cell>) : List<Cell> extracted from private populateFromJoinedHeap(results List<Cell>, scannerContext ScannerContext) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion.RegionScannerImpl & moved to class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter	8
Rename Parameter seqId : long to sequenceId : long in method public setOrigLogSeqNum(sequenceId long) : void in class org.apache.hadoop.hbase.wal.WALKey	From	To
Rename Parameter rm : RowMutations to rowMutations : RowMutations in method private doCheckAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rowMutations RowMutations, mutation Mutation, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter myseqid : long to sequenceId : long in method private logFatLineOnFlush(storesToFlush Collection<Store>, sequenceId long) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter mvccNum : long to sequenceId : long in method private applyFamilyMapToMemstore(familyMap Map<byte[],List<Cell>>, replay boolean, sequenceId long) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter w : Mutation to mutation : Mutation in method private doCheckAndRowMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, rowMutations RowMutations, mutation Mutation, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter w : Mutation to mutation : Mutation in method public checkAndMutate(row byte[], family byte[], qualifier byte[], compareOp CompareOp, comparator ByteArrayComparable, mutation Mutation, writeToWAL boolean) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter mutate : Append to mutation : Append in method public append(mutation Append, nonceGroup long, nonce long) : Result in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Rename Parameter isInReplay : boolean to replay : boolean in method private applyFamilyMapToMemstore(familyMap Map<byte[],List<Cell>>, replay boolean, sequenceId long) : long in class org.apache.hadoop.hbase.regionserver.HRegion	From	To

ec92a8a705dfec076a93454e1042645d466758f0

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: