hbase ed87a81b4b61c4842c12572a47c97ae23773012f

ed87a81b4b61c4842c12572a47c97ae23773012f

Files Diff

Added: 1
Removed: 2
Renamed: 0
Modified: 47

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private flushRegion() : FlushRegionResponse renamed to protected call(controller PayloadCarryingRpcController) : FlushRegionResponse in class org.apache.hadoop.hbase.client.FlushRegionCallable	From	To
Change Parameter Type	4
Change Parameter Type callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result in class org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.ReplicaRegionServerCallable	From	To
Change Parameter Type callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : MultiResponse in class org.apache.hadoop.hbase.client.MultiServerCallable	From	To
Change Parameter Type callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result[] in class org.apache.hadoop.hbase.client.ScannerCallable	From	To
Change Parameter Type timeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result[] in class org.apache.hadoop.hbase.client.ClientSmallScanner.SmallScannerCallable	From	To
Move Method	13
Move Method public isCanceled() : boolean from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public isCanceled() : boolean from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public notifyOnCancel(cancellationCb RpcCallback<Object>) : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public notifyOnCancel(cancellationCb RpcCallback<Object>) : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public setCallTimeout(callTimeout int) : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public setCallTimeout(callTimeout int) : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public getCallTimeout() : int from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public getCallTimeout() : int from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public errorText() : String from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public errorText() : String from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method private isMetaRegion(regionName byte[]) : boolean from class org.apache.hadoop.hbase.client.HBaseAdmin to private isMetaRegion(regionName byte[]) : boolean from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public hasCallTimeout() : boolean from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public hasCallTimeout() : boolean from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public notifyOnFail(failureCb RpcCallback<IOException>) : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public notifyOnFail(failureCb RpcCallback<IOException>) : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public setFailed(reason String) : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public setFailed(reason String) : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public call(callTimeout int) : ReplicateWALEntryResponse from class org.apache.hadoop.hbase.regionserver.wal.WALEditsReplaySink.ReplayServerCallable to public call(callTimeout int) : V from class org.apache.hadoop.hbase.client.RpcRetryingCallable	From	To
Move Method public setFailed(e IOException) : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public setFailed(e IOException) : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public startCancel() : void from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public startCancel() : void from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Method public failed() : boolean from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to public failed() : boolean from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Rename Variable	5
Rename Variable timeLimitedRpcController : TimeLimitedRpcController to pRpcController : PayloadCarryingRpcController in method public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices	From	To
Rename Variable controller : PayloadCarryingRpcController to rpcController : PayloadCarryingRpcController in method public getCompactionState(tableName TableName, compactType CompactType) : CompactionState in class org.apache.hadoop.hbase.client.HBaseAdmin	From	To
Rename Variable admin : AdminService.BlockingInterface to masterAdmin : AdminProtos.AdminService.BlockingInterface in method public getCompactionState(tableName TableName, compactType CompactType) : CompactionState in class org.apache.hadoop.hbase.client.HBaseAdmin	From	To
Rename Variable o : Object to obj : Object in method public get(gets List<Get>) : Result[] in class org.apache.hadoop.hbase.client.HTable	From	To
Rename Variable getReq : Get to configuredGet : Get in method private get(get Get, checkExistenceOnly boolean) : Result in class org.apache.hadoop.hbase.client.HTable	From	To
Change Return Type	1
Change Return Type ReplicateWALEntryResponse to V in method public call(callTimeout int) : V in class org.apache.hadoop.hbase.client.RpcRetryingCallable	From	To
Move Attribute	6
Move Attribute protected failureCb : AtomicReference<RpcCallback<IOException>> from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to protected failureCb : AtomicReference<RpcCallback<IOException>> from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Attribute protected callTimeout : Integer from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to protected callTimeout : Integer from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Attribute protected controller : PayloadCarryingRpcController from class org.apache.hadoop.hbase.client.PayloadCarryingServerCallable to private controller : PayloadCarryingRpcController from class org.apache.hadoop.hbase.client.RegionAdminServiceCallable	From	To
Move Attribute protected cancelled : boolean from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to protected cancelled : boolean from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Attribute private exception : IOException from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to private exception : IOException from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Move Attribute protected cancellationCb : AtomicReference<RpcCallback<Object>> from class org.apache.hadoop.hbase.ipc.TimeLimitedRpcController to protected cancellationCb : AtomicReference<RpcCallback<Object>> from class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Extract Variable	1
Extract Variable t : Throwable in method private makeIOExceptionOfException(e Exception) : IOException from class org.apache.hadoop.hbase.protobuf.ProtobufUtil	From	To
Change Variable Type	2
Change Variable Type timeLimitedRpcController : TimeLimitedRpcController to pRpcController : PayloadCarryingRpcController in method public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices	From	To
Change Variable Type admin : AdminService.BlockingInterface to masterAdmin : AdminProtos.AdminService.BlockingInterface in method public getCompactionState(tableName TableName, compactType CompactType) : CompactionState in class org.apache.hadoop.hbase.client.HBaseAdmin	From	To
Inline Variable	1
Inline Variable toBeAssigned : byte[] in method public assign(regionName byte[]) : void from class org.apache.hadoop.hbase.client.HBaseAdmin	From	To
Extract Method	2
Extract Method private makeIOExceptionOfException(e Exception) : IOException extracted from public getRemoteException(se ServiceException) : IOException in class org.apache.hadoop.hbase.protobuf.ProtobufUtil	From	To
Extract Method public available(conf Configuration) : void extracted from public checkHBaseAvailable(conf Configuration) : void in class org.apache.hadoop.hbase.client.HBaseAdmin	From	To
Extract And Move Method	4
Extract And Move Method public setPriority(regionName byte[]) : void extracted from public unassign(regionName byte[], force boolean) : void in class org.apache.hadoop.hbase.client.HBaseAdmin & moved to class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Extract And Move Method public setPriority(regionName byte[]) : void extracted from public move(encodedRegionName byte[], destServerName byte[]) : void in class org.apache.hadoop.hbase.client.HBaseAdmin & moved to class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Extract And Move Method public setPriority(regionName byte[]) : void extracted from public offline(regionName byte[]) : void in class org.apache.hadoop.hbase.client.HBaseAdmin & moved to class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Extract And Move Method public setPriority(regionName byte[]) : void extracted from public assign(regionName byte[]) : void in class org.apache.hadoop.hbase.client.HBaseAdmin & moved to class org.apache.hadoop.hbase.ipc.PayloadCarryingRpcController	From	To
Rename Parameter	4
Rename Parameter callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result in class org.apache.hadoop.hbase.client.RpcRetryingCallerWithReadReplicas.ReplicaRegionServerCallable	From	To
Rename Parameter callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : MultiResponse in class org.apache.hadoop.hbase.client.MultiServerCallable	From	To
Rename Parameter callTimeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result[] in class org.apache.hadoop.hbase.client.ScannerCallable	From	To
Rename Parameter timeout : int to controller : PayloadCarryingRpcController in method protected call(controller PayloadCarryingRpcController) : Result[] in class org.apache.hadoop.hbase.client.ClientSmallScanner.SmallScannerCallable	From	To

ed87a81b4b61c4842c12572a47c97ae23773012f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: