ef712df944b0745892bc13bcecdfd6e358a71b66
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type callable : MultiServerCallable<Row> to callable : PayloadCarryingServerCallable in method protected createCaller(callable PayloadCarryingServerCallable) : RpcRetryingCaller<MultiResponse> in class org.apache.hadoop.hbase.client.AsyncProcess | From | To | |
| Change Parameter Type callable : MultiServerCallable<Row> to payloadCallable : PayloadCarryingServerCallable in method protected createCaller(payloadCallable PayloadCarryingServerCallable) : RpcRetryingCaller<MultiResponse> in class org.apache.hadoop.hbase.client.TestAsyncProcess.MyAsyncProcessWithReplicas | From | To | |
| Change Parameter Type callsInProgress : Set<MultiServerCallable<Row>> to callsInProgress : Set<PayloadCarryingServerCallable> in method private SingleServerRequestRunnable(multiAction MultiAction<Row>, numAttempt int, server ServerName, callsInProgress Set<PayloadCarryingServerCallable>) in class org.apache.hadoop.hbase.client.AsyncProcess.AsyncRequestFutureImpl.SingleServerRequestRunnable | From | To | |
| Change Parameter Type callable : MultiServerCallable<Row> to callable : PayloadCarryingServerCallable in method protected createCaller(callable PayloadCarryingServerCallable) : RpcRetryingCaller<MultiResponse> in class org.apache.hadoop.hbase.client.TestAsyncProcess.AsyncProcessWithFailure | From | To | |
| Change Parameter Type callable : MultiServerCallable<Row> to callable : PayloadCarryingServerCallable in method protected createCaller(callable PayloadCarryingServerCallable) : RpcRetryingCaller<MultiResponse> in class org.apache.hadoop.hbase.client.TestAsyncProcess.MyAsyncProcess | From | To | |
| Move Method | 1 | ||
| Move Method private getRemainingTime(callTimeout int) : int from class org.apache.hadoop.hbase.client.RpcRetryingCallerImpl to public getRemainingTime(callTimeout int) : int from class org.apache.hadoop.hbase.client.RetryingTimeTracker | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private controller : PayloadCarryingRpcController from class org.apache.hadoop.hbase.client.MultiServerCallable to protected controller : PayloadCarryingRpcController from class org.apache.hadoop.hbase.client.PayloadCarryingServerCallable | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private globalStartTime : long from class org.apache.hadoop.hbase.client.RpcRetryingCallerImpl to private globalStartTime : long from class org.apache.hadoop.hbase.client.RetryingTimeTracker | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hbase.client.RetryingTimeTracker from class org.apache.hadoop.hbase.client.RpcRetryingCallerImpl | From | To | |
| Extract Variable | 1 | ||
| Extract Variable regionSpecifier : RegionSpecifier in method public multi(rpcc RpcController, request MultiRequest) : MultiResponse from class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type m : MultiServerCallable<Row> to m : PayloadCarryingServerCallable in method public testCancelOfMultiGet() : void in class org.apache.hadoop.hbase.client.TestReplicasClient | From | To | |
| Change Variable Type clb : MultiServerCallable<Row> to clb : PayloadCarryingServerCallable in method public waitUntilDone() : void in class org.apache.hadoop.hbase.client.AsyncProcess.AsyncRequestFutureImpl | From | To | |
| Change Variable Type set : Set<MultiServerCallable<Row>> to set : Set<PayloadCarryingServerCallable> in method public testCancelOfMultiGet() : void in class org.apache.hadoop.hbase.client.TestReplicasClient | From | To | |
| Change Variable Type rs : Map<Integer,Object> to rs : RegionResult in method private getResult(region byte[]) : RegionResult in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Change Variable Type c : Map<?,?> to result : RegionResult in method public size() : int in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Extract Method | 5 | ||
| Extract Method private getResult(region byte[]) : RegionResult extracted from public add(regionName byte[], originalIndex int, resOrEx Object) : void in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Extract Method protected createAsyncRequestFuture(tableName TableName, actions List<Action<Row>>, nonceGroup long, pool ExecutorService, callback Batch.Callback<CResult>, results Object[], needResults boolean, callable PayloadCarryingServerCallable, curTimeout int) : AsyncRequestFutureImpl<CResult> extracted from protected createAsyncRequestFuture(tableName TableName, actions List<Action<Row>>, nonceGroup long, pool ExecutorService, callback Batch.Callback<CResult>, results Object[], needResults boolean) : AsyncRequestFutureImpl<CResult> in class org.apache.hadoop.hbase.client.AsyncProcess | From | To | |
| Extract Method public submitAll(pool ExecutorService, tableName TableName, rows List<? extends Row>, callback Batch.Callback<CResult>, results Object[], callable PayloadCarryingServerCallable, curTimeout int) : AsyncRequestFuture extracted from public submitAll(pool ExecutorService, tableName TableName, rows List<? extends Row>, callback Batch.Callback<CResult>, results Object[]) : AsyncRequestFuture in class org.apache.hadoop.hbase.client.AsyncProcess | From | To | |
| Extract Method public updateRegionStats(serverName ServerName, regionName byte[], stats ClientProtos.RegionLoadStats) : void extracted from public updateServerStats(serverName ServerName, regionName byte[], r Object) : void in class org.apache.hadoop.hbase.client.MetricsConnection | From | To | |
| Extract Method public updateStats(tracker StatisticTrackable, server ServerName, regionName byte[], stats ClientProtos.RegionLoadStats) : void extracted from public updateStats(r T, serverStats ServerStatisticTracker, server ServerName, regionName byte[]) : T in class org.apache.hadoop.hbase.client.ResultStatsUtil | From | To | |
| Rename Method | 1 | ||
| Rename Method public getRegionStats() : ClientProtos.RegionLoadStats renamed to public getLoadStatistics() : ClientProtos.RegionLoadStats in class org.apache.hadoop.hbase.regionserver.HRegion | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public isCancelled() : boolean from class org.apache.hadoop.hbase.client.MultiServerCallable to public isCancelled() : boolean from class org.apache.hadoop.hbase.client.PayloadCarryingServerCallable | From | To | |
| Pull Up Method public cancel() : void from class org.apache.hadoop.hbase.client.MultiServerCallable to public cancel() : void from class org.apache.hadoop.hbase.client.PayloadCarryingServerCallable | From | To | |
| Rename Variable | 1 | ||
| Rename Variable c : Map<?,?> to result : RegionResult in method public size() : int in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Set<MultiServerCallable<Row>> to Set<PayloadCarryingServerCallable> in method public getCallsInProgress() : Set<PayloadCarryingServerCallable> in class org.apache.hadoop.hbase.client.AsyncProcess.AsyncRequestFutureImpl | From | To | |
| Change Return Type Map<byte[],Map<Integer,Object>> to Map<byte[],RegionResult> in method public getResults() : Map<byte[],RegionResult> in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Change Return Type ClientProtos.RegionLoadStats to void in method private mutateRows(region Region, actions List<ClientProtos.Action>, cellScanner CellScanner, builder RegionActionResult.Builder) : void in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.hbase.client.PayloadCarryingServerCallable from classes [org.apache.hadoop.hbase.client.MultiServerCallable] | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.hadoop.hbase.client.StatisticTrackable from classes [org.apache.hadoop.hbase.client.ServerStatisticTracker] | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type callsInProgress : Set<MultiServerCallable<Row>> to callsInProgress : Set<PayloadCarryingServerCallable> in class org.apache.hadoop.hbase.client.AsyncProcess.AsyncRequestFutureImpl.SingleServerRequestRunnable | From | To | |
| Change Attribute Type callsInProgress : Set<MultiServerCallable<Row>> to callsInProgress : Set<PayloadCarryingServerCallable> in class org.apache.hadoop.hbase.client.AsyncProcess.AsyncRequestFutureImpl | From | To | |
| Change Attribute Type results : Map<byte[],Map<Integer,Object>> to results : Map<byte[],RegionResult> in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter regionName : byte[] to region : byte[] in method private getResult(region byte[]) : RegionResult in class org.apache.hadoop.hbase.client.MultiResponse | From | To | |
| Rename Parameter callable : MultiServerCallable<Row> to payloadCallable : PayloadCarryingServerCallable in method protected createCaller(payloadCallable PayloadCarryingServerCallable) : RpcRetryingCaller<MultiResponse> in class org.apache.hadoop.hbase.client.TestAsyncProcess.MyAsyncProcessWithReplicas | From | To |