fa852c4ce68999cbe30e11820cbfd099d1c5cfaa
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 40
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 3 | ||
Rename Method public fullScanOfMeta(connection Connection) : List<Result> renamed to public fullScan(connection Connection, type QueryType) : List<Result> in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Rename Method protected getFamily() : byte[] renamed to protected getCatalogFamily() : byte[] in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Rename Method private loadDisabledTables() : void renamed to private loadTableStates() : void in class org.apache.hadoop.hbase.util.HBaseFsck | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type server : Server to server : MasterServices in method public AssignmentManager(server MasterServices, serverManager ServerManager, balancer LoadBalancer, service ExecutorService, metricsMaster MetricsMaster, tableLockManager TableLockManager, tableStateManager TableStateManager) in class org.apache.hadoop.hbase.master.AssignmentManager | From | To | |
Change Parameter Type callable : MasterCallable<V> to callable : C in method private executeCallable(callable C) : V in class org.apache.hadoop.hbase.client.HBaseAdmin | From | To | |
Change Parameter Type master : Server to master : MasterServices in method package RegionStates(master MasterServices, tableStateManager TableStateManager, serverManager ServerManager, regionStateStore RegionStateStore) in class org.apache.hadoop.hbase.master.RegionStates | From | To | |
Inline Method | 1 | ||
Inline Method private enableMeta(metaTableName TableName) : void inlined to package assignMeta(status MonitoredTask, previouslyFailedMetaRSs Set<ServerName>, replicaId int) : void in class org.apache.hadoop.hbase.master.HMaster | From | To | |
Rename Variable | 4 | ||
Rename Variable doneWithMetaScan : boolean to tableWasEnabled : boolean in method public createTable(desc HTableDescriptor, splitKeys byte[][]) : void in class org.apache.hadoop.hbase.client.HBaseAdmin | From | To | |
Rename Variable descriptor : TableDescriptor to currentState : TableState in method public setTableStateIfInStates(tableName TableName, newState TableState.State, states TableState.State...) : boolean in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Rename Variable tableName : TableName to tableDescriptors : TableDescriptors in method public start() : void in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Rename Variable descriptor : TableDescriptor to currentState : TableState in method public setTableStateIfNotInStates(tableName TableName, newState TableState.State, states TableState.State...) : boolean in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable v : CollectAllVisitor to visitor : Visitor in method public fullScan(connection Connection, visitor Visitor, startrow byte[], type QueryType) : void in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Rename Attribute | 1 | ||
Rename Attribute descriptors : TableDescriptors to master : MasterServices in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Extract Variable | 3 | ||
Extract Variable builder : HBaseProtos.TableDescriptor.Builder in method public convert() : HBaseProtos.TableDescriptor from class org.apache.hadoop.hbase.TableDescriptor | From | To | |
Extract Variable tableName : TableName in method public testCreateTable() : void from class org.apache.hadoop.hbase.client.TestAdmin1 | From | To | |
Extract Variable e : Delete in method public deleteRegions(connection Connection, regionsInfo List<HRegionInfo>) : void from class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Change Variable Type | 6 | ||
Change Variable Type v : CollectAllVisitor to visitor : Visitor in method public fullScan(connection Connection, visitor Visitor, startrow byte[], type QueryType) : void in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Change Variable Type descriptor : TableDescriptor to currentState : TableState in method public setTableStateIfNotInStates(tableName TableName, newState TableState.State, states TableState.State...) : boolean in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Change Variable Type server : Server to server : MasterServices in method public testCanMakeProgressThoughMetaIsDown() : void in class org.apache.hadoop.hbase.master.TestRegionStates | From | To | |
Change Variable Type descriptor : TableDescriptor to currentState : TableState in method public setTableStateIfInStates(tableName TableName, newState TableState.State, states TableState.State...) : boolean in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Change Variable Type tableName : TableName to tableDescriptors : TableDescriptors in method public start() : void in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Change Variable Type server : Server to server : MasterServices in method public testWeDontReturnDrainingServersForOurBalancePlans() : void in class org.apache.hadoop.hbase.master.TestRegionStates | From | To | |
Change Attribute Type | 3 | ||
Change Attribute Type descriptors : TableDescriptors to master : MasterServices in class org.apache.hadoop.hbase.master.TableStateManager | From | To | |
Change Attribute Type server : Server to server : MasterServices in class org.apache.hadoop.hbase.master.AssignmentManager | From | To | |
Change Attribute Type server : Server to server : MasterServices in class org.apache.hadoop.hbase.master.RegionStates | From | To | |
Extract Method | 6 | ||
Extract Method private isTableDisabled(tableName TableName) : boolean extracted from private checkRegionConsistency(key String, hbi HbckInfo) : void in class org.apache.hadoop.hbase.util.HBaseFsck | From | To | |
Extract Method protected getFsTableDescriptors() : TableDescriptors extracted from public HRegionServer(conf Configuration, csm CoordinatedStateManager) in class org.apache.hadoop.hbase.regionserver.HRegionServer | From | To | |
Extract Method public fullScan(connection Connection, visitor Visitor, startrow byte[], type QueryType) : void extracted from public fullScanOfMeta(connection Connection) : List<Result> in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Extract Method public fullScan(connection Connection, visitor Visitor, startrow byte[], type QueryType) : void extracted from public getTableRegionsAndLocations(connection Connection, tableName TableName, excludeOfflinedSplitParents boolean) : List<Pair<HRegionInfo,ServerName>> in class org.apache.hadoop.hbase.MetaTableAccessor | From | To | |
Extract Method public fullScan(connection Connection, visitor Visitor, startrow byte[], type QueryType) : void extracted from public fullScan(connection Connection, visitor Visitor) : void in class org.apache.hadoop.hbase.MetaTableAccessor | From | To |