25e123f37d0fa71e4ad6e02f78404fa5b73be169
Files Diff
- Added: 2
- Removed: 3
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public authProvider() : InjectableProvider<Auth,Parameter> renamed to public authenticator() : Authenticator<CrtAccessToken> in class com.spotify.helios.auth.crt.CrtServerAuthentication | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type isAuthRequired : Predicate<HttpHeaders> to isAuthRequired : Predicate<HttpRequestContext> in method public AuthInjectableProvider(authenticator Authenticator<C>, scheme String, isAuthRequired Predicate<HttpRequestContext>) in class com.spotify.helios.auth.AuthInjectableProvider | From | To | |
| Change Parameter Type authRequired : Predicate<HttpHeaders> to authRequired : Predicate<HttpRequestContext> in method private newProvider(authRequired Predicate<HttpRequestContext>) : AuthInjectableProvider<String> in class com.spotify.helios.auth.AuthInjectableProviderTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable headers : HttpHeaders to request : HttpRequestContext in method public getValue(c HttpContext) : Object in class com.spotify.helios.auth.AuthInjectableProvider.getInjectable | From | To | |
| Change Return Type | 1 | ||
| Change Return Type InjectableProvider<Auth,Parameter> to Authenticator<CrtAccessToken> in method public authenticator() : Authenticator<CrtAccessToken> in class com.spotify.helios.auth.crt.CrtServerAuthentication | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type headers : HttpHeaders to request : HttpRequestContext in method public getValue(c HttpContext) : Object in class com.spotify.helios.auth.AuthInjectableProvider.getInjectable | From | To | |
| Extract Method | 1 | ||
| Extract Method private setupAuthentication(environment Environment, config MasterConfig) : void extracted from public MasterService(config MasterConfig, environment Environment, curatorClientFactory CuratorClientFactory) in class com.spotify.helios.master.MasterService | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type isAuthRequired : Predicate<HttpHeaders> to isAuthRequired : Predicate<HttpRequestContext> in class com.spotify.helios.auth.AuthInjectableProvider | From | To |