34b4149cf2e95fbf8bf7cf2f61d79b696f938a10
Files Diff
- Added: 2
- Removed: 4
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Inline Method | 2 | ||
| Inline Method private mockHostStatus(model MasterModel, host String) : Map<String,HostStatus> inlined to public testUpdateDeploymentGroupHosts() : void in class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Inline Method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, changes HostChanges, zooKeeperClient ZooKeeperClient) : RollingUpdateOp inlined to public updateDeploymentGroupHosts(groupName String, hosts List<String>) : void in class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Change Return Type | 1 | ||
| Change Return Type RollingUpdatePlanner to DefaultRolloutPlanner in method public of(deploymentGroup DeploymentGroup) : DefaultRolloutPlanner in class com.spotify.helios.rollingupdate.DefaultRolloutPlanner | From | To | |
| Rename Class | 2 | ||
| Rename Class com.spotify.helios.rollingupdate.RollingUpdatePlannerTest renamed to com.spotify.helios.rollingupdate.DefaultRolloutPlannerTest | From | To | |
| Rename Class com.spotify.helios.rollingupdate.RollingUpdatePlanner renamed to com.spotify.helios.rollingupdate.DefaultRolloutPlanner | From | To | |
| Extract Variable | 1 | ||
| Extract Variable opFactory : RollingUpdateOpFactory in method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, hosts List<String>, zooKeeperClient ZooKeeperClient) : RollingUpdateOp from class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type events : List<Map<String,Object>> to events : ImmutableList<Map<String,Object>> in method public updateDeploymentGroupHosts(groupName String, hosts List<String>) : void in class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Inline Variable | 1 | ||
| Inline Variable changed : DeploymentGroup in method public testUpdateDeploymentGroupHosts() : void from class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter updateHosts : List<String> to hosts : List<String> in method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, hosts List<String>, zooKeeperClient ZooKeeperClient) : RollingUpdateOp in class com.spotify.helios.master.ZooKeeperMasterModel | From | To |