helios 35e66ffe7e76a23119a0e5bb8a68bbab0b386b3f

35e66ffe7e76a23119a0e5bb8a68bbab0b386b3f

Files Diff

Added: 6
Removed: 2
Renamed: 0
Modified: 9

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method public getVersion() : int from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to public version() : int from class com.spotify.helios.servicescommon.VersionedValue	From	To
Move Method	10
Move Method public equals(o Object) : boolean from class com.spotify.helios.common.descriptors.DeploymentGroupEvent to public equals(o Object) : boolean from class com.spotify.helios.servicescommon.coordination.Delete	From	To
Move Method public hashCode() : int from class com.spotify.helios.common.descriptors.DeploymentGroupEvent to public hashCode() : int from class com.spotify.helios.servicescommon.coordination.SetData	From	To
Move Method public hashCode() : int from class com.spotify.helios.master.ZooKeeperMasterModel.RollingUpdateTaskResult to public hashCode() : int from class com.spotify.helios.servicescommon.coordination.SetData	From	To
Move Method public setTaskIndex(taskIndex int) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to public setTaskIndex(taskIndex int) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Move Method public getDeploymentGroup() : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to public getDeploymentGroup() : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Move Method public setRolloutTasks(rolloutTasks List<RolloutTask>) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to public setRolloutTasks(rolloutTasks List<RolloutTask>) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Move Method public equals(o Object) : boolean from class com.spotify.helios.master.ZooKeeperMasterModel.RollingUpdateTaskResult to public equals(o Object) : boolean from class com.spotify.helios.servicescommon.coordination.Delete	From	To
Move Method public getRolloutTasks() : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to public getRolloutTasks() : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Move Method public getTaskIndex() : int from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to public getTaskIndex() : int from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Move Method public setDeploymentGroup(deploymentGroup DeploymentGroup) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to public setDeploymentGroup(deploymentGroup DeploymentGroup) : Builder from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Change Return Type	1
Change Return Type RollingUpdateTaskResult to RollingUpdateOp in method private rollingUpdateUndeploy(client ZooKeeperClient, opFactory RollingUpdateOpFactory, deploymentGroup DeploymentGroup, host String) : RollingUpdateOp in class com.spotify.helios.master.ZooKeeperMasterModel	From	To
Move Attribute	7
Move Attribute private rolloutTasks : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to private rolloutTasks : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Move Attribute private deploymentGroup : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to private deploymentGroup : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Move Attribute private rolloutTasks : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to private rolloutTasks : List<RolloutTask> from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Move Attribute private deploymentGroup : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to private deploymentGroup : DeploymentGroup from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Move Attribute public KAFKA_TOPIC : String from class com.spotify.helios.common.descriptors.DeploymentGroupEvent to private KAFKA_TOPIC : String from class com.spotify.helios.master.ZooKeeperMasterModel	From	To
Move Attribute private taskIndex : int from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder to private taskIndex : int from class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder	From	To
Move Attribute private taskIndex : int from class com.spotify.helios.common.descriptors.DeploymentGroupStatus to private taskIndex : int from class com.spotify.helios.common.descriptors.DeploymentGroupTasks	From	To
Extract Class	1
Extract Class com.spotify.helios.common.descriptors.DeploymentGroupTasks.Builder from class com.spotify.helios.common.descriptors.DeploymentGroupStatus.Builder	From	To
Inline Variable	1
Inline Variable statusPath : String in method public rollingUpdate(deploymentGroup DeploymentGroup, jobId JobId, options RolloutOptions) : void from class com.spotify.helios.master.ZooKeeperMasterModel	From	To

35e66ffe7e76a23119a0e5bb8a68bbab0b386b3f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: