657631ce7b450bed0963bc89c1d3f35c264874dc
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 3
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type event : TEvent to event : TaskStatusEvent in method private putBack(event TaskStatusEvent) : void in class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Change Parameter Type eventsPath : String to jobId : JobId in method private trimStatusEvents(events List<String>, jobId JobId) : void in class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Change Parameter Type key : String to key : JobId in method private getDeque(key JobId) : Deque<TaskStatusEvent> in class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Method | 5 | ||
| Move Method private getDeque(key String) : Deque<TEvent> from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private getDeque(key JobId) : Deque<TaskStatusEvent> from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Method public isEmpty() : boolean from class com.spotify.helios.servicescommon.QueueingHistoryWriter to public isEmpty() : boolean from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Method private putBack(event TEvent) : void from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private putBack(event TaskStatusEvent) : void from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Method private trimStatusEvents(events List<String>, eventsPath String) : void from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private trimStatusEvents(events List<String>, jobId JobId) : void from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Method protected shutDown() : void from class com.spotify.helios.servicescommon.QueueingHistoryWriter to protected shutDown() : void from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Deque<TEvent> to Deque<TaskStatusEvent> in method private getDeque(key JobId) : Deque<TaskStatusEvent> in class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private count : AtomicInteger from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private count : AtomicInteger from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Attribute private client : ZooKeeperClient from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private client : ZooKeeperClient from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Move Attribute private zkWriterExecutor : ScheduledExecutorService from class com.spotify.helios.servicescommon.QueueingHistoryWriter to private zkWriterExecutor : ScheduledExecutorService from class com.spotify.helios.agent.TaskHistoryWriter | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter eventsPath : String to jobId : JobId in method private trimStatusEvents(events List<String>, jobId JobId) : void in class com.spotify.helios.agent.TaskHistoryWriter | From | To |