be94e129363143ab008422a48e103e64a1693e29
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Return Type | 1 | ||
| Change Return Type DefaultRolloutPlanner to RollingUpdatePlanner in method public of(deploymentGroup DeploymentGroup) : RollingUpdatePlanner in class com.spotify.helios.rollingupdate.RollingUpdatePlanner | From | To | |
| Rename Class | 2 | ||
| Rename Class com.spotify.helios.rollingupdate.DefaultRolloutPlanner renamed to com.spotify.helios.rollingupdate.RollingUpdatePlanner | From | To | |
| Rename Class com.spotify.helios.rollingupdate.DefaultRolloutPlannerTest renamed to com.spotify.helios.rollingupdate.RollingUpdatePlannerTest | From | To | |
| Merge Variable | 1 | ||
| Merge Variable [hosts : List<String>, client : ZooKeeperClient] to changes : HostChanges in method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, changes HostChanges, zooKeeperClient ZooKeeperClient) : RollingUpdateOp in class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable client : ZooKeeperClient to zooKeeperClient : ZooKeeperClient in method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, changes HostChanges, zooKeeperClient ZooKeeperClient) : RollingUpdateOp in class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Parameterize Variable masterModel : ZooKeeperMasterModel to model : MasterModel in method private mockHostStatus(model MasterModel, host String) : Map<String,HostStatus> in class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Extract Variable | 2 | ||
| Extract Variable newHost : String in method public testUpdateDeploymentGroupHosts() : void from class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Extract Variable changed : DeploymentGroup in method public testUpdateDeploymentGroupHosts() : void from class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type events : ImmutableList<Map<String,Object>> to events : List<Map<String,Object>> in method public updateDeploymentGroupHosts(groupName String, hosts List<String>) : void in class com.spotify.helios.master.ZooKeeperMasterModel | From | To | |
| Change Variable Type masterModel : ZooKeeperMasterModel to model : MasterModel in method private mockHostStatus(model MasterModel, host String) : Map<String,HostStatus> in class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Extract Method | 2 | ||
| Extract Method private mockHostStatus(model MasterModel, host String) : Map<String,HostStatus> extracted from public testUpdateDeploymentGroupHosts() : void in class com.spotify.helios.master.DeploymentGroupTest | From | To | |
| Extract Method private getInitRollingUpdateOps(deploymentGroup DeploymentGroup, changes HostChanges, zooKeeperClient ZooKeeperClient) : RollingUpdateOp extracted from public updateDeploymentGroupHosts(groupName String, hosts List<String>) : void in class com.spotify.helios.master.ZooKeeperMasterModel | From | To |