honest-profiler dfef87cf1118deac63f9d2ee2c0c14304ad2e7f4

dfef87cf1118deac63f9d2ee2c0c14304ad2e7f4

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	9
Change Parameter Type threadId : long to threadId : String in method public ThreadNodeAdapter(threadId String, threadName String, nrOfSamples long) in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.ThreadNodeAdapter	From	To
Change Parameter Type tree : ProfileTree to tree : AggregatedNode in method public update(tree AggregatedNode) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.ThreadNodeAdapter	From	To
Change Parameter Type profileNode : ProfileNode to profileNode : AggregatedNode in method protected updateItem(profileNode AggregatedNode, empty boolean) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.cell.TreeViewCell	From	To
Change Parameter Type diff : FlatProfileDiff to entries : List<AggregatedDiffEntry> in method public writeFlatProfileDiffCsv(out PrintWriter, entries List<AggregatedDiffEntry>, mode Mode) : void in class com.insightfullogic.honest_profiler.ports.javafx.util.report.ReportUtil	From	To
Change Parameter Type treeItem : TreeItem<ProfileNode> to treeItem : TreeItem<AggregatedNode> in method private buildProfileNodeCell(treeItem TreeItem<AggregatedNode>) : StringProperty in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Parameter Type trees : List<ProfileTree> to trees : List<AggregatedNode> in method public update(trees List<AggregatedNode>) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Parameter Type entries : List<FlatProfileEntry> to entries : List<AggregatedEntry> in method public writeFlatProfileCsv(out PrintWriter, entries List<AggregatedEntry>, mode Mode) : void in class com.insightfullogic.honest_profiler.ports.javafx.util.report.ReportUtil	From	To
Change Parameter Type profileNode : ProfileNode to profileNode : AggregatedNode in method public update(profileNode AggregatedNode) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.MethodNodeAdapter	From	To
Change Parameter Type profileNode : ProfileNode to profileNode : AggregatedNode in method private renderMethodNode(profileNode AggregatedNode, empty boolean) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.cell.TreeViewCell	From	To
Inline Method	1
Inline Method private openFile(profileContext ProfileContext, file File) : void inlined to protected call() : ProfileContext in class com.insightfullogic.honest_profiler.ports.javafx.model.task.InitializeProfileTask	From	To
Change Return Type	4
Change Return Type ProfileListener to LeanProfileListener in method public getProfileListener() : LeanProfileListener in class com.insightfullogic.honest_profiler.ports.javafx.model.ProfileContext	From	To
Change Return Type long to String in method public getThreadId() : String in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.ThreadNodeAdapter	From	To
Change Return Type Profile to AggregationProfile in method public getProfile() : AggregationProfile in class com.insightfullogic.honest_profiler.ports.javafx.model.ProfileContext	From	To
Change Return Type ObjectProperty<Profile> to ObjectProperty<AggregationProfile> in method public profileProperty() : ObjectProperty<AggregationProfile> in class com.insightfullogic.honest_profiler.ports.javafx.model.ProfileContext	From	To
Rename Class	1
Rename Class com.insightfullogic.honest_profiler.ports.javafx.model.task.CopyAndFilterProfile renamed to com.insightfullogic.honest_profiler.ports.javafx.model.task.CopyAndFilterProfileTask	From	To
Rename Attribute	1
Rename Attribute applicationContext : ApplicationContext to appCtx : ApplicationContext in class com.insightfullogic.honest_profiler.ports.javafx.model.task.InitializeProfileTask	From	To
Change Variable Type	9
Change Variable Type children : ObservableList<TreeItem<ProfileNode>> to children : ObservableList<TreeItem<AggregatedNode>> in method public update(profileNode AggregatedNode) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.MethodNodeAdapter	From	To
Change Variable Type present : Set<Long> to present : Set<String> in method public update(trees List<AggregatedNode>) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Variable Type threadId : long to threadId : String in method public update(trees List<AggregatedNode>) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Variable Type children : ObservableList<TreeItem<ProfileNode>> to children : ObservableList<TreeItem<AggregatedNode>> in method public update(trees List<AggregatedNode>) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Variable Type treeItem : TreeItem<ProfileNode> to treeItem : TreeItem<AggregatedNode> in method protected updateItem(profileNode AggregatedNode, empty boolean) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.cell.TreeViewCell	From	To
Change Variable Type task : CopyAndFilterProfile to task : CopyAndFilterProfileTask in method private updateDiff(profile Profile, base boolean) : void in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Variable Type tree : ProfileTree to tree : AggregatedNode in method public update(trees List<AggregatedNode>) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Variable Type present : Set<Long> to present : Set<String> in method public update(profileNode AggregatedNode) : void in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.MethodNodeAdapter	From	To
Change Variable Type task : CopyAndFilterProfile to task : CopyAndFilterProfileTask in method private updateDiff(profile Profile, base boolean) : void in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Extract Interface	1
Extract Interface com.insightfullogic.honest_profiler.core.collector.lean.ProfileSource from classes [com.insightfullogic.honest_profiler.core.collector.lean.LeanLogCollector]	From	To
Change Attribute Type	56
Change Attribute Type baseSelfPct : TreeTableColumn<NodeDiff,Number> to baseSelfPct : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type totalPct : TreeTableColumn<ProfileNode,Number> to totalPct : TreeTableColumn<AggregatedNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type baseProfileCnt : TableColumn<FlatEntryDiff,Number> to baseProfileCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type baseTotalPct : TreeTableColumn<NodeDiff,Number> to baseTotalPct : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type threadId : long to threadId : String in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.ThreadNodeAdapter	From	To
Change Attribute Type newParentCnt : TreeTableColumn<NodeDiff,Number> to newParentCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type totalPctDiff : TreeTableColumn<NodeDiff,Number> to totalPctDiff : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type baseTotalCnt : TreeTableColumn<NodeDiff,Number> to baseTotalCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type newProfileCnt : TableColumn<FlatEntryDiff,Number> to newProfileCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type selfPct : TableColumn<FlatProfileEntry,Number> to selfPct : TableColumn<AggregatedEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type baseTotalPct : TableColumn<FlatEntryDiff,Number> to baseTotalPct : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type selfCntDiff : TreeTableColumn<NodeDiff,Number> to selfCntDiff : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type selfPctDiff : TableColumn<FlatEntryDiff,Number> to selfPctDiff : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type totalCntDiff : TableColumn<FlatEntryDiff,Number> to totalCntDiff : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type selfCnt : TreeTableColumn<ProfileNode,Number> to selfCnt : TreeTableColumn<AggregatedNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type newSelfPct : TableColumn<FlatEntryDiff,Number> to newSelfPct : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type newSelfCnt : TreeTableColumn<NodeDiff,Number> to newSelfCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type profileCntDiff : TableColumn<FlatEntryDiff,Number> to profileCntDiff : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type childrenByMethodId : Map<Long,MethodNodeAdapter> to childrenByMethodId : Map<String,MethodNodeAdapter> in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.MethodNodeAdapter	From	To
Change Attribute Type parentCnt : TreeTableColumn<ProfileNode,Number> to parentCnt : TreeTableColumn<AggregatedNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type flatProfileView : TableView<FlatProfileEntry> to flatProfileView : TableView<AggregatedEntry> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type flatProfile : ObservableList<FlatProfileEntry> to flatProfile : ObservableList<AggregatedEntry> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type parentCntDiff : TreeTableColumn<NodeDiff,Number> to parentCntDiff : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type baseParentCnt : TreeTableColumn<NodeDiff,Number> to baseParentCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type diffTree : TreeTableView<NodeDiff> to diffTree : TreeTableView<AggregatedDiffNode> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type newTotalCnt : TreeTableColumn<NodeDiff,Number> to newTotalCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type selfPct : TreeTableColumn<ProfileNode,Number> to selfPct : TreeTableColumn<AggregatedNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type newTotalCnt : TableColumn<FlatEntryDiff,Number> to newTotalCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type selfCnt : TableColumn<FlatProfileEntry,Number> to selfCnt : TableColumn<AggregatedEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type newTotalPct : TableColumn<FlatEntryDiff,Number> to newTotalPct : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type newSelfPct : TreeTableColumn<NodeDiff,Number> to newSelfPct : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type methodColumn : TreeTableColumn<ProfileNode,String> to methodColumn : TreeTableColumn<AggregatedNode,String> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type totalCnt : TableColumn<FlatProfileEntry,Number> to totalCnt : TableColumn<AggregatedEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type cachedProfile : Profile to cachedProfile : LeanProfile in class com.insightfullogic.honest_profiler.ports.javafx.model.ProfileContext	From	To
Change Attribute Type totalPct : TableColumn<FlatProfileEntry,Number> to totalPct : TableColumn<AggregatedEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type newSelfCnt : TableColumn<FlatEntryDiff,Number> to newSelfCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type percentColumn : TreeTableColumn<ProfileNode,ProfileNode> to percentColumn : TreeTableColumn<AggregatedNode,AggregatedNode> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type threadsById : Map<Long,ThreadNodeAdapter> to threadsById : Map<String,ThreadNodeAdapter> in class com.insightfullogic.honest_profiler.ports.javafx.view.tree.RootNodeAdapter	From	To
Change Attribute Type method : TableColumn<FlatEntryDiff,String> to method : TableColumn<AggregatedDiffEntry,String> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type selfCntDiff : TableColumn<FlatEntryDiff,Number> to selfCntDiff : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type totalCntDiff : TreeTableColumn<NodeDiff,Number> to totalCntDiff : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type newTotalPct : TreeTableColumn<NodeDiff,Number> to newTotalPct : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type baseSelfCnt : TreeTableColumn<NodeDiff,Number> to baseSelfCnt : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type totalCnt : TreeTableColumn<ProfileNode,Number> to totalCnt : TreeTableColumn<AggregatedNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type method : TableColumn<FlatProfileEntry,String> to method : TableColumn<AggregatedEntry,String> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type treeView : TreeTableView<ProfileNode> to treeView : TreeTableView<AggregatedNode> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeViewController	From	To
Change Attribute Type profile : SimpleObjectProperty<Profile> to profile : SimpleObjectProperty<AggregationProfile> in class com.insightfullogic.honest_profiler.ports.javafx.model.ProfileContext	From	To
Change Attribute Type selfTimeGraphical : TableColumn<FlatProfileEntry,Double> to selfTimeGraphical : TableColumn<AggregatedEntry,Double> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type profileCnt : TableColumn<FlatProfileEntry,Number> to profileCnt : TableColumn<AggregatedEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatViewController	From	To
Change Attribute Type diffTable : TableView<FlatEntryDiff> to diffTable : TableView<AggregatedDiffEntry> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type baseSelfCnt : TableColumn<FlatEntryDiff,Number> to baseSelfCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type methodColumn : TreeTableColumn<NodeDiff,String> to methodColumn : TreeTableColumn<AggregatedDiffNode,String> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type selfPctDiff : TreeTableColumn<NodeDiff,Number> to selfPctDiff : TreeTableColumn<AggregatedDiffNode,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.TreeDiffViewController	From	To
Change Attribute Type totalPctDiff : TableColumn<FlatEntryDiff,Number> to totalPctDiff : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type baseSelfPct : TableColumn<FlatEntryDiff,Number> to baseSelfPct : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Change Attribute Type baseTotalCnt : TableColumn<FlatEntryDiff,Number> to baseTotalCnt : TableColumn<AggregatedDiffEntry,Number> in class com.insightfullogic.honest_profiler.ports.javafx.controller.FlatDiffViewController	From	To
Rename Parameter	1
Rename Parameter diff : FlatProfileDiff to entries : List<AggregatedDiffEntry> in method public writeFlatProfileDiffCsv(out PrintWriter, entries List<AggregatedDiffEntry>, mode Mode) : void in class com.insightfullogic.honest_profiler.ports.javafx.util.report.ReportUtil	From	To

dfef87cf1118deac63f9d2ee2c0c14304ad2e7f4

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: