0354a41b94e891273a06587c6cea95aaee15d995
Files Diff
- Added: 2
- Removed: 5
- Renamed: 0
- Modified: 46
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 1 | ||
Change Parameter Type entries : Collection<GridCacheEntryEx<K,V>> to entries : List<GridCacheEntryEx<K,V>> in method package lockAllAsync(cacheCtx GridCacheContext<K,V>, entries List<GridCacheEntryEx<K,V>>, onePhaseCommit boolean, msgId long, read boolean, accessTtl long) : IgniteFuture<GridCacheReturn<V>> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
Move Method | 2 | ||
Move Method public cloneEntries() : void from class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxFinishRequest to public cloneEntries() : void from class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxPrepareRequest | From | To | |
Move Method public onePhaseCommit() : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishRequest to public onePhaseCommit() : boolean from class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxPrepareRequest | From | To | |
Pull Up Attribute | 2 | ||
Pull Up Attribute private txNodes : Map<UUID,Collection<UUID>> from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxRemote to protected txNodes : Map<UUID,Collection<UUID>> from class org.apache.ignite.internal.processors.cache.transactions.IgniteTxAdapter | From | To | |
Pull Up Attribute private txNodes : Map<UUID,Collection<UUID>> from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocal to protected txNodes : Map<UUID,Collection<UUID>> from class org.apache.ignite.internal.processors.cache.transactions.IgniteTxAdapter | From | To | |
Move Attribute | 1 | ||
Move Attribute private onePhaseCommit : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishRequest to private onePhaseCommit : boolean from class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxPrepareRequest | From | To | |
Change Variable Type | 2 | ||
Change Variable Type dhtTx : GridDhtTxRemote<K,V> to tx : GridDistributedTxRemoteAdapter<K,V> in method protected finish(nodeId UUID, tx GridDistributedTxRemoteAdapter<K,V>, req GridDhtTxPrepareRequest<K,V>) : void in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler | From | To | |
Change Variable Type v : GridCacheVersion to e : Map.Entry<GridCacheVersion,Boolean> in method private copyOf(map Map<GridCacheVersion,Boolean>, expVal boolean) : Collection<GridCacheVersion> in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
Extract Variable | 3 | ||
Extract Variable entries : List<GridDhtCacheEntry<K,V>> in method private addMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>, dst Map<UUID,GridDistributedTxMapping<K,V>>) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
Extract Variable needVal : boolean in method private map(entries Iterable<GridDhtCacheEntry<K,V>>) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtLockFuture | From | To | |
Extract Variable dhtWrites : Collection<IgniteTxEntry<K,V>> in method private prepare0() : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareFuture | From | To | |
Extract Method | 3 | ||
Extract Method private createPrepareResponse() : GridNearTxPrepareResponse<K,V> extracted from public onDone(tx0 IgniteTxEx<K,V>, err Throwable) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareFuture | From | To | |
Extract Method protected finish(nodeId UUID, tx GridDistributedTxRemoteAdapter<K,V>, req GridDhtTxPrepareRequest<K,V>) : void extracted from protected processDhtTxPrepareRequest(nodeId UUID, req GridDhtTxPrepareRequest<K,V>) : void in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler | From | To | |
Extract Method private sendPrepareResponse(res GridNearTxPrepareResponse<K,V>) : void extracted from public onDone(tx0 IgniteTxEx<K,V>, err Throwable) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareFuture | From | To | |
Rename Method | 4 | ||
Rename Method package addNearMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>) : void renamed to package addNearNodeEntryMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
Rename Method package addDhtMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>) : void renamed to package addDhtNodeEntryMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
Rename Method public commitVersion() : GridCacheVersion renamed to public writeVersion() : GridCacheVersion in class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxPrepareRequest | From | To | |
Rename Method public committedVersionsSize() : int renamed to public completedVersionsSize() : int in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
Rename Variable | 1 | ||
Rename Variable v : GridCacheVersion to e : Map.Entry<GridCacheVersion,Boolean> in method private copyOf(map Map<GridCacheVersion,Boolean>, expVal boolean) : Collection<GridCacheVersion> in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable dhtTx : GridDhtTxRemote<K,V> to tx : GridDistributedTxRemoteAdapter<K,V> in method protected finish(nodeId UUID, tx GridDistributedTxRemoteAdapter<K,V>, req GridDhtTxPrepareRequest<K,V>) : void in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler | From | To | |
Rename Attribute | 2 | ||
Rename Attribute committedVers : GridBoundedConcurrentOrderedSet<GridCacheVersion> to completedVers : GridBoundedConcurrentOrderedMap<GridCacheVersion,Boolean> in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
Rename Attribute commitVer : GridCacheVersion to writeVer : GridCacheVersion in class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxPrepareRequest | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type committedVers : GridBoundedConcurrentOrderedSet<GridCacheVersion> to completedVers : GridBoundedConcurrentOrderedMap<GridCacheVersion,Boolean> in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method package onError(e Throwable) : void extracted from public prepareAsync() : IgniteFuture<IgniteTxEx<K,V>> in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxLocal & moved to class org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxPrepareFuture | From | To | |
Rename Parameter | 1 | ||
Rename Parameter map : Map<UUID,GridDistributedTxMapping<K,V>> to dst : Map<UUID,GridDistributedTxMapping<K,V>> in method private addMapping(mappings Map<ClusterNode,List<GridDhtCacheEntry<K,V>>>, dst Map<UUID,GridDistributedTxMapping<K,V>>) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To |