0b4a8f831fe2d183e6e831c90da0d3fc86ac2ed0
Files Diff
- Added: 14
- Removed: 6
- Renamed: 0
- Modified: 43
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 8 | ||
| Rename Method public updateMetaData(typeId int, meta BinaryMetadata) : void renamed to public updateMetadata(typeId int, meta BinaryMetadata) : void in class org.apache.ignite.internal.portable.PortableContext | From | To | |
| Rename Method public updateMetaData(typeId int, typeName String, affKeyFieldName String, fieldTypeIds Map<String,Integer>) : void renamed to public updateMetadata(typeId int, typeName String, affKeyFieldName String, fieldTypeIds Map<String,Integer>) : void in class org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessor | From | To | |
| Rename Method public testDefaultMapping() : void renamed to public _testDefaultMapping() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Method public updateMetaData(typeId int, typeName String, affKeyFieldName String, fieldTypeIds Map<String,Integer>) : void renamed to public updateMetadata(typeId int, typeName String, affKeyFieldName String, fieldTypeIds Map<String,Integer>) : void in class org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessorImpl | From | To | |
| Rename Method private BinaryObject() : TestBinary renamed to private binaryObject() : TestBinary in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Method public fieldOffsetSize(flags short) : int renamed to public fieldOffsetLength(flags short) : int in class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Rename Method protected initPortableContext(marsh PortableMarshaller) : PortableContext renamed to private initializePortableContext(marsh PortableMarshaller) : PortableContext in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Method public metaData(typeId int) : BinaryType renamed to public metadata(typeId int) : BinaryType in class org.apache.ignite.internal.portable.PortableContext | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private checkMeta(typeId int, oldMeta BinaryMetadata, newMeta BinaryMetadata, fields Map<String,Integer>) : boolean from class org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessorImpl to public mergeMetadata(oldMeta BinaryMetadata, newMeta BinaryMetadata) : BinaryMetadata from class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public updateMetaData(typeId int, typeName String, fields Map<String,Integer>) : void moved from class org.apache.ignite.internal.portable.PortableContext to class org.apache.ignite.internal.portable.PortableClassDescriptor & inlined to package write(obj Object, writer BinaryWriterExImpl) : void | From | To | |
| Rename Variable | 12 | ||
| Rename Variable metadata : BinaryType to meta : BinaryType in method package serializeTo(writer BinaryWriterExImpl, serializer PortableBuilderSerializer) : void in class org.apache.ignite.internal.portable.builder.BinaryObjectBuilderImpl | From | To | |
| Rename Variable fieldOffsetSize : int to fieldOffsetLen : int in method private ensureReadCacheInit() : void in class org.apache.ignite.internal.portable.builder.BinaryObjectBuilderImpl | From | To | |
| Rename Variable idx0 : int to curIdx : int in method public write(writer BinaryWriterExImpl, fieldCnt int, compactFooter boolean) : int in class org.apache.ignite.internal.portable.BinaryWriterExImpl.SchemaHolder | From | To | |
| Rename Variable res : BinaryMetadata to mergedMeta : BinaryMetadata in method public process(entry MutableEntry<PortableMetadataKey,BinaryMetadata>, args Object...) : BinaryObjectException in class org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessorImpl.MetadataProcessor | From | To | |
| Rename Variable fieldOffsetSize : int to fieldOffsetLen : int in method protected fieldByOrder(order int) : F in class org.apache.ignite.internal.portable.BinaryObjectImpl | From | To | |
| Rename Variable metaCollector : BinaryMetadataCollector to collector : BinaryMetadataCollector in method package write(obj Object, writer BinaryWriterExImpl) : void in class org.apache.ignite.internal.portable.PortableClassDescriptor | From | To | |
| Rename Variable marsh2 : PortableMarshaller to marsh : PortableMarshaller in method private createMarshaller() : PortableMarshaller in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Variable fieldOffsetSize : int to fieldOffsetLen : int in method protected fieldByOrder(order int) : F in class org.apache.ignite.internal.portable.BinaryObjectOffheapImpl | From | To | |
| Rename Variable marsh1 : PortableMarshaller to marsh : PortableMarshaller in method private createMarshaller() : PortableMarshaller in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Variable newFldsMetadata : Map<String,Integer> to fieldsMeta : Map<String,Integer> in method package serializeTo(writer BinaryWriterExImpl, serializer PortableBuilderSerializer) : void in class org.apache.ignite.internal.portable.builder.BinaryObjectBuilderImpl | From | To | |
| Change Return Type | 1 | ||
| Change Return Type boolean to BinaryMetadata in method public mergeMetadata(oldMeta BinaryMetadata, newMeta BinaryMetadata) : BinaryMetadata in class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private FNV1_OFFSET_BASIS : int from class org.apache.ignite.internal.portable.BinaryWriterExImpl to private FNV1_OFFSET_BASIS : int from class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Move Attribute private FNV1_PRIME : int from class org.apache.ignite.internal.portable.BinaryWriterExImpl to private FNV1_PRIME : int from class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Rename Class | 7 | ||
| Rename Class org.apache.ignite.internal.portable.GridBinaryObjectBuilderSelfTest renamed to org.apache.ignite.internal.portable.BinaryObjectBuilderSelfTest | From | To | |
| Rename Class org.apache.ignite.internal.portable.PortableCompactOffsetsHeapSelfTest renamed to org.apache.ignite.internal.portable.BinaryFooterOffsetsHeapSelfTest | From | To | |
| Rename Class org.apache.ignite.internal.portable.GridPortableMarshallerSelfTest renamed to org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Rename Class org.apache.ignite.internal.portable.PortableCompactOffsetsAbstractSelfTest renamed to org.apache.ignite.internal.portable.BinaryFooterOffsetsAbstractSelfTest | From | To | |
| Rename Class org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessorImpl.MetaDataProcessor renamed to org.apache.ignite.internal.processors.cache.portable.CacheObjectBinaryProcessorImpl.MetadataProcessor | From | To | |
| Rename Class org.apache.ignite.internal.portable.PortableCompactOffsetsOffheapSelfTest renamed to org.apache.ignite.internal.portable.BinaryFooterOffsetsOffheapSelfTest | From | To | |
| Rename Class org.apache.ignite.internal.portable.GridBinaryObjectBuilderAdditionalSelfTest renamed to org.apache.ignite.internal.portable.BinaryObjectBuilderAdditionalSelfTest | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute offsetSize : int to fieldOffsetLen : int in class org.apache.ignite.internal.portable.BinaryReaderExImpl | From | To | |
| Rename Attribute fieldsMeta : Map<String,Integer> to stableFieldsMeta : Map<String,Integer> in class org.apache.ignite.internal.portable.PortableClassDescriptor | From | To | |
| Rename Attribute map : HashMap<Integer,Integer> to idToOrder : HashMap<Integer,Integer> in class org.apache.ignite.internal.portable.PortableSchema | From | To | |
| Extract Variable | 4 | ||
| Extract Variable marsh0 : PortableMarshaller in method protected apply0(igniteCfg IgniteConfiguration) : void from class org.apache.ignite.internal.processors.platform.cpp.PlatformCppConfigurationClosure | From | To | |
| Extract Variable resBinary : BinaryObject in method public testFloatArrayModification() : void from class org.apache.ignite.internal.portable.BinaryObjectBuilderAdditionalSelfTest | From | To | |
| Extract Variable marsh0 : PortableMarshaller in method protected apply0(igniteCfg IgniteConfiguration) : void from class org.apache.ignite.internal.processors.platform.dotnet.PlatformDotNetConfigurationClosure | From | To | |
| Extract Variable binary : BinaryObject in method public testRemoveFromExistingObject() : void from class org.apache.ignite.internal.portable.BinaryObjectBuilderSelfTest | From | To | |
| Extract Method | 48 | ||
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyObject() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyNonPrimitives() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testFinalField() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testTypeNames() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopy() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testSimpleObject() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyDoubleArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyUuid() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCollectionFields() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyByteArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyString() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyIntArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testClass() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDecimalFields() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCustomIdMapperWithGlobal() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testBinaryObject() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDeclareReadResolveInParent() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testThreadLocalArrayReleased() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyLongArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortable() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testEnum() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyStringArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testClassFieldsMarshalling() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDefaultMapping() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCyclicReferencesMarshalling() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testOffheapPortable() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCycleLink() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testFieldIdMapping() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCustomIdMapper() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyShortArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyFloatArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyCharArray() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCustomSerializer() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testMarshallingThroughJdk() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testReadResolveOnPortableAware() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testKeepDeserialized() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDetached() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDuplicateTypeId() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPortableCopyMixed() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testReadResolve() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDynamicObject() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testPredefinedTypeIds() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDuplicateName() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testCustomSerializerWithGlobal() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method public rawOffsetRelative(in PortablePositionReadable, start int) : int extracted from public rawOffsetAbsolute(in PortablePositionReadable, start int, fieldOffsetSize int) : int in class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testDateAndTimestampInSingleObject() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract Method private createMarshaller() : PortableMarshaller extracted from public testClassWithoutPublicConstructor() : void in class org.apache.ignite.internal.portable.BinaryMarshallerSelfTest | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public updateSchemaId(schemaId int, fieldId int) : int extracted from public writeFieldId(fieldId int) : void in class org.apache.ignite.internal.portable.BinaryWriterExImpl & moved to class org.apache.ignite.internal.portable.PortableUtils | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter fieldOffsetSize : int to fieldOffsetLen : int in method private fieldPositionAndLength(footerPos int, footerEnd int, rawPos int, fieldIdLen int, fieldOffsetLen int) : IgniteBiTuple<Integer,Integer> in class org.apache.ignite.internal.portable.builder.BinaryObjectBuilderImpl | From | To |