0e8072f8bc831ea08cb4194c60b5b2d0449e671a
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 2 | ||
| Pull Up Method public queryLocal(qry GridCacheQueryBean) : CacheQueryFuture<?> from class org.apache.ignite.internal.processors.cache.query.GridCacheDistributedQueryManager to public queryLocal(qry GridCacheQueryBean) : CacheQueryFuture<?> from class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager | From | To | |
| Pull Up Method public queryLocal(qry GridCacheQueryBean) : CacheQueryFuture<?> from class org.apache.ignite.internal.processors.cache.query.GridCacheLocalQueryManager to public queryLocal(qry GridCacheQueryBean) : CacheQueryFuture<?> from class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type it : WeakQueryFutureIterator to it : WeakReferenceCloseableIterator in method public removeIterator(it WeakReferenceCloseableIterator) : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Inline Method | 2 | ||
| Inline Method private queryResult(futs Map<Long,GridFutureAdapter<QueryResult<K,V>>>, qryInfo GridCacheQueryInfo, taskName String) : QueryResult<K,V> inlined to private queryResult(qryInfo GridCacheQueryInfo, taskName String) : QueryResult<K,V> in class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager | From | To | |
| Inline Method private checkScanQueryEvents() : void inlined to public testScanQueryEvents() : void in class org.apache.ignite.internal.processors.cache.IgniteCacheAbstractQuerySelfTest | From | To | |
| Rename Variable | 5 | ||
| Rename Variable fut : CacheQueryFuture<?> to rsrc : AutoCloseable in method public clearQueries() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Rename Variable expCnt : int to cnt : int in method public testScanQuery() : void in class org.apache.ignite.internal.processors.cache.IgniteCacheAbstractQuerySelfTest | From | To | |
| Rename Variable fut : CacheQueryFuture<?> to rsrc : AutoCloseable in method public checkWeakQueue() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Rename Variable fut : CacheQueryFuture<Map.Entry<K,V>> to iter : GridCloseableIterator<Map.Entry<K,V>> in method public igniteIterator() : Iterator<Cache.Entry<K,V>> in class org.apache.ignite.internal.processors.cache.GridCacheAdapter | From | To | |
| Rename Variable e1 : Cache.Entry<Integer,String> to e : Cache.Entry<Integer,String> in method public testScanQuery() : void in class org.apache.ignite.internal.processors.cache.IgniteCacheAbstractQuerySelfTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type WeakQueryFutureIterator to WeakReferenceCloseableIterator<T> in method public iterator(fut CacheQueryFuture<V>, convert CacheIteratorConverter<T,V>) : WeakReferenceCloseableIterator<T> in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.ignite.internal.processors.cache.IgniteCacheConfigVariationsQueryTest from class org.apache.ignite.internal.processors.cache.distributed.near.GridCachePartitionedPreloadLifecycleSelfTest | From | To | |
| Extract Class org.apache.ignite.internal.processors.cache.IgniteCacheConfigVariationsQueryTest from class org.apache.ignite.internal.processors.cache.distributed.replicated.preloader.GridCacheReplicatedPreloadLifecycleSelfTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute futs : Map<WeakReference<WeakQueryFutureIterator>,CacheQueryFuture<V>> to refs : Map<WeakReference,AutoCloseable> in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Extract Variable | 2 | ||
| Extract Variable key : K in method private advance() : void from class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager.scanIterator | From | To | |
| Extract Variable val : V in method private advance() : void from class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager.scanIterator | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type weakRef : WeakReference<WeakQueryFutureIterator> to weakRef : WeakReference in method public checkWeakQueue() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Change Variable Type itRef : Reference<? extends WeakQueryFutureIterator> to itRef : Reference in method public checkWeakQueue() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Change Variable Type fut : CacheQueryFuture<Map.Entry<K,V>> to iter : GridCloseableIterator<Map.Entry<K,V>> in method public igniteIterator() : Iterator<Cache.Entry<K,V>> in class org.apache.ignite.internal.processors.cache.GridCacheAdapter | From | To | |
| Change Variable Type it : CacheWeakQueryIteratorsHolder.WeakQueryFutureIterator to it : CacheWeakQueryIteratorsHolder.WeakReferenceCloseableIterator in method private iterator0() : GridCloseableIterator<T> in class org.apache.ignite.internal.processors.datastructures.GridCacheSetImpl | From | To | |
| Change Variable Type old : CacheQueryFuture<V> to old : AutoCloseable in method public iterator(fut CacheQueryFuture<V>, convert CacheIteratorConverter<T,V>) : WeakReferenceCloseableIterator<T> in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Change Variable Type fut : CacheQueryFuture<?> to rsrc : AutoCloseable in method public clearQueries() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Change Variable Type fut : CacheQueryFuture<?> to rsrc : AutoCloseable in method public checkWeakQueue() : void in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Extract Method | 1 | ||
| Extract Method private onheapIterator(qry GridCacheQueryAdapter<?>, topVer AffinityTopologyVersion, keyValFilter IgniteBiPredicate<K,V>, backups boolean, plc ExpiryPolicy, locNode boolean) : GridIterator<IgniteBiTuple<K,V>> extracted from private scanIterator(qry GridCacheQueryAdapter<?>) : GridCloseableIterator<IgniteBiTuple<K,V>> in class org.apache.ignite.internal.processors.cache.query.GridCacheQueryManager | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type refQueue : ReferenceQueue<WeakQueryFutureIterator> to refQueue : ReferenceQueue in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To | |
| Change Attribute Type futs : Map<WeakReference<WeakQueryFutureIterator>,CacheQueryFuture<V>> to refs : Map<WeakReference,AutoCloseable> in class org.apache.ignite.internal.processors.cache.CacheWeakQueryIteratorsHolder | From | To |