10aa02aca4ff573413d6155e1a42a1be34087d82
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type partCntrSince : Long to partCntrSince : long in method public searchPartitionCounter(grpId int, part int, partCntrSince long) : WALPointer in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Change Parameter Type chp : Checkpoint to chp : GridCacheDatabaseSharedManager.Checkpoint in method public onCheckpointFinished(chp GridCacheDatabaseSharedManager.Checkpoint, truncateWal boolean) : List<CheckpointEntry> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Move Method | 1 | ||
| Move Method public searchPartitionCounter(grpId int, part int, partCntrSince Long) : WALPointer from class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager to public searchPartitionCounter(grpId int, part int, partCntrSince long) : WALPointer from class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private maxCpHistMemSize : int from class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager to private maxCpHistMemSize : int from class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory from class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private FILTERED_CACHE : String in class org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheRebalancingAbstractTest | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.CheckpointHistory moved and renamed to org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Move Class | 2 | ||
| Move Class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.CheckpointEntryType moved to org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointEntryType | From | To | |
| Move Class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.CheckpointEntry moved to org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointEntry | From | To | |
| Extract Variable | 1 | ||
| Extract Variable hasPartitionsToDestroy : boolean in method private markCheckpointBegin(tracker CheckpointMetricsTracker) : Checkpoint from class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.Checkpointer | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type partId : Integer to partId : int in method public reserveHistoryForExchange() : Map<Integer,Map<Integer,Long>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Change Variable Type grpId : Integer to grpId : int in method public reserveHistoryForExchange() : Map<Integer,Map<Integer,Long>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Change Variable Type cpHist : GridCacheDatabaseSharedManager.CheckpointHistory to cpHist : CheckpointHistory in method private getReservedWalSegmentIndex(dbMgr GridCacheDatabaseSharedManager) : long in class org.apache.ignite.internal.processors.cache.persistence.db.IgnitePdsUnusedWalSegmentsTest | From | To | |
| Change Variable Type cpHist : GridCacheDatabaseSharedManager.CheckpointHistory to cpHist : CheckpointHistory in method private doTestSimple() : void in class org.apache.ignite.internal.processors.cache.persistence.LocalWalModeChangeDuringRebalancingSelfTest | From | To | |
| Change Variable Type hist : GridCacheDatabaseSharedManager.CheckpointHistory to hist : CheckpointHistory in method public testCheckpointHistory() : void in class org.apache.ignite.internal.processors.cache.persistence.db.wal.WalRecoveryTxLogicalRecordsTest | From | To | |
| Extract Method | 1 | ||
| Extract Method public checkpoints(descending boolean) : Collection<Long> extracted from public checkpoints() : Collection<Long> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Rename Method | 3 | ||
| Rename Method private firstEntry() : CheckpointEntry renamed to public lastCheckpoint() : CheckpointEntry in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Rename Method private partsForCheckpointHistorySearch() : Map<Integer,Set<Integer>> renamed to private partitionsApplicableForWalRebalance() : Map<Integer,Set<Integer>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Rename Method private checkpointTimestamp() : long renamed to public timestamp() : long in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointEntry | From | To | |
| Rename Variable | 11 | ||
| Rename Variable groupState : GroupState to grpState : GroupState in method private remap(stateRec Map<Integer,CacheState>) : Map<Integer,GroupState> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointEntry.GroupStateLazyStore | From | To | |
| Rename Variable part4CheckpointHistSearch : Map<Integer,Set<Integer>> to res : Map<Integer,Set<Integer>> in method private partitionsApplicableForWalRebalance() : Map<Integer,Set<Integer>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Rename Variable t : int to it : int in method public testPartitionCounterConsistencyOnUnstableTopology() : void in class org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheRebalancingAbstractTest | From | To | |
| Rename Variable cpEntry : CheckpointEntry to cp : CheckpointEntry in method private markCheckpointBegin(tracker CheckpointMetricsTracker) : Checkpoint in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.Checkpointer | From | To | |
| Rename Variable partCnt : Long to updCntr : Long in method public reserveHistoryForExchange() : Map<Integer,Map<Integer,Long>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Rename Variable lastCheckpointEntry4Grp : Map<Integer,Map<Integer,CheckpointEntry>> to earliestValidCheckpoints : Map<Integer,Map<Integer,CheckpointEntry>> in method public reserveHistoryForExchange() : Map<Integer,Map<Integer,Long>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Rename Variable cpToRemove : List<CheckpointEntry> to removed : List<CheckpointEntry> in method public onWalTruncated(ptr WALPointer) : List<CheckpointEntry> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Rename Variable memCfg : DataStorageConfiguration to dsCfg : DataStorageConfiguration in method protected getConfiguration(gridName String) : IgniteConfiguration in class org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheRebalancingAbstractTest | From | To | |
| Rename Variable k : int to keys : int in method public testPartitionCounterConsistencyOnUnstableTopology() : void in class org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheRebalancingAbstractTest | From | To | |
| Rename Variable maxNodesCount : int to maxNodesCnt : int in method public testTopologyChangesWithConstantLoad() : void in class org.apache.ignite.internal.processors.cache.persistence.IgnitePdsCacheRebalancingAbstractTest | From | To | |
| Rename Variable part : GridDhtLocalPartition to locPart : GridDhtLocalPartition in method private partitionsApplicableForWalRebalance() : Map<Integer,Set<Integer>> in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to boolean in method public beforeExchange(fut GridDhtPartitionsExchangeFuture) : boolean in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager | From | To | |
| Change Return Type void to List<CheckpointEntry> in method public onCheckpointFinished(chp GridCacheDatabaseSharedManager.Checkpoint, truncateWal boolean) : List<CheckpointEntry> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Change Return Type void to List<CheckpointEntry> in method public onWalTruncated(ptr WALPointer) : List<CheckpointEntry> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable dropWal : boolean to truncateWal : boolean in method public onCheckpointFinished(chp GridCacheDatabaseSharedManager.Checkpoint, truncateWal boolean) : List<CheckpointEntry> in class org.apache.ignite.internal.processors.cache.persistence.checkpoint.CheckpointHistory | From | To |