1f1030670a6e7f9fbad1d939301c884f29b7885a
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 51
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public removeFuture(fut GridCacheFuture<?>) : boolean renamed to public removeMvccFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Rename Method protected failAtomicGet(k int) : void renamed to protected failGet(k int) : void in class org.apache.ignite.internal.processors.cache.IgniteCacheP2pUnmarshallingErrorTest | From | To | |
| Rename Method public future(ver GridCacheVersion, futId IgniteUuid) : GridCacheFuture renamed to public mvccFuture(ver GridCacheVersion, futId IgniteUuid) : GridCacheMvccFuture<?> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method private processNearGetResponse(nodeId UUID, res GridNearGetResponse) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache to protected processNearSingleGetResponse(nodeId UUID, res GridNearSingleGetResponse) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheAdapter | From | To | |
| Pull Up Method private affinityNode(key KeyCacheObject, topVer AffinityTopologyVersion) : ClusterNode from class org.apache.ignite.internal.processors.cache.distributed.near.GridNearGetFuture to protected affinityNode(key KeyCacheObject, topVer AffinityTopologyVersion) : ClusterNode from class org.apache.ignite.internal.processors.cache.distributed.dht.CacheDistributedGetFutureAdapter | From | To | |
| Pull Up Method private processNearGetResponse(nodeId UUID, res GridNearGetResponse) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache to protected processNearGetResponse(nodeId UUID, res GridNearGetResponse) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheAdapter | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type res : GridNearGetResponse to res : GridNearSingleGetResponse in method protected processNearSingleGetResponse(nodeId UUID, res GridNearSingleGetResponse) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheAdapter | From | To | |
| Change Parameter Type fut : GridCacheFuture<?> to fut : GridCacheMvccFuture<?> in method public removeMvccFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Parameter Type fut : GridCacheFuture<?> to fut : GridCacheMvccFuture<?> in method public addFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Parameter Type fut : GridCacheFuture<?> to fut : GridLocalLockFuture in method package onFutureDone(fut GridLocalLockFuture) : void in class org.apache.ignite.internal.processors.cache.local.GridLocalCache | From | To | |
| Move Method | 1 | ||
| Move Method private affinityNode(key KeyCacheObject, topVer AffinityTopologyVersion) : ClusterNode from class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture to private affinityNode(key KeyCacheObject, topVer AffinityTopologyVersion) : ClusterNode from class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedSingleGetFuture | From | To | |
| Inline Method | 1 | ||
| Inline Method private checkComplete() : void inlined to public map() : void in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicUpdateFuture | From | To | |
| Rename Variable | 1 | ||
| Rename Variable verFuts : Collection<GridCacheFuture<?>> to futs : Collection<GridCacheMvccFuture<?>> in method public activeFutures() : Collection<GridCacheFuture<?>> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type GridCacheFuture to GridCacheMvccFuture<?> in method public mvccFuture(ver GridCacheVersion, futId IgniteUuid) : GridCacheMvccFuture<?> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type old : Collection<GridCacheFuture<?>> to old : Collection<GridCacheMvccFuture<?>> in method public addFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type futs : Collection<? extends GridCacheFuture> to futs : Collection<GridCacheMvccFuture<?>> in method public mvccFuture(ver GridCacheVersion, futId IgniteUuid) : GridCacheMvccFuture<?> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type fut : GridCacheFuture<?> to fut : GridCacheMvccFuture<?> in method public mvccFuture(ver GridCacheVersion, futId IgniteUuid) : GridCacheMvccFuture<?> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type col : Collection<GridCacheFuture<?>> to col : Collection<GridCacheMvccFuture<?>> in method public addFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type verFuts : Collection<GridCacheFuture<?>> to futs : Collection<GridCacheMvccFuture<?>> in method public activeFutures() : Collection<GridCacheFuture<?>> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type cur : Collection<GridCacheFuture<?>> to cur : Collection<GridCacheMvccFuture<?>> in method public removeMvccFuture(fut GridCacheMvccFuture<?>) : boolean in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Change Variable Type fut : GridNearGetFuture<K,V> to fut : CacheGetFuture in method protected processGetResponse(nodeId UUID, res GridNearGetResponse) : void in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearCacheAdapter | From | To | |
| Change Variable Type fut : GridCacheFuture to fut : CacheGetFuture in method private processFailedMessage(nodeId UUID, msg GridCacheMessage, c IgniteBiInClosure<UUID,GridCacheMessage>) : void in class org.apache.ignite.internal.processors.cache.GridCacheIoManager | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type mappings : ConcurrentMap<UUID,GridDhtAtomicUpdateRequest> to mappings : Map<UUID,GridDhtAtomicUpdateRequest> in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicUpdateFuture | From | To | |
| Change Attribute Type futs : ConcurrentMap<GridCacheVersion,Collection<GridCacheFuture<?>>> to futs : ConcurrentMap<IgniteUuid,GridCacheFuture<?>> in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Extract Method | 5 | ||
| Extract Method private processLoaded(key KeyCacheObject, val Object, needVer boolean, skipVals boolean, c GridInClosure3<KeyCacheObject,Object,GridCacheVersion>) : void extracted from private processLoaded(map Map<Object,Object>, keys Collection<KeyCacheObject>, needVer boolean, c GridInClosure3<KeyCacheObject,Object,GridCacheVersion>) : void in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxLocal | From | To | |
| Extract Method protected prepareMarshalCacheObject(obj CacheObject, ctx GridCacheContext) : void extracted from protected prepareMarshalCacheObjects(col List<? extends CacheObject>, ctx GridCacheContext) : void in class org.apache.ignite.internal.processors.cache.GridCacheMessage | From | To | |
| Extract Method private registerResponse(nodeId UUID) : boolean extracted from public onNodeLeft(nodeId UUID) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicUpdateFuture | From | To | |
| Extract Method protected getAsync(key K, forcePrimary boolean, skipTx boolean, subjId UUID, taskName String, deserializePortable boolean, skipVals boolean, canRemap boolean) : IgniteInternalFuture<V> extracted from public getAsync(key K, deserializePortable boolean) : IgniteInternalFuture<V> in class org.apache.ignite.internal.processors.cache.GridCacheAdapter | From | To | |
| Extract Method protected getAsync(key K, forcePrimary boolean, skipTx boolean, subjId UUID, taskName String, deserializePortable boolean, skipVals boolean, canRemap boolean) : IgniteInternalFuture<V> extracted from public containsKeyAsync(key K) : IgniteInternalFuture<Boolean> in class org.apache.ignite.internal.processors.cache.GridCacheAdapter | From | To |