2f72fe758d4256c4eb4610e5922ad3d174b43dc5
Files Diff
- Added: 16
- Removed: 3
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method package onNextSegmentArchived() : void from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileCompressor to private onSegmentArchived(lastAbsArchivedIdx long) : void from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentCompressStorage | From | To | |
| Move And Rename Method private currentWalIndex(curAbsWalIdx long) : void from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileArchiver to package curAbsWalIdx(curAbsWalIdx long) : void from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentCurrentStateStorage | From | To | |
| Change Parameter Type | 11 | ||
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method private FileHandle(fileIO SegmentIO) in class org.apache.ignite.internal.processors.cache.persistence.wal.FsyncModeFileWriteAheadLogManager.FileHandle | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method package ReadFileHandle(fileIO SegmentIO, ser RecordSerializer, in FileInput) in class org.apache.ignite.internal.processors.cache.persistence.wal.FsyncModeFileWriteAheadLogManager.ReadFileHandle | From | To | |
| Change Parameter Type io : FileIO to io : SegmentIO in method public readSegmentHeader(io SegmentIO, segmentFileInputFactory SegmentFileInputFactory) : SegmentHeader in class org.apache.ignite.internal.processors.cache.persistence.wal.serializer.RecordV1Serializer | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method private FileHandle(fileIO SegmentIO) in class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileHandle | From | To | |
| Change Parameter Type position : int to delegate : FileInput in method public Crc32CheckingFileInput(delegate FileInput, skipCheck boolean) in class org.apache.ignite.internal.processors.cache.persistence.wal.io.FileInput.Crc32CheckingFileInput | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method private FileWriteHandle(fileIO SegmentIO, pos long, resume boolean, serializer RecordSerializer, buf SegmentedRingByteBuffer) in class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileWriteHandle | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method public ReadFileHandle(fileIO SegmentIO, ser RecordSerializer, in FileInput, aware SegmentAware) in class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.ReadFileHandle | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method protected initReadHandle(desc AbstractFileDescriptor, start FileWALPointer, fileIO SegmentIO, segmentHeader SegmentHeader) : AbstractReadFileHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.AbstractWalRecordsIterator | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method protected abstract createReadFileHandle(fileIO SegmentIO, ser RecordSerializer, in FileInput) : AbstractReadFileHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.AbstractWalRecordsIterator | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method private FileWriteHandle(fileIO SegmentIO, pos long, maxSegmentSize long, serializer RecordSerializer) in class org.apache.ignite.internal.processors.cache.persistence.wal.FsyncModeFileWriteAheadLogManager.FileWriteHandle | From | To | |
| Change Parameter Type fileIO : FileIO to fileIO : SegmentIO in method protected createReadFileHandle(fileIO SegmentIO, ser RecordSerializer, in FileInput) : AbstractReadFileHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.FsyncModeFileWriteAheadLogManager.RecordsIterator | From | To | |
| Move Method | 1 | ||
| Move Method private locked(absIdx long) : boolean from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileArchiver to public locked(absIdx long) : boolean from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentLockStorage | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private reservationStorage : SegmentReservationStorage from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager to private reservationStorage : SegmentReservationStorage from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentAware | From | To | |
| Move Attribute private lastTruncatedArchiveIdx : long from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager to private lastTruncatedArchiveIdx : long from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentAware | From | To | |
| Move Attribute private locked : Map<Long,Integer> from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileArchiver to private locked : Map<Long,Integer> from class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentLockStorage | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentAware from class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.ignite.internal.processors.cache.persistence.wal.FileInput moved and renamed to org.apache.ignite.internal.processors.cache.persistence.wal.io.SimpleFileInput | From | To | |
| Move Class | 2 | ||
| Move Class org.apache.ignite.internal.processors.cache.persistence.wal.FileInput.Crc32CheckingFileInput moved to org.apache.ignite.internal.processors.cache.persistence.wal.io.FileInput.Crc32CheckingFileInput | From | To | |
| Move Class org.apache.ignite.internal.processors.cache.persistence.wal.SegmentReservationStorage moved to org.apache.ignite.internal.processors.cache.persistence.wal.aware.SegmentReservationStorage | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type in : FileInput.Crc32CheckingFileInput to in : SimpleFileInput.Crc32CheckingFileInput in method package readWithCrc(in0 FileInput, expPtr WALPointer, reader RecordIO) : WALRecord in class org.apache.ignite.internal.processors.cache.persistence.wal.serializer.RecordV1Serializer | From | To | |
| Change Variable Type fileIO : FileIO to fileIO : SegmentIO in method protected initReadHandle(desc AbstractFileDescriptor, start FileWALPointer) : AbstractReadFileHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.AbstractWalRecordsIterator | From | To | |
| Change Variable Type fileIO : FileIO to fileIO : SegmentIO in method private initNextWriteHandle(cur FileWriteHandle) : FileWriteHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager | From | To | |
| Change Variable Type fileIO : FileIO to fileIO : SegmentIO in method protected initReadHandle(desc AbstractFileDescriptor, start FileWALPointer) : AbstractReadFileHandle in class org.apache.ignite.internal.processors.cache.persistence.wal.reader.StandaloneWalRecordsIterator | From | To | |
| Inline Variable | 2 | ||
| Inline Variable reservationStorage : Object in method public apply() : boolean from class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalHistoryReservationsTest.testReservedOnExchange.released.waitForCondition | From | To | |
| Inline Variable reservationStorage : Object in method public apply() : boolean from class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalHistoryReservationsTest.testNodeLeftDuringExchange.released.waitForCondition | From | To | |
| Extract Method | 6 | ||
| Extract Method private findField(cls Class<?>, obj Object, fieldName String) : Object extracted from public getFieldValue(obj Object, fieldNames String...) : T in class org.apache.ignite.testframework.GridTestUtils | From | To | |
| Extract Method private isReserveListEmpty(ig IgniteEx) : boolean extracted from public testReservedOnExchange() : void in class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalHistoryReservationsTest | From | To | |
| Extract Method private isReserveListEmpty(ig IgniteEx) : boolean extracted from public testNodeLeftDuringExchange() : void in class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalHistoryReservationsTest | From | To | |
| Extract Method private findField(cls Class<?>, obj Object, fieldName String) : Object extracted from public getFieldValue(obj Object, cls Class, fieldName String) : T in class org.apache.ignite.testframework.GridTestUtils | From | To | |
| Rename Method | 1 | ||
| Rename Method public test() : void renamed to public testInvariantSwitchSegment() : void in class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalIteratorSwitchSegmentTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable reservationStorage : Object to segmentAware : Object in method private isReserveListEmpty(ig IgniteEx) : boolean in class org.apache.ignite.internal.processors.cache.persistence.db.wal.IgniteWalHistoryReservationsTest | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type fileInput : FileInput to fileInput : SimpleFileInput in class org.apache.ignite.internal.processors.cache.persistence.db.wal.crc.IgniteDataIntegrityTests | From | To | |
| Change Attribute Type fileIO : FileIO to fileIO : SegmentIO in class org.apache.ignite.internal.processors.cache.persistence.wal.FileWriteAheadLogManager.FileHandle | From | To | |
| Change Attribute Type fileIO : FileIO to fileIO : SegmentIO in class org.apache.ignite.internal.processors.cache.persistence.wal.FsyncModeFileWriteAheadLogManager.FileHandle | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter position : int to delegate : FileInput in method public Crc32CheckingFileInput(delegate FileInput, skipCheck boolean) in class org.apache.ignite.internal.processors.cache.persistence.wal.io.FileInput.Crc32CheckingFileInput | From | To |