3a82d4aa2cae8aa88feeb8bf9505fec41b122417
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 45
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method public nextMvccUpdateCounter() : long from class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl to public next() : long from class org.apache.ignite.internal.processors.cache.PartitionUpdateCounter | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type updCntrs : GridLongList to newDhtNodes : Set<UUID> in method public GridNearTxQueryResultsEnlistResponse(cacheId int, futId IgniteUuid, miniId int, lockVer GridCacheVersion, res long, dhtVer GridCacheVersion, dhtFutId IgniteUuid, newDhtNodes Set<UUID>) in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxQueryResultsEnlistResponse | From | To | |
| Change Parameter Type updCntrs : Map<Integer,PartitionUpdateCounters> to updCntrs : Collection<PartitionUpdateCountersMessage> in method public GridDhtTxFinishRequest(nearNodeId UUID, futId IgniteUuid, miniId int, topVer AffinityTopologyVersion, xidVer GridCacheVersion, commitVer GridCacheVersion, threadId long, isolation TransactionIsolation, commit boolean, invalidate boolean, sys boolean, plc byte, sysInvalidate boolean, syncMode CacheWriteSynchronizationMode, baseVer GridCacheVersion, committedVers Collection<GridCacheVersion>, rolledbackVers Collection<GridCacheVersion>, pendingVers Collection<GridCacheVersion>, txSize int, subjId UUID, taskNameHash int, addDepInfo boolean, updateIdxs Collection<Long>, retVal boolean, waitRemoteTxs boolean, mvccSnapshot MvccSnapshot, updCntrs Collection<PartitionUpdateCountersMessage>) in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishRequest | From | To | |
| Change Parameter Type updCntrs : Map<Integer,PartitionUpdateCounters> to updCntrs : Collection<PartitionUpdateCountersMessage> in method public updateCounters(updCntrs Collection<PartitionUpdateCountersMessage>) : void in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Move Attribute | 4 | ||
| Move Attribute public MVCC_HINTS_MASK : int from class org.apache.ignite.internal.processors.cache.persistence.tree.io.PageIO to public MVCC_HINTS_MASK : int from class org.apache.ignite.internal.processors.cache.mvcc.MvccUtils | From | To | |
| Move Attribute protected cntr : AtomicLong from class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl to private cntr : AtomicLong from class org.apache.ignite.internal.processors.cache.PartitionUpdateCounter | From | To | |
| Move Attribute protected initCntr : long from class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl to private initCntr : long from class org.apache.ignite.internal.processors.cache.PartitionUpdateCounter | From | To | |
| Move Attribute public MVCC_HINTS_BIT_OFF : int from class org.apache.ignite.internal.processors.cache.persistence.tree.io.PageIO to public MVCC_HINTS_BIT_OFF : int from class org.apache.ignite.internal.processors.cache.mvcc.MvccUtils | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.ignite.internal.processors.cache.PartitionUpdateCounter from class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type updCntrs : Map<Integer,PartitionUpdateCounters> to updCntrs : Collection<PartitionUpdateCountersMessage> in method public filterUpdateCountersForBackupNode(node ClusterNode) : List<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
| Extract Variable | 5 | ||
| Extract Variable counters : TxCounters in method public mvccSet(tx IgniteInternalTx, affNodeId UUID, val CacheObject, ttl0 long, topVer AffinityTopologyVersion, mvccVer MvccSnapshot, op GridCacheOperation, needHistory boolean, noCreate boolean) : GridCacheUpdateTxResult from class org.apache.ignite.internal.processors.cache.GridCacheMapEntry | From | To | |
| Extract Variable counters : TxCounters in method public mvccRemove(tx IgniteInternalTx, affNodeId UUID, topVer AffinityTopologyVersion, mvccVer MvccSnapshot, needHistory boolean) : GridCacheUpdateTxResult from class org.apache.ignite.internal.processors.cache.GridCacheMapEntry | From | To | |
| Extract Variable counters : TxCounters in method public apply(lockFut IgniteInternalFuture) : void from class org.apache.ignite.internal.processors.cache.GridCacheMapEntry.MvccUpdateLockListener | From | To | |
| Inline Variable | 1 | ||
| Inline Variable updCntrsForNode : Map<Integer,PartitionUpdateCounters> in method private finish(commit boolean, dhtMap Map<UUID,GridDistributedTxMapping>, nearMap Map<UUID,GridDistributedTxMapping>) : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishFuture | From | To | |
| Extract Method | 3 | ||
| Extract Method private accumulator(accMap Map<Integer,Map<Integer,AtomicLong>>, cacheId int, part int) : AtomicLong extracted from public accumulateSizeDelta(cacheId int, part int, delta long) : void in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Extract Method private addNewRemoteTxNode(node ClusterNode) : void extracted from private addToBatch(key KeyCacheObject, val CacheObject, hist List<MvccLinkAwareSearchRow>, updCntr long, cacheId int) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxAbstractEnlistFuture | From | To | |
| Extract Method private addNewRemoteTxNode(node ClusterNode) : void extracted from private sendBatch(batch Batch) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxAbstractEnlistFuture | From | To | |
| Rename Method | 3 | ||
| Rename Method public nextMvccUpdateCounter() : long renamed to public getAndIncrementUpdateCounter(delta long) : long in class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManager.CacheDataStore | From | To | |
| Rename Method public nextMvccUpdateCounter() : long renamed to public getAndIncrementUpdateCounter(delta long) : long in class org.apache.ignite.internal.processors.cache.persistence.GridCacheOffheapManager.GridCacheDataStore | From | To | |
| Rename Method protected applyTxCounters() : void renamed to protected applyTxSizes() : void in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxAdapter | From | To | |
| Rename Variable | 1 | ||
| Rename Variable accDelta : AtomicLong to acc : AtomicLong in method private accumulator(accMap Map<Integer,Map<Integer,AtomicLong>>, cacheId int, part int) : AtomicLong in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Inline Method | 1 | ||
| Inline Method protected applyTxCounters() : void inlined to private commitIfLocked() : void in class org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxRemoteAdapter | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Map<Integer,? extends Map<Integer,AtomicLong>> to Map<Integer,Map<Integer,AtomicLong>> in method public sizeDeltas() : Map<Integer,Map<Integer,AtomicLong>> in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Change Return Type Map<Integer,PartitionUpdateCounters> to Collection<PartitionUpdateCountersMessage> in method public updateCounters() : Collection<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishRequest | From | To | |
| Change Return Type Map<Integer,PartitionUpdateCounters> to Collection<PartitionUpdateCountersMessage> in method public updateCounters() : Collection<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Change Return Type Map<Integer,PartitionUpdateCounters> to List<PartitionUpdateCountersMessage> in method public filterUpdateCountersForBackupNode(node ClusterNode) : List<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxLocalAdapter | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute cntr : AtomicLong to pCntr : PartitionUpdateCounter in class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl | From | To | |
| Rename Attribute nearUpdCntrs : GridLongList to newDhtNodes : Set<UUID> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxAbstractEnlistFuture | From | To | |
| Change Attribute Type | 5 | ||
| Change Attribute Type nearUpdCntrs : GridLongList to newDhtNodes : Set<UUID> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxAbstractEnlistFuture | From | To | |
| Change Attribute Type cntr : AtomicLong to pCntr : PartitionUpdateCounter in class org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl | From | To | |
| Change Attribute Type updCntrs : Map<Integer,PartitionUpdateCounters> to updCntrs : Collection<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Change Attribute Type updCntrs : Map<Integer,PartitionUpdateCounters> to updCntrs : Collection<PartitionUpdateCountersMessage> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxFinishRequest | From | To | |
| Change Attribute Type sizeDeltas : ConcurrentMap<Integer,ConcurrentMap<Integer,AtomicLong>> to sizeDeltas : Map<Integer,Map<Integer,AtomicLong>> in class org.apache.ignite.internal.processors.cache.transactions.TxCounters | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter mvccInfo : MvccSnapshot to mvccSnapshot : MvccSnapshot in method public GridDhtTxPrepareRequest(futId IgniteUuid, miniId int, topVer AffinityTopologyVersion, tx GridDhtTxLocalAdapter, timeout long, dhtWrites Collection<IgniteTxEntry>, nearWrites Collection<IgniteTxEntry>, txNodes Map<UUID,Collection<UUID>>, nearXidVer GridCacheVersion, last boolean, onePhaseCommit boolean, subjId UUID, taskNameHash int, addDepInfo boolean, storeWriteThrough boolean, retVal boolean, mvccSnapshot MvccSnapshot, counters Collection<PartitionUpdateCountersMessage>) in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtTxPrepareRequest | From | To | |
| Rename Parameter updCntrs : GridLongList to newDhtNodes : Set<UUID> in method public GridNearTxQueryResultsEnlistResponse(cacheId int, futId IgniteUuid, miniId int, lockVer GridCacheVersion, res long, dhtVer GridCacheVersion, dhtFutId IgniteUuid, newDhtNodes Set<UUID>) in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearTxQueryResultsEnlistResponse | From | To | |
| Rename Parameter future : GridDhtTxQueryResultsEnlistFuture to fut : GridDhtTxQueryResultsEnlistFuture in method private createResponse(fut GridDhtTxQueryResultsEnlistFuture) : GridNearTxQueryResultsEnlistResponse in class org.apache.ignite.internal.processors.cache.distributed.dht.NearTxQueryEnlistResultHandler | From | To |