ignite 518238473c0a12380cb9ed96c67597d1fe42652c

518238473c0a12380cb9ed96c67597d1fe42652c

Files Diff

Added: 6
Removed: 0
Renamed: 0
Modified: 56

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public dumpStats() : void renamed to public dumpDiagnosticInfo() : void in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi	From	To
Change Parameter Type	1
Change Parameter Type map : Map<Integer,GridDhtPartitionState> to map : GridPartitionStateMap in method private GridDhtPartitionMap(nodeId UUID, updateSeq long, top AffinityTopologyVersion, map GridPartitionStateMap, moving int) in class org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap	From	To
Move Method	1
Move Method public toString() : String from class org.apache.ignite.internal.pagemem.wal.record.CacheState.PartitionState to public toString() : String from class org.apache.ignite.internal.processors.cache.database.GridCacheDatabaseSharedManager.CheckpointStatus	From	To
Rename Variable	6
Rename Variable nodeIds : Set<UUID> to diffIds : Set<UUID> in method private removeNode(nodeId UUID) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Rename Variable ids : Set<UUID> to diffIds : Set<UUID> in method private updateLocal(p int, state GridDhtPartitionState, updateSeq long) : long in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Rename Variable nodeId : UUID to clientNodeId : UUID in method private dumpInfo(sb StringBuilder, dstNodeId UUID) : void in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi	From	To
Rename Variable ids : Set<UUID> to diffIds : Set<UUID> in method public update(exchFut GridDhtPartitionsExchangeFuture, partMap GridDhtPartitionFullMap, cntrMap Map<Integer,T2<Long,Long>>, partsToReload Set<Integer>) : GridDhtPartitionMap in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Rename Variable node : UUID to e : Map.Entry<Integer,GridDhtPartitionState> in method public lostPartitions() : Collection<Integer> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Rename Variable nodeIds : Collection<UUID> to diffIds : Collection<UUID> in method private nodes0(p int, affAssignment AffinityAssignment, affNodes List<ClusterNode>) : List<ClusterNode> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Change Return Type	6
Change Return Type int to void in method private onCheckpointFinished(chp Checkpoint) : void in class org.apache.ignite.internal.processors.cache.database.GridCacheDatabaseSharedManager.CheckpointHistory	From	To
Change Return Type void to boolean in method public setSize(pageAddr long, size long) : boolean in class org.apache.ignite.internal.processors.cache.database.tree.io.PagePartitionMetaIO	From	To
Change Return Type void to boolean in method public setPartitionState(pageAddr long, state byte) : boolean in class org.apache.ignite.internal.processors.cache.database.tree.io.PagePartitionMetaIO	From	To
Change Return Type void to boolean in method public setCandidatePageCount(pageAddr long, pageCnt int) : boolean in class org.apache.ignite.internal.processors.cache.database.tree.io.PageMetaIO	From	To
Change Return Type void to boolean in method public setUpdateCounter(pageAddr long, cntr long) : boolean in class org.apache.ignite.internal.processors.cache.database.tree.io.PagePartitionMetaIO	From	To
Change Return Type void to boolean in method public setGlobalRemoveId(pageAddr long, rmvId long) : boolean in class org.apache.ignite.internal.processors.cache.database.tree.io.PagePartitionMetaIO	From	To
Extract Variable	2
Extract Variable changed : boolean in method private saveStoreMetadata(store CacheDataStore, ctx Context, saveMeta boolean, beforeDestroy boolean) : boolean from class org.apache.ignite.internal.processors.cache.database.GridCacheOffheapManager	From	To
Extract Variable socketAddrs : Collection<InetSocketAddress> in method protected createTcpClient(node ClusterNode, connIdx int) : GridCommunicationClient from class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi	From	To
Change Variable Type	5
Change Variable Type res : Collection<Integer> to res : Set<Integer> in method public lostPartitions() : Collection<Integer> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Change Variable Type fut : GridCacheFuture<?> to fut : IgniteInternalFuture<?> in method private dumpPendingObjects(exchTopVer AffinityTopologyVersion) : void in class org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager	From	To
Change Variable Type fut : IgniteInternalFuture<?> to fut : GridCacheFuture<?> in method private dumpPendingObjects(exchTopVer AffinityTopologyVersion) : void in class org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager	From	To
Change Variable Type node : UUID to e : Map.Entry<Integer,GridDhtPartitionState> in method public lostPartitions() : Collection<Integer> in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl	From	To
Change Variable Type srvNodes : List<ClusterNode> to srvNodes : int in method public toString() : String in class org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsExchangeFuture	From	To
Extract Method	11
Extract Method private incrementBucketSize(bucket int) : void extracted from private handlePageFull(pageId long, page long, pageAddr long, io PagesListNodeIO, dataId long, data long, dataAddr long, bucket int) : void in class org.apache.ignite.internal.processors.cache.database.freelist.PagesList	From	To
Extract Method private decrementBucketSize(bucket int) : void extracted from protected takeEmptyPage(bucket int, initIoVers IOVersions) : long in class org.apache.ignite.internal.processors.cache.database.freelist.PagesList	From	To
Extract Method private dumpInfo(sb StringBuilder, dstNodeId UUID) : void extracted from public dumpStats() : void in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi	From	To
Extract Method public dynamicDestroyCaches(cacheNames Collection<String>, checkThreadTx boolean, restart boolean, destroy boolean) : IgniteInternalFuture<?> extracted from public dynamicDestroyCaches(cacheNames Collection<String>, checkThreadTx boolean, restart boolean) : IgniteInternalFuture<?> in class org.apache.ignite.internal.processors.cache.GridCacheProcessor	From	To
Extract Method private incrementBucketSize(bucket int) : void extracted from private putDataPage(pageId long, page long, pageAddr long, io PagesListNodeIO, dataId long, dataPage long, dataAddr long, bucket int) : boolean in class org.apache.ignite.internal.processors.cache.database.freelist.PagesList	From	To
Extract Method private decrementBucketSize(bucket int) : void extracted from protected removeDataPage(dataId long, dataPage long, dataAddr long, dataIO DataPageIO, bucket int) : boolean in class org.apache.ignite.internal.processors.cache.database.freelist.PagesList	From	To
Extract Method public restoreStructuresState(ctx GridKernalContext) : void extracted from public onActivate(ctx GridKernalContext) : void in class org.apache.ignite.internal.processors.datastructures.DataStructuresProcessor	From	To
Extract Method private incrementBucketSize(bucket int) : void extracted from private putReuseBag(pageId long, page long, pageAddr long, io PagesListNodeIO, bag ReuseBag, bucket int) : boolean in class org.apache.ignite.internal.processors.cache.database.freelist.PagesList	From	To
Change Attribute Type	2
Change Attribute Type map : Map<Integer,GridDhtPartitionState> to map : GridPartitionStateMap in class org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap	From	To
Change Attribute Type parts : Map<Integer,PartitionState> to parts : short[] in class org.apache.ignite.internal.pagemem.wal.record.CacheState	From	To

518238473c0a12380cb9ed96c67597d1fe42652c

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: