57ac2b3bf437c037904624d411fd89b28b22c944
Files Diff
- Added: 19
- Removed: 0
- Renamed: 0
- Modified: 109
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 1 | ||
| Move And Inline Method public onKernalStop() : void moved from class org.apache.ignite.internal.processors.affinity.GridAffinityAssignmentCache to class org.apache.ignite.internal.processors.cache.GridCacheAffinityManager & inlined to protected onKernalStop0(cancel boolean) : void | From | To | |
| Rename Variable | 3 | ||
| Rename Variable sock : Socket to joinRes : T2<Socket,Boolean> in method private tryJoin() : void in class org.apache.ignite.spi.discovery.tcp.ClientImpl.MessageWorker | From | To | |
| Rename Variable serverNodes : Collection<ClusterNode> to srvNodes : Collection<ClusterNode> in method private ackTopology(topVer long, throttle boolean) : void in class org.apache.ignite.internal.managers.discovery.GridDiscoveryManager | From | To | |
| Rename Variable txSerializableEnabled : boolean to txSerEnabled : boolean in method public prepareTx(tx IgniteInternalTx) : void in class org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager | From | To | |
| Change Return Type | 3 | ||
| Change Return Type T2<Socket,Integer> to T3<Socket,Integer,Boolean> in method private sendJoinRequest(recon boolean, addr InetSocketAddress) : T3<Socket,Integer,Boolean> in class org.apache.ignite.spi.discovery.tcp.ClientImpl | From | To | |
| Change Return Type Socket to T2<Socket,Boolean> in method private joinTopology(recon boolean, timeout long) : T2<Socket,Boolean> in class org.apache.ignite.spi.discovery.tcp.ClientImpl | From | To | |
| Change Return Type GridCacheAdapter<K,V> to IgniteInternalCache<K,V> in method public utilityCache() : IgniteInternalCache<K,V> in class org.apache.ignite.internal.processors.cache.GridCacheProcessor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute protected nodeId : UUID from class org.apache.ignite.spi.IgniteSpiAdapter to private nodeId : UUID from class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute expectedRowsCnt : AtomicInteger to expRowsCnt : AtomicInteger in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Extract Variable | 6 | ||
| Extract Variable nodes : Collection<ClusterNode> in method private processNodeAddFinishedMessage(msg TcpDiscoveryNodeAddFinishedMessage) : void from class org.apache.ignite.spi.discovery.tcp.ClientImpl.MessageWorker | From | To | |
| Extract Variable fut0 : GridFutureAdapter<Object> in method private submit(entries Collection<DataStreamerEntry>, topVer AffinityTopologyVersion, curFut GridFutureAdapter<Object>) : void from class org.apache.ignite.internal.processors.datastreamer.DataStreamerImpl.Buffer | From | To | |
| Extract Variable descs : Map<String,DynamicCacheDescriptor> in method public collectDiscoveryData(nodeId UUID) : Serializable from class org.apache.ignite.internal.processors.cache.GridCacheProcessor | From | To | |
| Extract Variable clientNodesMap : Map<String,Map<UUID,Boolean>> in method public collectDiscoveryData(nodeId UUID) : Serializable from class org.apache.ignite.internal.processors.cache.GridCacheProcessor | From | To | |
| Extract Variable fakeErr : IgniteException in method private sendRequest(res ComputeJobResult) : void from class org.apache.ignite.internal.processors.task.GridTaskWorker | From | To | |
| Extract Variable err : CacheException in method public query(cctx GridCacheContext<?,?>, qry GridCacheTwoStepQuery, keepPortable boolean) : Iterator<List<?>> from class org.apache.ignite.internal.processors.query.h2.twostep.GridReduceQueryExecutor | From | To | |
| Change Variable Type | 8 | ||
| Change Variable Type utilityCache : GridCacheAdapter<Object,Object> to utilityCache : IgniteInternalCache<Object,Object> in method public testSystemTxInsideUserTx() : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSystemTransactionsSelfTest | From | To | |
| Change Variable Type f : AffinityReadyFuture to f : GridDhtPartitionsExchangeFuture in method protected onKernalStop0(cancel boolean) : void in class org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager | From | To | |
| Change Variable Type f : GridDhtPartitionsExchangeFuture to f : AffinityReadyFuture in method protected onKernalStop0(cancel boolean) : void in class org.apache.ignite.internal.processors.cache.GridCachePartitionExchangeManager | From | To | |
| Change Variable Type cacheCtx : GridCacheContext<K,V> to cacheCtx : GridCacheContext<?,?> in method public preloadersStartFuture() : IgniteInternalFuture<Object> in class org.apache.ignite.internal.processors.cache.GridCacheSharedContext | From | To | |
| Change Variable Type cacheCtx : GridCacheContext<K,V> to cacheCtx : GridCacheContext<?,?> in method public dataCenterId() : byte in class org.apache.ignite.internal.processors.cache.GridCacheSharedContext | From | To | |
| Change Variable Type sockAndRes : T2<Socket,Integer> to sockAndRes : T3<Socket,Integer,Boolean> in method private joinTopology(recon boolean, timeout long) : T2<Socket,Boolean> in class org.apache.ignite.spi.discovery.tcp.ClientImpl | From | To | |
| Change Variable Type sock : Socket to joinRes : T2<Socket,Boolean> in method private tryJoin() : void in class org.apache.ignite.spi.discovery.tcp.ClientImpl.MessageWorker | From | To | |
| Change Variable Type ignore : IgniteException to ignore : CacheException in method public checkStopStartCacheWithDataLoader(allowOverwrite boolean) : void in class org.apache.ignite.internal.processors.cache.IgniteCacheDynamicStopSelfTest | From | To | |
| Inline Variable | 1 | ||
| Inline Variable e : IgniteCheckedException in method public cancelClientFutures() : void from class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Extract Method | 16 | ||
| Extract Method private removedError() : IllegalStateException extracted from private checkRemoved() : void in class org.apache.ignite.internal.processors.datastructures.GridCacheAtomicSequenceImpl | From | To | |
| Extract Method private cancelClientFutures(err IgniteCheckedException) : void extracted from public cancelClientFutures() : void in class org.apache.ignite.internal.processors.cache.GridCacheMvccManager | From | To | |
| Extract Method private tryJoin() : void extracted from protected body() : void in class org.apache.ignite.spi.discovery.tcp.ClientImpl.MessageWorker | From | To | |
| Extract Method private startStores() : void extracted from public start() : void in class org.apache.ignite.internal.managers.deployment.GridDeploymentManager | From | To | |
| Extract Method private storesOnKernalStop() : void extracted from public onKernalStop0(cancel boolean) : void in class org.apache.ignite.internal.managers.deployment.GridDeploymentManager | From | To | |
| Extract Method private storesOnKernalStart() : void extracted from public onKernalStart0() : void in class org.apache.ignite.internal.managers.deployment.GridDeploymentManager | From | To | |
| Extract Method private storesStop() : void extracted from public stop(cancel boolean) : void in class org.apache.ignite.internal.managers.deployment.GridDeploymentManager | From | To | |
| Extract Method private removedError() : IllegalStateException extracted from private checkRemoved() : void in class org.apache.ignite.internal.processors.datastructures.GridCacheAtomicLongImpl | From | To | |
| Extract Method private removedError() : IllegalStateException extracted from private checkRemoved() : void in class org.apache.ignite.internal.processors.datastructures.GridCacheAtomicStampedImpl | From | To | |
| Extract Method private internalCacheEx(name String) : IgniteInternalCache<K,V> extracted from public utilityCache() : GridCacheAdapter<K,V> in class org.apache.ignite.internal.processors.cache.GridCacheProcessor | From | To | |
| Extract Method public closeEx(cancel boolean, err IgniteCheckedException) : void extracted from public closeEx(cancel boolean) : void in class org.apache.ignite.internal.processors.datastreamer.DataStreamerImpl | From | To | |
| Extract Method private removedError() : IllegalStateException extracted from private enterBusy() : void in class org.apache.ignite.internal.processors.datastructures.GridCacheSetProxy | From | To | |
| Extract Method private removedError() : IllegalStateException extracted from private checkRemoved() : void in class org.apache.ignite.internal.processors.datastructures.GridCacheAtomicReferenceImpl | From | To | |
| Extract Method private checkState(lock boolean, stopErr boolean) : boolean extracted from public enter(opCtx CacheOperationContext) : CacheOperationContext in class org.apache.ignite.internal.processors.cache.GridCacheGateway | From | To | |
| Extract Method private checkState(lock boolean, stopErr boolean) : boolean extracted from public enter() : void in class org.apache.ignite.internal.processors.cache.GridCacheGateway | From | To | |
| Extract Method private checkState(lock boolean, stopErr boolean) : boolean extracted from public enterIfNotStopped() : boolean in class org.apache.ignite.internal.processors.cache.GridCacheGateway | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type state : GridKernalState to state : AtomicReference<GridKernalState> in class org.apache.ignite.internal.GridKernalGatewayImpl | From | To | |
| Change Attribute Type top : GridDhtPartitionTopology to top : GridDhtPartitionTopologyImpl in class org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtCacheAdapter | From | To | |
| Rename Parameter | 11 | ||
| Rename Parameter session : Session to ses : Session in method public remove(ses Session, row Row) : void in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public find(ses Session, first SearchRow, last SearchRow) : Cursor in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public truncate(ses Session) : void in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public close(ses Session) : void in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public getRowCount(ses Session) : long in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public add(ses Session, row Row) : void in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public remove(ses Session) : void in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter session : Session to ses : Session in method public findFirstOrLast(ses Session, first boolean) : Cursor in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter serverNodesNum : int to srvNodesNum : int in method private topologySnapshotMessage(srvNodesNum int, clientNodesNum int, totalCpus int, heap double) : String in class org.apache.ignite.internal.managers.discovery.GridDiscoveryManager | From | To | |
| Rename Parameter session : Session to ses : Session in method public getCost(ses Session, masks int[], filter TableFilter, sortOrder SortOrder) : double in class org.apache.ignite.internal.processors.query.h2.twostep.GridMergeIndex | From | To | |
| Rename Parameter nodeId : UUID to joiningNodeId : UUID in method public onDiscoveryDataReceived(joiningNodeId UUID, rmtNodeId UUID, obj Serializable) : void in class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor | From | To |