64d3f0071be11be318e5ff278c10f2264a9a9a07
Files Diff
- Added: 29
- Removed: 3
- Renamed: 0
- Modified: 50
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type r : RunnableX to r : Runnable in method private assertIgniteSqlException(r Runnable, msg String, expCode int) : void in class org.apache.ignite.internal.processors.cache.index.DynamicIndexAbstractBasicSelfTest | From | To | |
| Change Parameter Type r : DynamicIndexAbstractBasicSelfTest.RunnableX to r : Runnable in method package assertSqlException(r Runnable, expCode int) : void in class org.apache.ignite.internal.processors.cache.index.AbstractSchemaSelfTest | From | To | |
| Change Parameter Type r : RunnableX to r : Runnable in method protected assertIgniteSqlException(r Runnable, expCode int) : void in class org.apache.ignite.internal.processors.cache.index.DynamicIndexAbstractBasicSelfTest | From | To | |
| Change Parameter Type clo : RunnableX to clo : Runnable in method private reconnectClientNode(srvNode Ignite, cliNode Ignite, restart boolean, clo Runnable) : void in class org.apache.ignite.internal.processors.cache.index.DynamicIndexAbstractConcurrentSelfTest | From | To | |
| Rename Variable | 1 | ||
| Rename Variable errorMessage : StringBuilder to errorMsg : StringBuilder in method public validateNode(node ClusterNode, discoData JoiningNodeDiscoveryData) : IgniteNodeValidationResult in class org.apache.ignite.internal.processors.cache.GridCacheProcessor | From | To | |
| Change Return Type | 3 | ||
| Change Return Type GridSecurityProcessor to IgniteSecurity in method public security() : IgniteSecurity in class org.apache.ignite.internal.GridKernalContextImpl | From | To | |
| Change Return Type GridSecurityProcessor to IgniteSecurity in method public security() : IgniteSecurity in class org.apache.ignite.internal.processors.cache.persistence.wal.reader.StandaloneGridKernalContext | From | To | |
| Change Return Type GridSecurityProcessor to IgniteSecurity in method public security() : IgniteSecurity in class org.apache.ignite.internal.GridKernalContext | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.ignite.internal.processors.cache.distributed.CacheBlockOnReadAbstractTest.RunnableX moved to org.apache.ignite.testframework.GridTestUtils.RunnableX | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute securityProc : GridSecurityProcessor to security : IgniteSecurity in class org.apache.ignite.internal.GridKernalContextImpl | From | To | |
| Extract Method | 5 | ||
| Extract Method private checkCacheException(msg String, expCode int, e CacheException) : void extracted from private assertIgniteSqlException(r RunnableX, msg String, expCode int) : void in class org.apache.ignite.internal.processors.cache.index.DynamicIndexAbstractBasicSelfTest | From | To | |
| Extract Method private createGridIoMessage(topic Object, topicOrd int, msg Message, plc byte, ordered boolean, timeout long, skipOnTimeout boolean) : GridIoMessage extracted from private send(node ClusterNode, topic Object, topicOrd int, msg Message, plc byte, ordered boolean, timeout long, skipOnTimeout boolean, ackC IgniteInClosure<IgniteException>, async boolean) : void in class org.apache.ignite.internal.managers.communication.GridIoManager | From | To | |
| Extract Method public addUserMessageListener(topic Object, p IgniteBiPredicate<UUID,?>, nodeId UUID) : void extracted from public addUserMessageListener(topic Object, p IgniteBiPredicate<UUID,?>) : void in class org.apache.ignite.internal.managers.communication.GridIoManager | From | To | |
| Extract Method protected findKeys(node ClusterNode, cache IgniteCache<?,?>, cnt int, startFrom int, type int) : List<Integer> extracted from protected findKeys(cache IgniteCache<?,?>, cnt int, startFrom int, type int) : List<Integer> in class org.apache.ignite.testframework.junits.common.GridCommonAbstractTest | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type securityProc : GridSecurityProcessor to security : IgniteSecurity in class org.apache.ignite.internal.GridKernalContextImpl | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public nodeSecurityContext(marsh Marshaller, ldr ClassLoader, node ClusterNode) : SecurityContext extracted from private processNodeAddedMessage(msg TcpDiscoveryNodeAddedMessage) : void in class org.apache.ignite.spi.discovery.tcp.ServerImpl.RingMessageWorker & moved to class org.apache.ignite.internal.processors.security.SecurityUtils | From | To | |
| Extract And Move Method public nodeSecurityContext(marsh Marshaller, ldr ClassLoader, node ClusterNode) : SecurityContext extracted from public validateNode(node ClusterNode, discoData JoiningNodeDiscoveryData) : IgniteNodeValidationResult in class org.apache.ignite.internal.processors.cache.GridCacheProcessor & moved to class org.apache.ignite.internal.processors.security.SecurityUtils | From | To |