83b2bf5e1f287dc83343945b0e47b83ee7724a8e
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 4 | ||
Change Parameter Type spi : TestCommunicationSpi to spi : TestRecordingCommunicationSpi in method private checkNoMessages(spi TestRecordingCommunicationSpi, primarySpi TestRecordingCommunicationSpi) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Change Parameter Type primarySpi : TestCommunicationSpi to primarySpi : TestRecordingCommunicationSpi in method private checkMessages(spi TestRecordingCommunicationSpi, primarySpi TestRecordingCommunicationSpi) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Change Parameter Type primarySpi : TestCommunicationSpi to primarySpi : TestRecordingCommunicationSpi in method private checkNoMessages(spi TestRecordingCommunicationSpi, primarySpi TestRecordingCommunicationSpi) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Change Parameter Type spi : TestCommunicationSpi to spi : TestRecordingCommunicationSpi in method private checkMessages(spi TestRecordingCommunicationSpi, primarySpi TestRecordingCommunicationSpi) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Rename Variable | 2 | ||
Rename Variable allowLocRead : boolean to part : int in method private map(key KeyCacheObject, mappings Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, locVals Map<K,V>, topVer AffinityTopologyVersion, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture | From | To | |
Rename Variable colocated : GridDhtCacheAdapter<K,V> to cache : GridDhtCacheAdapter<K,V> in method private localGet(key KeyCacheObject, part int, locVals Map<K,V>) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture | From | To | |
Move And Rename Class | 1 | ||
Move And Rename Class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest.TestCommunicationSpi moved and renamed to org.apache.ignite.internal.TestRecordingCommunicationSpi | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable isNear : boolean to nearRead : boolean in method private localDhtGet(key KeyCacheObject, part int, topVer AffinityTopologyVersion, nearRead boolean) : boolean in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearGetFuture | From | To | |
Change Variable Type | 8 | ||
Change Variable Type spi2 : TestCommunicationSpi to spi2 : TestRecordingCommunicationSpi in method public testAutomaticPreload() : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtPreloadMessageCountTest | From | To | |
Change Variable Type comm : TestCommunicationSpi to comm : TestRecordingCommunicationSpi in method public testDhtVersion() : void in class org.apache.ignite.internal.processors.cache.IgniteCacheNearLockValueSelfTest | From | To | |
Change Variable Type primarySpi : TestCommunicationSpi to primarySpi : TestRecordingCommunicationSpi in method private checkSingleGetMessage(cache IgniteCache<Integer,Integer>, key Integer, backup boolean) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Change Variable Type spi1 : TestCommunicationSpi to spi1 : TestRecordingCommunicationSpi in method public testAutomaticPreload() : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtPreloadMessageCountTest | From | To | |
Change Variable Type commSpi : TestCommunicationSpi to commSpi : TestRecordingCommunicationSpi in method protected getConfiguration(gridName String) : IgniteConfiguration in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Change Variable Type allowLocRead : boolean to part : int in method private map(key KeyCacheObject, mappings Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, locVals Map<K,V>, topVer AffinityTopologyVersion, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture | From | To | |
Change Variable Type spi0 : TestCommunicationSpi to spi0 : TestRecordingCommunicationSpi in method public testAutomaticPreload() : void in class org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtPreloadMessageCountTest | From | To | |
Change Variable Type spi : TestCommunicationSpi to spi : TestRecordingCommunicationSpi in method private checkSingleGetMessage(cache IgniteCache<Integer,Integer>, key Integer, backup boolean) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheSingleGetMessageTest | From | To | |
Extract Variable | 3 | ||
Extract Variable commSpi : TestRecordingCommunicationSpi in method protected getConfiguration(gridName String) : IgniteConfiguration from class org.apache.ignite.internal.processors.cache.IgniteCacheNearLockValueSelfTest | From | To | |
Extract Variable commSpi : TestRecordingCommunicationSpi in method protected getConfiguration(gridName String) : IgniteConfiguration from class org.apache.ignite.internal.processors.cache.distributed.dht.GridCacheDhtPreloadMessageCountTest | From | To | |
Extract Variable cacheNodes : Collection<ClusterNode> in method private map(keys Collection<KeyCacheObject>, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, topVer AffinityTopologyVersion) : void from class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture | From | To | |
Extract Method | 6 | ||
Extract Method private localDhtGet(key KeyCacheObject, part int, topVer AffinityTopologyVersion, nearRead boolean) : boolean extracted from private map(key KeyCacheObject, mappings Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, topVer AffinityTopologyVersion, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, saved Map<KeyCacheObject,GridNearCacheEntry>) : Map<KeyCacheObject,GridNearCacheEntry> in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearGetFuture | From | To | |
Extract Method private serverNotFoundError(topVer AffinityTopologyVersion) : ClusterTopologyServerNotFoundException extracted from private mapKeyToNode(topVer AffinityTopologyVersion) : ClusterNode in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedSingleGetFuture | From | To | |
Extract Method private addResult(key KeyCacheObject, v CacheObject, ver GridCacheVersion) : void extracted from private map(key KeyCacheObject, mappings Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, topVer AffinityTopologyVersion, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, saved Map<KeyCacheObject,GridNearCacheEntry>) : Map<KeyCacheObject,GridNearCacheEntry> in class org.apache.ignite.internal.processors.cache.distributed.near.GridNearGetFuture | From | To | |
Extract Method private localGet(topVer AffinityTopologyVersion, part int) : boolean extracted from private mapKeyToNode(topVer AffinityTopologyVersion) : ClusterNode in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedSingleGetFuture | From | To | |
Extract Method protected get(key K, taskName String, deserializeBinary boolean) : V extracted from public get(key K, deserializeBinary boolean) : V in class org.apache.ignite.internal.processors.cache.GridCacheAdapter | From | To | |
Extract Method private localGet(key KeyCacheObject, part int, locVals Map<K,V>) : boolean extracted from private map(key KeyCacheObject, mappings Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>, locVals Map<K,V>, topVer AffinityTopologyVersion, mapped Map<ClusterNode,LinkedHashMap<KeyCacheObject,Boolean>>) : boolean in class org.apache.ignite.internal.processors.cache.distributed.dht.GridPartitionedGetFuture | From | To | |
Rename Parameter | 1 | ||
Rename Parameter ackClosure : IgniteInClosure<IgniteException> to ackC : IgniteInClosure<IgniteException> in method public sendMessage(node ClusterNode, msg Message, ackC IgniteInClosure<IgniteException>) : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheClientNodeChangingTopologyTest.TestCommunicationSpi | From | To |