8cbfdc72af540ad869f00c30128e4a10860f9a8e
Files Diff
- Added: 12
- Removed: 0
- Renamed: 0
- Modified: 41
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private connect(addr InetSocketAddress, timeout int) : void renamed to public JdbcThinTcpIo(connProps ConnectionProperties, sockAddr InetSocketAddress, timeout int) in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo | From | To | |
| Move Method | 1 | ||
| Move Method public serverIndex() : int from class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo to public serverIndex() : int from class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Change Return Type | 12 | ||
| Change Return Type R to JdbcResultWithIo in method package sendRequest(req JdbcRequest, stmt JdbcThinStatement, stickyIo JdbcThinTcpIo) : JdbcResultWithIo in class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private getIndexesMeta(req JdbcMetaIndexesRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private dispatchBatchOrdered(req JdbcOrderedBatchExecuteRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type void to HandshakeResult in method private handshake_2_1_0() : HandshakeResult in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private executeBatch(req JdbcBatchExecuteRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private getSchemas(req JdbcMetaSchemasRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method package doHandle(req JdbcRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private getParametersMeta(req JdbcMetaParamsRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type R to JdbcResultWithIo in method package sendRequest(req JdbcRequest) : JdbcResultWithIo in class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private processBulkLoadFileBatch(req JdbcBulkLoadBatchRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type ClientListenerResponse to JdbcResponse in method private getPrimaryKeys(req JdbcMetaPrimaryKeysRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Change Return Type void to HandshakeResult in method private handshake(ver ClientListenerProtocolVersion) : HandshakeResult in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo | From | To | |
| Move Attribute | 8 | ||
| Move Attribute private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinConnectionSelfTest to private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinAffinityAwarenessSelfTest | From | To | |
| Move Attribute private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinConnectionSelfTest to private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinAffinityAwarenessTransactionsSelfTest | From | To | |
| Move Attribute private mux : Object from class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo to private mux : Object from class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Move Attribute private srvIdx : int from class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo to private srvIdx : int from class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Move Attribute private ownThread : Thread from class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo to private ownThread : Thread from class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Move Attribute private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinStatementSelfTest to private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinAffinityAwarenessSelfTest | From | To | |
| Move Attribute private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinStatementSelfTest to private URL : String from class org.apache.ignite.jdbc.thin.JdbcThinAffinityAwarenessTransactionsSelfTest | From | To | |
| Move Attribute private cliIo : JdbcThinTcpIo from class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection to private cliIo : JdbcThinTcpIo from class org.apache.ignite.internal.processors.odbc.jdbc.JdbcResultWithIo | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private LOCALHOST : String in class org.apache.ignite.jdbc.thin.JdbcThinConnectionSelfTest | From | To | |
| Rename Attribute | 5 | ||
| Rename Attribute srvProtocolVer : ClientListenerProtocolVersion to srvProtoVer : ClientListenerProtocolVersion in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo | From | To | |
| Rename Attribute URL : String to urlWithAffinityAwarenessFlag : String in class org.apache.ignite.jdbc.thin.JdbcThinConnectionSelfTest | From | To | |
| Rename Attribute partResolver : PartitionResolver to partRslvr : PartitionResolver in class org.apache.ignite.internal.sql.optimizer.affinity.PartitionParameterNode | From | To | |
| Rename Attribute URL : String to url : String in class org.apache.ignite.jdbc.thin.JdbcThinStatementSelfTest | From | To | |
| Rename Attribute mappedType : PartitionParameterType to clientType : PartitionParameterType in class org.apache.ignite.internal.sql.optimizer.affinity.PartitionParameterNode | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type res : ClientListenerResponse to res : JdbcResponse in method protected body() : void in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandlerWorker | From | To | |
| Extract Method | 15 | ||
| Extract Method public calculatePartition(key Object, mask int, parts int) : int extracted from public partition(key Object) : int in class org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getIndexesMeta(req JdbcMetaIndexesRequest) : ClientListenerResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getTablesMeta(req JdbcMetaTablesRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method public calculateMask(parts int) : int extracted from public setPartitions(parts int) : RendezvousAffinityFunction in class org.apache.ignite.cache.affinity.rendezvous.RendezvousAffinityFunction | From | To | |
| Extract Method private handleConnectExceptions(exceptions List<Exception>) : void extracted from private ensureConnected() : void in class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getSchemas(req JdbcMetaSchemasRequest) : ClientListenerResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getQueryMeta(req JdbcQueryMetadataRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getColumnsMeta(req JdbcMetaColumnsRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private executeBatch(req JdbcBatchExecuteRequest) : ClientListenerResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private fetchQuery(req JdbcQueryFetchRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private connectInCommonMode(srvs HostAndPortRange[]) : void extracted from private ensureConnected() : void in class org.apache.ignite.internal.jdbc.thin.JdbcThinConnection | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private executeQuery(req JdbcQueryExecuteRequest) : JdbcResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getPrimaryKeys(req JdbcMetaPrimaryKeysRequest) : ClientListenerResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract Method private resultToResonse(res JdbcResult) : JdbcResponse extracted from private getParametersMeta(req JdbcMetaParamsRequest) : ClientListenerResponse in class org.apache.ignite.internal.processors.odbc.jdbc.JdbcRequestHandler | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public timeout(ms int) : void extracted from public timeout(ms int) : void in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo & moved to class org.apache.ignite.internal.util.ipc.loopback.IpcClientTcpEndpoint | From | To | |
| Extract And Move Method public timeout() : int extracted from public timeout() : int in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo & moved to class org.apache.ignite.internal.util.ipc.loopback.IpcClientTcpEndpoint | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter addr : InetSocketAddress to sockAddr : InetSocketAddress in method public JdbcThinTcpIo(connProps ConnectionProperties, sockAddr InetSocketAddress, timeout int) in class org.apache.ignite.internal.jdbc.thin.JdbcThinTcpIo | From | To | |
| Rename Parameter partResolver : PartitionResolver to partRslvr : PartitionResolver in method public PartitionParameterNode(tbl PartitionTable, partRslvr PartitionResolver, idx int, type int, clientType PartitionParameterType) in class org.apache.ignite.internal.sql.optimizer.affinity.PartitionParameterNode | From | To | |
| Rename Parameter mappedType : PartitionParameterType to clientType : PartitionParameterType in method public PartitionParameterNode(tbl PartitionTable, partRslvr PartitionResolver, idx int, type int, clientType PartitionParameterType) in class org.apache.ignite.internal.sql.optimizer.affinity.PartitionParameterNode | From | To |