a64b941df0a4d3bfc3a2dab32f85c371c1a509be
Files Diff
- Added: 69
- Removed: 0
- Renamed: 0
- Modified: 122
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type nodesCnt : long to nodesCnt : int in method private awaitDiscovery(nodesCnt int) : void in class org.apache.ignite.internal.managers.discovery.GridDiscoveryManagerAliveCacheSelfTest | From | To | |
| Move Method | 1 | ||
| Move Method public waitCustomEvent() : void from class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi to public waitCustomEvent() : void from class org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private mux : Object from class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi to private mux : Object from class org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Move Attribute private ctx : GridKernalContext from class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.StartFuture to protected ctx : GridKernalContext from class org.apache.ignite.internal.managers.discovery.DiscoveryMessageResultsCollector | From | To | |
| Move Attribute private blockedMsgs : List<DiscoverySpiCustomMessage> from class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi to private blockedMsgs : List<DiscoverySpiCustomMessage> from class org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.ignite.internal.DiscoverySpiTestListener from class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi moved and renamed to org.apache.ignite.internal.managers.discovery.IgniteDiscoverySpi | From | To | |
| Move And Rename Class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest.TestTcpDiscoverySpi moved and renamed to org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi.ConnectionKey moved to org.apache.ignite.spi.communication.tcp.internal.ConnectionKey | From | To | |
| Extract Variable | 4 | ||
| Extract Variable cfg : IgniteConfiguration in method protected startGrid(igniteInstanceName String, springCfgPath String) : Ignite from class org.apache.ignite.testframework.junits.GridAbstractTest | From | To | |
| Extract Variable logStr : String in method public testExceptionOnServerNode() : void from class org.apache.ignite.internal.processors.cache.query.continuous.ContinuousQueryRemoteFilterMissingInClassPathSelfTest | From | To | |
| Extract Variable logStr : String in method public testWarningMessageOnClientNode() : void from class org.apache.ignite.internal.processors.cache.query.continuous.ContinuousQueryRemoteFilterMissingInClassPathSelfTest | From | To | |
| Extract Variable ctx : IgniteSpiContext in method protected createTcpClient(node ClusterNode, connIdx int) : GridCommunicationClient from class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi | From | To | |
| Change Variable Type | 24 | ||
| Change Variable Type clientSpi : TestTcpDiscoverySpi to clientSpi : IgniteDiscoverySpi in method public testReconnect() : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type top : List<TcpDiscoveryNode> to top : List<ClusterNode> in method public testAffinityMultiNode() : void in class org.apache.ignite.cache.affinity.AffinityFunctionExcludeNeighborsAbstractSelfTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method private checkOperationInProgressFails(client IgniteEx, ccfg CacheConfiguration<Object,Object>, msgToBlock Class<?>, c IgniteInClosure<IgniteCache<Object,Object>>) : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method private doTestIgniteOperationOnDisconnect(client Ignite, ops List<T2<Callable,C1<Object,Boolean>>>) : void in class org.apache.ignite.internal.IgniteClientReconnectApiExceptionTest | From | To | |
| Change Variable Type clientSpi : TestTcpDiscoverySpi to clientSpi : IgniteDiscoverySpi in method private doTestIgniteOperationOnDisconnect(client Ignite, ops List<T2<Callable,C1<Object,Boolean>>>) : void in class org.apache.ignite.internal.IgniteClientReconnectApiExceptionTest | From | To | |
| Change Variable Type discoSpi : TestTcpDiscoverySpi to discoSpi : IgniteDiscoverySpi in method public testAsyncOld() : void in class org.apache.ignite.messaging.GridMessagingSelfTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method public testReconnectInitialExchangeInProgress() : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type node : TcpDiscoveryNode to node : IgniteClusterNode in method public onLocalNodeInitialized(locNode ClusterNode) : void in class org.apache.ignite.internal.managers.discovery.GridDiscoveryManager.start.setListener | From | To | |
| Change Variable Type discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentCacheDestroyCreate() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method public testReconnectExchangeInProgress() : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method public testStopWhenDisconnected() : void in class org.apache.ignite.internal.IgniteClientReconnectStopTest | From | To | |
| Change Variable Type clientSpi : TestTcpDiscoverySpi to clientSpi : IgniteDiscoverySpi in method public testStopWhenDisconnected() : void in class org.apache.ignite.internal.IgniteClientReconnectStopTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : DiscoverySpi in method private reconnectTransactionInProgress1(client IgniteEx, txConcurrency TransactionConcurrency, cache IgniteCache<Object,Object>) : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : IgniteDiscoverySpi in method private testMessageListenerReconnect(stopFromClient boolean) : void in class org.apache.ignite.internal.IgniteClientReconnectContinuousProcessorTest | From | To | |
| Change Variable Type clientSpi : TestTcpDiscoverySpi to clientSpi : IgniteDiscoverySpi in method private reconnectTransactionInProgress1(client IgniteEx, txConcurrency TransactionConcurrency, cache IgniteCache<Object,Object>) : void in class org.apache.ignite.internal.IgniteClientReconnectCacheTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : IgniteDiscoverySpi in method private continuousQueryReconnect(client Ignite, clientCache IgniteCache<Object,Object>, lsnr CacheEventListener) : void in class org.apache.ignite.internal.IgniteClientReconnectContinuousProcessorTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : IgniteDiscoverySpi in method protected reconnectFailover(c Callable<Void>) : void in class org.apache.ignite.internal.IgniteClientReconnectFailoverAbstractTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : IgniteDiscoverySpi in method public testEventListenerReconnect() : void in class org.apache.ignite.internal.IgniteClientReconnectContinuousProcessorTest | From | To | |
| Change Variable Type discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentAffinityChanged2() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Change Variable Type discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentAffinityChanged() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Change Variable Type addrs : LinkedHashSet<InetSocketAddress> to addrs : Collection<InetSocketAddress> in method protected createTcpClient(node ClusterNode, connIdx int) : GridCommunicationClient in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi | From | To | |
| Change Variable Type discoSpi : TestTcpDiscoverySpi to discoSpi : IgniteDiscoverySpi in method public testAsync() : void in class org.apache.ignite.messaging.GridMessagingSelfTest | From | To | |
| Change Variable Type discoSpi : TestTcpDiscoverySpi to discoSpi : TcpDiscoverySpi in method protected getConfiguration(igniteInstanceName String) : IgniteConfiguration in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Change Variable Type srvSpi : TestTcpDiscoverySpi to srvSpi : IgniteDiscoverySpi in method protected reconnectClientNodes(log IgniteLogger, clients List<Ignite>, srv Ignite, disconnectedC Runnable) : void in class org.apache.ignite.internal.IgniteClientReconnectAbstractTest | From | To | |
| Extract Method | 4 | ||
| Extract Method public nodeAddresses(node ClusterNode, filterReachableAddresses boolean) : Collection<InetSocketAddress> extracted from private nodeAddresses(node ClusterNode) : LinkedHashSet<InetSocketAddress> in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi | From | To | |
| Extract Method private createStartMessage(routineId UUID, hnd GridContinuousHandler, bufSize int, interval long, autoUnsubscribe boolean, nodeFilter IgnitePredicate<ClusterNode>) : AbstractContinuousMessage extracted from public startRoutine(hnd GridContinuousHandler, locOnly boolean, bufSize int, interval long, autoUnsubscribe boolean, prjPred IgnitePredicate<ClusterNode>) : IgniteInternalFuture<UUID> in class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor | From | To | |
| Extract Method private checkNodes0(expCnt int) : void extracted from private manyClientsSequentially() : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheManyClientsTest | From | To | |
| Extract Method private checkNodes0(expCnt int) : void extracted from private manyClientsPutGet() : void in class org.apache.ignite.internal.processors.cache.distributed.IgniteCacheManyClientsTest | From | To | |
| Rename Method | 4 | ||
| Rename Method public sendCustomEvent(msg DiscoverySpiCustomMessage) : void renamed to public beforeSendCustomEvent(spi DiscoverySpi, log IgniteLogger, msg DiscoverySpiCustomMessage) : boolean in class org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Rename Method public reconnect() : void renamed to public clientReconnect() : void in class org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi | From | To | |
| Rename Method public testMultithreadedWithNodeRestart() : void renamed to public _testMultithreadedWithNodeRestart() : void in class org.apache.ignite.internal.processors.continuous.GridEventConsumeSelfTest | From | To | |
| Rename Method private executeContiniouseQuery(cache IgniteCache) : void renamed to private executeContinuousQuery(cache IgniteCache) : void in class org.apache.ignite.internal.processors.cache.query.continuous.ContinuousQueryRemoteFilterMissingInClassPathSelfTest | From | To | |
| Rename Variable | 4 | ||
| Rename Variable dep : GridDeployment to dep0 : GridDeployment in method private createStartMessage(routineId UUID, hnd GridContinuousHandler, bufSize int, interval long, autoUnsubscribe boolean, nodeFilter IgnitePredicate<ClusterNode>) : AbstractContinuousMessage in class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor | From | To | |
| Rename Variable discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentAffinityChanged2() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Rename Variable discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentCacheDestroyCreate() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Rename Variable discoSpi0 : TestTcpDiscoverySpi to lsnr : DiscoverySpiTestListener in method public testDelayAssignmentAffinityChanged() : void in class org.apache.ignite.internal.processors.cache.distributed.CacheLateAffinityAssignmentTest | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to boolean in method public beforeSendCustomEvent(spi DiscoverySpi, log IgniteLogger, msg DiscoverySpiCustomMessage) : boolean in class org.apache.ignite.internal.DiscoverySpiTestListener | From | To | |
| Change Return Type LinkedHashSet<InetSocketAddress> to Collection<InetSocketAddress> in method private nodeAddresses(node ClusterNode) : Collection<InetSocketAddress> in class org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi | From | To | |
| Extract Interface | 2 | ||
| Extract Interface org.apache.ignite.internal.managers.discovery.IgniteDiscoverySpi from classes [org.apache.ignite.spi.discovery.tcp.TcpDiscoverySpi] | From | To | |
| Extract Interface org.apache.ignite.internal.managers.discovery.IgniteClusterNode from classes [org.apache.ignite.spi.discovery.tcp.internal.TcpDiscoveryNode] | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method private onAllRemoteRegistered(topVer AffinityTopologyVersion, errs Map<UUID,? extends Exception>, cntrsPerNode Map<UUID,Map<Integer,T2<Long,Long>>>, cntrs Map<Integer,T2<Long,Long>>) : void extracted from private processStartAckRequest(topVer AffinityTopologyVersion, msg StartRoutineAckDiscoveryMessage) : void in class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor & moved to class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor.StartFuture | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter prjPred : IgnitePredicate<ClusterNode> to nodeFilter : IgnitePredicate<ClusterNode> in method private createStartMessage(routineId UUID, hnd GridContinuousHandler, bufSize int, interval long, autoUnsubscribe boolean, nodeFilter IgnitePredicate<ClusterNode>) : AbstractContinuousMessage in class org.apache.ignite.internal.processors.continuous.GridContinuousProcessor | From | To |