ignite c4e14ef8a1682404aab6531f3dfec1ce3103082d

c4e14ef8a1682404aab6531f3dfec1ce3103082d

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 81

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	1
Change Parameter Type object : T to object : E in method private Reusable(object E) in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool.Reusable	From	To
Rename Variable	7
Rename Variable o1 : Reusable<Obj> to r1 : ThreadLocalObjectPool<Obj> in method public testObjectShouldBeClosedOnRecycleIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Rename Variable pooled : Reusable<E> to obj : E in method public borrow() : Reusable in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To
Rename Variable connection : H2ConnectionWrapper to connSet : ConcurrentMap<H2ConnectionWrapper,Boolean> in method public detachThreadConnection() : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Rename Variable o2 : Reusable<Obj> to r2 : ThreadLocalObjectPool<Obj> in method public testObjectShouldBeClosedOnRecycleIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Rename Variable o2 : Reusable<Obj> to r2 : ThreadLocalObjectPool<Obj> in method public testObjectIsReusedAfterRecycling() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Rename Variable reusableConnection : ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to reusableConn : ThreadLocalObjectPool<H2ConnectionWrapper> in method public detachThreadConnection() : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Rename Variable o1 : Reusable<Obj> to r1 : ThreadLocalObjectPool<Obj> in method public testObjectIsReusedAfterRecycling() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Return Type	4
Change Return Type T to E in method public object() : E in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool.Reusable	From	To
Change Return Type Reusable<E> to Reusable in method public borrow() : Reusable in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To
Change Return Type ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to ThreadLocalObjectPool<H2ConnectionWrapper> in method public detachThreadConnection() : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Return Type Map<Thread,H2ConnectionWrapper> to Map<Thread,ConcurrentMap<H2ConnectionWrapper,Boolean>> in method public connectionsForThread() : Map<Thread,ConcurrentMap<H2ConnectionWrapper,Boolean>> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Extract Superclass	1
Extract Superclass org.apache.ignite.internal.processors.cache.index.AbstractIndexingCommonTest from classes [org.apache.ignite.internal.processors.cache.IgniteCacheQueriesLoadTest1, org.apache.ignite.internal.processors.cache.IgniteCacheQueryMultiThreadedSelfTest, org.apache.ignite.internal.processors.cache.QueryJoinWithDifferentNodeFiltersTest, org.apache.ignite.internal.processors.cache.distributed.near.IgniteCacheQueryAbstractDistributedJoinSelfTest, org.apache.ignite.internal.processors.cache.index.AbstractSchemaSelfTest, org.apache.ignite.internal.processors.cache.index.BasicIndexTest, org.apache.ignite.internal.processors.cache.index.ComplexPrimaryKeyUnwrapSelfTest, org.apache.ignite.internal.processors.cache.index.ComplexSecondaryKeyUnwrapSelfTest, org.apache.ignite.internal.processors.cache.index.DuplicateKeyValueClassesSelfTest, org.apache.ignite.internal.processors.cache.index.DynamicColumnsAbstractTest, org.apache.ignite.internal.processors.cache.index.H2ConnectionLeaksSelfTest, org.apache.ignite.internal.processors.cache.index.H2RowCachePageEvictionTest, org.apache.ignite.internal.processors.cache.index.H2RowCacheSelfTest, org.apache.ignite.internal.processors.cache.index.IoStatisticsBasicIndexSelfTest, org.apache.ignite.internal.processors.cache.index.LongIndexNameTest, org.apache.ignite.internal.processors.cache.index.MvccEmptyTransactionSelfTest, org.apache.ignite.internal.processors.cache.index.OptimizedMarshallerIndexNameTest, org.apache.ignite.internal.processors.cache.index.QueryEntityValidationSelfTest, org.apache.ignite.internal.processors.query.IgniteSqlDistributedJoinSelfTest, org.apache.ignite.internal.processors.query.IgniteSqlEntryCacheModeAgnosticTest, org.apache.ignite.internal.processors.query.IgniteSqlGroupConcatCollocatedTest, org.apache.ignite.internal.processors.query.IgniteSqlGroupConcatNotCollocatedTest, org.apache.ignite.internal.processors.query.IgniteSqlKeyValueFieldsTest, org.apache.ignite.internal.processors.query.IgniteSqlNotNullConstraintTest, org.apache.ignite.internal.processors.query.IgniteSqlParameterizedQueryTest, org.apache.ignite.internal.processors.query.IgniteSqlQueryParallelismTest, org.apache.ignite.internal.processors.query.IgniteSqlRoutingTest, org.apache.ignite.internal.processors.query.IgniteSqlSchemaIndexingTest, org.apache.ignite.internal.processors.query.IgniteSqlSegmentedIndexSelfTest, org.apache.ignite.internal.processors.query.IgniteSqlSkipReducerOnUpdateDmlFlagSelfTest, org.apache.ignite.internal.processors.query.IgniteSqlSkipReducerOnUpdateDmlSelfTest, org.apache.ignite.internal.processors.query.IgniteSqlSplitterSelfTest, org.apache.ignite.internal.processors.query.LazyQuerySelfTest, org.apache.ignite.internal.processors.query.MultipleStatementsSqlQuerySelfTest, org.apache.ignite.internal.processors.query.RunningQueriesTest, org.apache.ignite.internal.processors.query.SqlIllegalSchemaSelfTest, org.apache.ignite.internal.processors.query.SqlNestedQuerySelfTest, org.apache.ignite.internal.processors.query.SqlPushDownFunctionTest, org.apache.ignite.internal.processors.query.SqlSchemaSelfTest, org.apache.ignite.internal.processors.query.SqlSystemViewsSelfTest, org.apache.ignite.internal.processors.query.h2.CacheQueryEntityWithDateTimeApiFieldsTest, org.apache.ignite.internal.processors.query.h2.GridIndexingSpiAbstractSelfTest, org.apache.ignite.internal.processors.query.h2.H2ResultSetIteratorNullifyOnEndSelfTest, org.apache.ignite.internal.processors.query.h2.H2StatementCacheSelfTest, org.apache.ignite.internal.processors.query.h2.IgniteSqlBigIntegerKeyTest, org.apache.ignite.internal.processors.query.h2.IgniteSqlQueryMinMaxTest, org.apache.ignite.internal.processors.query.h2.PreparedStatementExSelfTest, org.apache.ignite.internal.processors.query.h2.database.InlineIndexHelperTest, org.apache.ignite.internal.processors.query.h2.sql.AbstractH2CompareQueryTest, org.apache.ignite.internal.processors.query.h2.sql.ExplainSelfTest, org.apache.ignite.internal.processors.query.h2.sql.GridQueryParsingTest, org.apache.ignite.internal.processors.query.h2.twostep.AndOperationExtractPartitionSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.CacheQueryMemoryLeakTest, org.apache.ignite.internal.processors.query.h2.twostep.CreateTableWithDateKeySelfTest, org.apache.ignite.internal.processors.query.h2.twostep.DisappearedCacheCauseRetryMessageSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.DisappearedCacheWasNotFoundMessageSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.InOperationExtractPartitionSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.NonCollocatedRetryMessageSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.RetryCauseMessageSelfTest, org.apache.ignite.internal.processors.query.h2.twostep.TableViewSubquerySelfTest, org.apache.ignite.internal.processors.sql.IgniteCachePartitionedAtomicColumnConstraintsTest, org.apache.ignite.internal.processors.sql.IgniteSQLColumnConstraintsTest, org.apache.ignite.internal.processors.sql.SqlConnectorConfigurationValidationSelfTest, org.apache.ignite.sqltests.BaseSqlTest]	From	To
Rename Attribute	1
Rename Attribute objectFactory : Supplier<E> to objFactory : Supplier<E> in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To
Change Variable Type	16
Change Variable Type conns : Map<Thread,H2ConnectionWrapper> to conns : Map<Thread,ConcurrentMap<H2ConnectionWrapper,Boolean>> in method private getStatementCacheSize(qryProcessor GridQueryProcessor) : int in class org.apache.ignite.internal.processors.cache.IgniteCacheQueryH2IndexingLeakTest	From	To
Change Variable Type conn : Connection to conn : H2ConnectionWrapper in method public onSqlException(c Connection) : void in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Variable Type pooled : Reusable<E> to obj : E in method public borrow() : Reusable in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To
Change Variable Type o2 : Reusable<Obj> to o2 : ThreadLocalObjectPool<Obj> in method public testBorrowedObjectIsNotReturnedTwice() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type o1 : Reusable<Obj> to o1 : ThreadLocalObjectPool<Obj> in method public testObjectShouldNotBeReturnedIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type connection : H2ConnectionWrapper to connSet : ConcurrentMap<H2ConnectionWrapper,Boolean> in method public detachThreadConnection() : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Variable Type o2 : Reusable<Obj> to o2 : ThreadLocalObjectPool<Obj> in method public testObjectShouldNotBeReturnedIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type conn0 : ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to conn0 : ThreadLocalObjectPool<H2ConnectionWrapper> in method public beforeDetach() : void in class org.apache.ignite.internal.processors.query.h2.dml.UpdatePlan.AbstractIterator	From	To
Change Variable Type o1 : Reusable<Obj> to o1 : ThreadLocalObjectPool<Obj> in method public testBorrowedObjectIsNotReturnedTwice() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type o1 : Reusable<Obj> to o1 : ThreadLocalObjectPool<Obj> in method public testObjectShouldReturnedToRecyclingThreadBag() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type o1 : Reusable<Obj> to r1 : ThreadLocalObjectPool<Obj> in method public testObjectShouldBeClosedOnRecycleIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type conn0 : ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to conn0 : ThreadLocalObjectPool<H2ConnectionWrapper> in method protected onClose() : void in class org.apache.ignite.internal.processors.query.h2.dml.UpdatePlan.AbstractIterator	From	To
Change Variable Type o2 : Reusable<Obj> to r2 : ThreadLocalObjectPool<Obj> in method public testObjectShouldBeClosedOnRecycleIfPoolIsFull() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type o2 : Reusable<Obj> to r2 : ThreadLocalObjectPool<Obj> in method public testObjectIsReusedAfterRecycling() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Change Variable Type reusableConnection : ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to reusableConn : ThreadLocalObjectPool<H2ConnectionWrapper> in method public detachThreadConnection() : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Variable Type o1 : Reusable<Obj> to r1 : ThreadLocalObjectPool<Obj> in method public testObjectIsReusedAfterRecycling() : void in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPoolSelfTest	From	To
Extract Method	1
Extract Method private closeConnections() : void extracted from public stop() : void in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Attribute Type	5
Change Attribute Type bag : ThreadLocal<Queue<Reusable<E>>> to bag : ThreadLocal<Queue<E>> in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To
Change Attribute Type object : T to object : E in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool.Reusable	From	To
Change Attribute Type threadConn : ThreadLocal<ThreadLocalObjectPool.Reusable<H2ConnectionWrapper>> to threadConn : ThreadLocal<ThreadLocalObjectPool<H2ConnectionWrapper>.Reusable> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Attribute Type threadConns : ConcurrentMap<Thread,H2ConnectionWrapper> to threadConns : ConcurrentMap<Thread,ConcurrentMap<H2ConnectionWrapper,Boolean>> in class org.apache.ignite.internal.processors.query.h2.ConnectionManager	From	To
Change Attribute Type conn : ThreadLocalObjectPool.Reusable<H2ConnectionWrapper> to conn : ThreadLocalObjectPool<H2ConnectionWrapper> in class org.apache.ignite.internal.processors.query.h2.dml.UpdatePlan.AbstractIterator	From	To
Rename Parameter	1
Rename Parameter objectFactory : Supplier<E> to objFactory : Supplier<E> in method public ThreadLocalObjectPool(poolSize int, objFactory Supplier<E>, closer Consumer<E>, recycler Consumer<E>) in class org.apache.ignite.internal.processors.query.h2.ThreadLocalObjectPool	From	To

c4e14ef8a1682404aab6531f3dfec1ce3103082d

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: