d53a91f0ff6efd678308726403a24b07133156a4
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 20
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public onCheckpointBegin(ctx Context) : void renamed to public onMarkCheckpointBegin(ctx Context) : void in class org.apache.ignite.internal.processors.cache.mvcc.txlog.TxLog | From | To | |
| Rename Method public onCheckpointBegin(ctx Context) : void renamed to public onMarkCheckpointBegin(ctx Context) : void in class org.apache.ignite.internal.processors.cache.persistence.GridCacheOffheapManager | From | To | |
| Rename Method public onCheckpointBegin(ctx Context) : void renamed to public onMarkCheckpointBegin(ctx Context) : void in class org.apache.ignite.internal.processors.cache.persistence.metastorage.MetaStorage | From | To | |
| Rename Method public excludeCaches() : Set<String> renamed to public getExcludeCaches() : Set<String> in class org.apache.ignite.internal.visor.verify.VisorIdleVerifyTaskArg | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type exceptions : Map<UUID,Exception> to exceptions : Map<ClusterNode,Exception> in method public IdleVerifyResultV2(cntrConflicts Map<PartitionKeyV2,List<PartitionHashRecordV2>>, hashConflicts Map<PartitionKeyV2,List<PartitionHashRecordV2>>, movingPartitions Map<PartitionKeyV2,List<PartitionHashRecordV2>>, exceptions Map<ClusterNode,Exception>) in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Rename Variable | 2 | ||
| Rename Variable dsc : DataStorageConfiguration to dsCfg : DataStorageConfiguration in method private isCacheMatchFilter(cacheName String) : boolean in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2.VerifyBackupPartitionsJobV2 | From | To | |
| Rename Variable hashConflictsSize : int to size : int in method private print(printer Consumer<String>, printExceptionMessages boolean) : void in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to String in method public print(printer Consumer<String>) : String in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Change Return Type Map<UUID,Exception> to Map<ClusterNode,Exception> in method public exceptions() : Map<ClusterNode,Exception> in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Extract Variable | 1 | ||
| Extract Variable wd : String in method private writeHashes(partitions Map<PartitionKeyV2,List<PartitionHashRecordV2>>, conflictRes IdleVerifyResultV2, skippedRecords int) : String from class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsDumpTask | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type strBuilder : StringBuilder to strBuilder : SB in method private handlingMissedCaches(missingCaches Set<String>) : void in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2.VerifyBackupPartitionsJobV2 | From | To | |
| Change Variable Type exceptions : Map<UUID,Exception> to exceptions : Map<ClusterNode,Exception> in method public reduce(results List<ComputeJobResult>) : IdleVerifyResultV2 in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2 | From | To | |
| Change Variable Type e : Map.Entry<UUID,Exception> to e : Map.Entry<ClusterNode,Exception> in method private print(printer Consumer<String>, printExceptionMessages boolean) : void in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Change Variable Type writer : BufferedWriter to writer : PrintWriter in method private writeHashes(partitions Map<PartitionKeyV2,List<PartitionHashRecordV2>>, conflictRes IdleVerifyResultV2, skippedRecords int) : String in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsDumpTask | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type exceptions : Map<UUID,Exception> to exceptions : Map<ClusterNode,Exception> in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Extract Method | 9 | ||
| Extract Method private writeResult(partitions Map<PartitionKeyV2,List<PartitionHashRecordV2>>, conflictRes IdleVerifyResultV2, skippedRecords int, writer PrintWriter) : void extracted from private writeHashes(partitions Map<PartitionKeyV2,List<PartitionHashRecordV2>>, conflictRes IdleVerifyResultV2, skippedRecords int) : String in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsDumpTask | From | To | |
| Extract Method private calcPartitionHashAsync(grpIds Set<Integer>, cpFlag AtomicBoolean) : List<Future<Map<PartitionKeyV2,PartitionHashRecordV2>>> extracted from public execute() : Map<PartitionKeyV2,PartitionHashRecordV2> in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2.VerifyBackupPartitionsJobV2 | From | To | |
| Extract Method private createOnCheckpointBeginContext(delegate DbCheckpointListener.Context, hasPages boolean) : DbCheckpointListener.Context extracted from private markCheckpointBegin(tracker CheckpointMetricsTracker) : Checkpoint in class org.apache.ignite.internal.processors.cache.persistence.GridCacheDatabaseSharedManager.Checkpointer | From | To | |
| Extract Method private print(printer Consumer<String>, printExceptionMessages boolean) : void extracted from public print(printer Consumer<String>) : void in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Extract Method private printConflicts(printer Consumer<String>) : void extracted from public print(printer Consumer<String>) : void in class org.apache.ignite.internal.processors.cache.verify.IdleVerifyResultV2 | From | To | |
| Extract Method private checkConflicts(clusterHashes Map<PartitionKeyV2,List<PartitionHashRecordV2>>, exceptions Map<ClusterNode,Exception>) : IdleVerifyResultV2 extracted from public reduce(results List<ComputeJobResult>) : IdleVerifyResultV2 in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2 | From | To | |
| Extract Method private reduceResults(results List<ComputeJobResult>, clusterHashes Map<PartitionKeyV2,List<PartitionHashRecordV2>>, exceptions Map<ClusterNode,Exception>) : void extracted from public reduce(results List<ComputeJobResult>) : IdleVerifyResultV2 in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2 | From | To | |
| Extract Method private getGroupIds() : Set<Integer> extracted from public execute() : Map<PartitionKeyV2,PartitionHashRecordV2> in class org.apache.ignite.internal.processors.cache.verify.VerifyBackupPartitionsTaskV2.VerifyBackupPartitionsJobV2 | From | To |