ignite e833eb2d3d09112ddca994c17b73441df20524a3

e833eb2d3d09112ddca994c17b73441df20524a3

Files Diff

Added: 3
Removed: 0
Renamed: 0
Modified: 4

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	4
Pull Up Method public trackable() : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to public trackable() : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Method public map() : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to public map() : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Method public markNotTrackable() : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to public markNotTrackable() : void from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Method public futureId() : IgniteUuid from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to public futureId() : IgniteUuid from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Inline Method	5
Inline Method package completeFuture0(topVer AffinityTopologyVersion) : GridFutureAdapter<Void> inlined to public completeFuture(topVer AffinityTopologyVersion) : IgniteInternalFuture<Void> in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture	From	To
Inline Method private storeFuture() : boolean inlined to public onResult(nodeId UUID, res GridNearAtomicUpdateResponse, nodeErr boolean) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture	From	To
Inline Method private addFailedKeys(failedKeys Collection<KeyCacheObject>, topVer AffinityTopologyVersion, err Throwable) : void inlined to public onResult(nodeId UUID, res GridNearAtomicUpdateResponse, nodeErr boolean) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture	From	To
Inline Method private waitForPartitionExchange() : boolean inlined to public completeFuture(topVer AffinityTopologyVersion) : IgniteInternalFuture<Void> in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture	From	To
Inline Method private addInvokeResults(ret GridCacheReturn) : void inlined to public onResult(nodeId UUID, res GridNearAtomicUpdateResponse, nodeErr boolean) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture	From	To
Rename Variable	1
Rename Variable vals : Collection to val0 : Object in method private createSingleUpdateFuture(key K, val V, proc EntryProcessor, invokeArgs Object[], retval boolean, filter CacheEntryPredicate, waitTopFut boolean) : GridNearAtomicAbstractUpdateFuture in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Pull Up Attribute	28
Pull Up Attribute private topVer : AffinityTopologyVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected topVer : AffinityTopologyVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private opRes : GridCacheReturn from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected opRes : GridCacheReturn from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private nearEnabled : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected nearEnabled : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private futVer : GridCacheVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected futVer : GridCacheVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private topLocked : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected topLocked : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private op : GridCacheOperation from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected op : GridCacheOperation from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private filter : CacheEntryPredicate[] from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected filter : CacheEntryPredicate[] from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private logRef : AtomicReference<IgniteLogger> from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to private logRef : AtomicReference<IgniteLogger> from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private cctx : GridCacheContext from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected cctx : GridCacheContext from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private remapCnt : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected remapCnt : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private syncMode : CacheWriteSynchronizationMode from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected syncMode : CacheWriteSynchronizationMode from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private rawRetval : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected rawRetval : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private taskNameHash : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected taskNameHash : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private err : CachePartialUpdateCheckedException from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected err : CachePartialUpdateCheckedException from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private mapErrTopVer : AffinityTopologyVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected mapErrTopVer : AffinityTopologyVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private cache : GridDhtAtomicCache from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected cache : GridDhtAtomicCache from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private retval : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected retval : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private mux : Object from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected mux : Object from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private topCompleteFut : GridFutureAdapter<Void> from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected topCompleteFut : GridFutureAdapter<Void> from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute protected log : IgniteLogger from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected log : IgniteLogger from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private skipStore : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected skipStore : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private resCnt : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected resCnt : int from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private expiryPlc : ExpiryPolicy from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected expiryPlc : ExpiryPolicy from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private subjId : UUID from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected subjId : UUID from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private keepBinary : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected keepBinary : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private updVer : GridCacheVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected updVer : GridCacheVersion from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private invokeArgs : Object[] from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected invokeArgs : Object[] from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Pull Up Attribute private waitTopFut : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture to protected waitTopFut : boolean from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture	From	To
Change Return Type	1
Change Return Type GridNearAtomicUpdateFuture to GridNearAtomicAbstractUpdateFuture in method private createSingleUpdateFuture(key K, val V, proc EntryProcessor, invokeArgs Object[], retval boolean, filter CacheEntryPredicate, waitTopFut boolean) : GridNearAtomicAbstractUpdateFuture in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Extract Superclass	1
Extract Superclass org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicAbstractUpdateFuture from classes [org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture]	From	To
Extract Variable	1
Extract Variable filters : CacheEntryPredicate[] in method private createSingleUpdateFuture(key K, val V, proc EntryProcessor, invokeArgs Object[], retval boolean, filter CacheEntryPredicate, waitTopFut boolean) : GridNearAtomicAbstractUpdateFuture from class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Change Variable Type	4
Change Variable Type vals : Collection to val0 : Object in method private createSingleUpdateFuture(key K, val V, proc EntryProcessor, invokeArgs Object[], retval boolean, filter CacheEntryPredicate, waitTopFut boolean) : GridNearAtomicAbstractUpdateFuture in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Change Variable Type fut : GridNearAtomicUpdateFuture to fut : GridNearAtomicAbstractUpdateFuture in method private processNearAtomicUpdateResponse(nodeId UUID, res GridNearAtomicUpdateResponse) : void in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Change Variable Type updateFut : GridNearAtomicUpdateFuture to updateFut : GridNearAtomicAbstractUpdateFuture in method private updateAsync0(key K, val V, proc EntryProcessor, invokeArgs Object[], retval boolean, filter CacheEntryPredicate, waitTopFut boolean) : IgniteInternalFuture in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Change Variable Type updateFut : GridNearAtomicUpdateFuture to updateFut : GridNearAtomicAbstractUpdateFuture in method private removeAsync0(key K, retval boolean, filter CacheEntryPredicate) : IgniteInternalFuture in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To
Extract And Move Method	1
Extract And Move Method public isFastMap(filters CacheEntryPredicate[], op GridCacheOperation) : boolean extracted from public GridNearAtomicUpdateFuture(cctx GridCacheContext, cache GridDhtAtomicCache, syncMode CacheWriteSynchronizationMode, op GridCacheOperation, keys Collection<?>, vals Collection<?>, invokeArgs Object[], conflictPutVals Collection<GridCacheDrInfo>, conflictRmvVals Collection<GridCacheVersion>, retval boolean, rawRetval boolean, expiryPlc ExpiryPolicy, filter CacheEntryPredicate[], subjId UUID, taskNameHash int, skipStore boolean, keepBinary boolean, remapCnt int, waitTopFut boolean) in class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridNearAtomicUpdateFuture & moved to class org.apache.ignite.internal.processors.cache.distributed.dht.atomic.GridDhtAtomicCache	From	To

e833eb2d3d09112ddca994c17b73441df20524a3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: