34d8e2a3348b4109b00518ff3c447697a8f4d5d7
Files Diff
- Added: 10
- Removed: 0
- Renamed: 0
- Modified: 63
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 1 | ||
| Move And Inline Method public getTopologyId() : int moved from class org.infinispan.commands.functional.ReadWriteManyCommand to class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor & inlined to private handleWriteCommand(ctx InvocationContext, command DataWriteCommand) : Object | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type result : Object to result : T in method public primaryResult(result T, success boolean) : void in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private timeoutTask : ScheduledFuture<?> from class org.infinispan.util.concurrent.CommandAckCollector.BaseCollector to package timeoutTask : ScheduledFuture<?> from class org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget | From | To | |
| Pull Up Attribute package id : long from class org.infinispan.util.concurrent.CommandAckCollector.BaseCollector to package id : long from class org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget | From | To | |
| Pull Up Attribute package topologyId : int from class org.infinispan.util.concurrent.CommandAckCollector.BaseCollector to package topologyId : int from class org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget | From | To | |
| Rename Class | 1 | ||
| Rename Class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector renamed to org.infinispan.util.concurrent.CommandAckCollector.SegmentBasedCollector | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public completeExceptionally(id long, throwable Throwable, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Variable Type collector : MultiKeyCollector to collector : SegmentBasedCollector in method public multiKeyBackupAck(id long, from Address, segment int, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Variable Type collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public hasPendingBackupAcks(id long) : boolean in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Variable Type collector : SingleKeyCollector to ackTarget : BaseAckTarget in method public backupAck(id long, from Address, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Variable Type collector : MultiKeyCollector to collector : SegmentBasedCollector in method public createSegmentBasedCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) : Collector<Map<Object,Object>> in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Variable Type rpcFuture : CompletableFuture<Map<Address,Response>> to rpcFuture : CompletableFuture<?> in method private handleWriteOnOriginPrimary(ctx InvocationContext, command DataWriteCommand, rv Object, cacheEntry RepeatableReadEntry, seenValue Object, seenVersion EntryVersion, cacheTopology CacheTopology, info DistributionInfo) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Change Variable Type collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public onMembersChange(members Collection<Address>) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Extract Variable | 3 | ||
| Extract Variable builder : ConfigurationBuilder in method protected createCacheManagers() : void from class org.infinispan.distribution.MultipleNodesLeavingTest | From | To | |
| Extract Variable backup : Address in method public accept(ctx InvocationContext, command VisitableCommand, rv Object, throwable Throwable) : void from class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor.LocalWriteManyHandler | From | To | |
| Extract Variable recipients : List<Address> in method private handleWriteOnOriginPrimary(ctx InvocationContext, command DataWriteCommand, rv Object, cacheEntry RepeatableReadEntry, seenValue Object, seenVersion EntryVersion, cacheTopology CacheTopology, info DistributionInfo) : Object from class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Extract Method | 4 | ||
| Extract Method protected scheduleKeyInvalidation(key Object, nextVersion EntryVersion, removed boolean) : void extracted from private handleWriteManyOnOrigin(ctx InvocationContext, command C, helper WriteManyCommandHelper<C,Container,Item>) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Extract Method protected scheduleKeyInvalidation(key Object, nextVersion EntryVersion, removed boolean) : void extracted from private handleWriteOnOriginPrimary(ctx InvocationContext, command DataWriteCommand, rv Object, cacheEntry RepeatableReadEntry, seenValue Object, seenVersion EntryVersion, cacheTopology CacheTopology, info DistributionInfo) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Extract Method protected scheduleKeyInvalidation(key Object, nextVersion EntryVersion, removed boolean) : void extracted from private commitSingleEntryOnReturn(ctx InvocationContext, command DataWriteCommand, cacheEntry RepeatableReadEntry, nextVersion EntryVersion) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Extract Method protected singleWriteOnRemotePrimary(target Address, command DataWriteCommand) : CompletableFuture<Map<Address,Response>> extracted from private handleWriteCommand(ctx InvocationContext, command DataWriteCommand) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Rename Method | 1 | ||
| Rename Method public createMultiKeyCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) : Collector<Map<Object,Object>> renamed to public createSegmentBasedCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) : Collector<Map<Object,Object>> in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method package abstract hasPendingBackupAcks() : boolean from class org.infinispan.util.concurrent.CommandAckCollector.BaseCollector to package abstract hasPendingBackupAcks() : boolean from class org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget | From | To | |
| Pull Up Method package abstract onMembersChange(members Collection<Address>) : void from class org.infinispan.util.concurrent.CommandAckCollector.BaseCollector to package abstract onMembersChange(members Collection<Address>) : void from class org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget | From | To | |
| Rename Variable | 4 | ||
| Rename Variable collector : SingleKeyCollector to ackTarget : BaseAckTarget in method public backupAck(id long, from Address, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Rename Variable collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public hasPendingBackupAcks(id long) : boolean in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Rename Variable collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public completeExceptionally(id long, throwable Throwable, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Rename Variable collector : BaseCollector<?> to ackTarget : BaseAckTarget in method public onMembersChange(members Collection<Address>) : void in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Collector<Object> to Collector<T> in method public create(id long, backupOwners Collection<Address>, topologyId int) : Collector<T> in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.infinispan.util.concurrent.CommandAckCollector.BaseAckTarget from classes [org.infinispan.util.concurrent.CommandAckCollector.BaseCollector] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type collectorMap : ConcurrentHashMap<Long,BaseCollector<?>> to collectorMap : ConcurrentHashMap<Long,BaseAckTarget> in class org.infinispan.util.concurrent.CommandAckCollector | From | To | |
| Extract And Move Method | 6 | ||
| Extract And Move Method protected scheduleKeyInvalidation(key Object, nextVersion EntryVersion, removed boolean) : void extracted from public apply(rCtx InvocationContext, rCommand VisitableCommand, rv Object) : Object in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor.PrimaryResponseHandler & moved to class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
| Extract And Move Method protected scheduleKeyInvalidation(key Object, nextVersion EntryVersion, removed boolean) : void extracted from public accept(ctx InvocationContext, command VisitableCommand, rv Object, throwable Throwable) : void in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor.LocalWriteManyHandler & moved to class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To |