5c9d42d012661133f4642f2e4796a0d8a76b93c7
Files Diff
- Added: 14
- Removed: 2
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 2 | ||
| Move And Rename Method protected transformKeyToStrings(luceneWork LuceneWork) : LuceneWork from class org.infinispan.query.indexmanager.AbstractUpdateCommand to package transformKeysToString(luceneWork LuceneWork, handler KeyTransformationHandler) : LuceneWork from class org.infinispan.query.indexmanager.LuceneWorkConverter | From | To | |
| Move And Rename Method private clearIfNeeded(lockHolder Address) : void from class org.infinispan.query.affinity.AffinityIndexManager to private clearLockIfNeeded(affinityIndexManager AffinityIndexManager) : void from class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type works : List<LuceneWork> to works : Collection<LuceneWork> in method package partitionWorkByAddress(works Collection<LuceneWork>, originLocal boolean, isRetry boolean) : Map<ShardAddress,List<LuceneWork>> in class org.infinispan.query.affinity.WorkPartitioner | From | To | |
| Change Parameter Type lockHolder : Address to affinityIndexManager : AffinityIndexManager in method private clearLockIfNeeded(affinityIndexManager AffinityIndexManager) : void in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Move Method | 3 | ||
| Move Method private partitionWorkByAddress(works List<LuceneWork>) : Map<Address,List<LuceneWork>> from class org.infinispan.query.affinity.AffinityIndexManager to package partitionWorkByAddress(works Collection<LuceneWork>, originLocal boolean, isRetry boolean) : Map<ShardAddress,List<LuceneWork>> from class org.infinispan.query.affinity.WorkPartitioner | From | To | |
| Move Method protected addClusterEnabledCacheManager(builder ConfigurationBuilder, flags TransportFlags) : EmbeddedCacheManager from class org.infinispan.query.affinity.AffinityTopologyChangeTest to protected addClusterEnabledCacheManager(builder ConfigurationBuilder, flags TransportFlags) : EmbeddedCacheManager from class org.infinispan.query.affinity.IndexManagerPerfTest | From | To | |
| Move Method private newList(elements T...) : List<T> from class org.infinispan.query.affinity.AffinityIndexManager to private newList(elements T...) : List<T> from class org.infinispan.query.affinity.WorkPartitioner | From | To | |
| Move Attribute | 5 | ||
| Move Attribute private distributionManager : DistributionManager from class org.infinispan.query.affinity.AffinityIndexManager to private distributionManager : DistributionManager from class org.infinispan.query.affinity.ShardAllocationManagerImpl | From | To | |
| Move Attribute private rpcManager : RpcManager from class org.infinispan.query.affinity.AffinityIndexManager to private rpcManager : RpcManager from class org.infinispan.query.affinity.LuceneWorkDispatcher | From | To | |
| Move Attribute private identifiers : Set<String> from class org.infinispan.query.affinity.AffinityShardIdentifierProvider to private identifiers : Set<String> from class org.infinispan.query.affinity.PerSegmentShardDistribution | From | To | |
| Move Attribute private asyncExecutor : ExecutorService from class org.infinispan.query.affinity.AffinityIndexManager to private asyncExecutor : ExecutorService from class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Move Attribute private rpcManager : RpcManager from class org.infinispan.query.affinity.AffinityIndexManager to private rpcManager : RpcManager from class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Extract Class | 1 | ||
| Extract Class org.infinispan.query.affinity.WorkPartitioner from class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Move Class | 3 | ||
| Move Class org.infinispan.query.affinity.AffinityTopologyChangeTest.Node moved to org.infinispan.query.affinity.BaseAffinityTest.Node | From | To | |
| Move Class org.infinispan.query.affinity.AffinityTopologyChangeTest.TaskNode moved to org.infinispan.query.affinity.BaseAffinityTest.TaskNode | From | To | |
| Move Class org.infinispan.query.affinity.AffinityTopologyChangeTest.IndexingNode moved to org.infinispan.query.affinity.BaseAffinityTest.IndexingNode | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type localAddress : Address to localShardAddress : ShardAddress in method package performOperations(workList List<LuceneWork>, monitor IndexingMonitor, originLocal boolean, isRetry boolean) : void in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Change Variable Type im : IndexManager to indexManagers : List<IndexManager> in method public invokeAsync() : CompletableFuture<Object> in class org.infinispan.query.affinity.AffinityUpdateCommand | From | To | |
| Inline Variable | 2 | ||
| Inline Variable size : int in method package pickCache() : Cache<String,Entity> from class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Inline Variable localAddress : Address in method public performOperations(workList List<LuceneWork>, monitor IndexingMonitor) : void from class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Extract Method | 3 | ||
| Extract Method package performOperations(workList List<LuceneWork>, monitor IndexingMonitor, originLocal boolean, isRetry boolean) : void extracted from public performOperations(workList List<LuceneWork>, monitor IndexingMonitor) : void in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Extract Method private checkOwnership() : void extracted from public performOperations(workList List<LuceneWork>, monitor IndexingMonitor) : void in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Extract Method private shouldHandle(context ErrorContext) : boolean extracted from protected errorOccurred(context ErrorContext) : void in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Rename Method | 5 | ||
| Rename Method private getIndexManagerForWrites(luceneWork LuceneWork) : IndexManager renamed to private getIndexManagerForModifications(luceneWork LuceneWork) : List<IndexManager> in class org.infinispan.query.affinity.AffinityUpdateCommand | From | To | |
| Rename Method protected getNumNodes() : int renamed to protected getRemoteTimeoutInMinutes() : int in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Method protected getCacheConfig() : ConfigurationBuilder renamed to protected getDefaultCacheConfigBuilder() : ConfigurationBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Method protected getBaseCacheConfig(cacheMode CacheMode) : ConfigurationBuilder renamed to protected getBaseConfigBuilder(cacheMode CacheMode) : ConfigurationBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Method private extractFailedOperations(context ErrorContext) : List<LuceneWork> renamed to private extractFailedWorks(errorContext ErrorContext) : List<LuceneWork> in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Push Down Method | 2 | ||
| Push Down Method package checkAffinity() : void from class org.infinispan.query.affinity.BaseAffinityTest to package checkAffinity() : void from class org.infinispan.query.affinity.AffinityTest | From | To | |
| Push Down Method private checkAffinity(indexCache Cache<IndexScopedKey,?>) : void from class org.infinispan.query.affinity.BaseAffinityTest to private checkAffinity(indexCache Cache<IndexScopedKey,?>) : void from class org.infinispan.query.affinity.AffinityTest | From | To | |
| Rename Variable | 4 | ||
| Rename Variable configurationBuilder : ConfigurationBuilder to baseConfigBuilder : ConfigurationBuilder in method protected getDefaultCacheConfigBuilder() : ConfigurationBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Variable im : IndexManager to indexManagers : List<IndexManager> in method public invokeAsync() : CompletableFuture<Object> in class org.infinispan.query.affinity.AffinityUpdateCommand | From | To | |
| Rename Variable builder : ConfigurationBuilder to configBuilder : ConfigurationBuilder in method protected getBaseConfigBuilder(cacheMode CacheMode) : ConfigurationBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Variable builder : IndexingConfigurationBuilder to indexCfgBuilder : IndexingConfigurationBuilder in method protected getDefaultCacheConfigBuilder() : ConfigurationBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Change Return Type | 5 | ||
| Change Return Type IndexManager to List<IndexManager> in method private getIndexManagerForModifications(luceneWork LuceneWork) : List<IndexManager> in class org.infinispan.query.affinity.AffinityUpdateCommand | From | To | |
| Change Return Type Map<Address,List<LuceneWork>> to Map<ShardAddress,List<LuceneWork>> in method package partitionWorkByAddress(works Collection<LuceneWork>, originLocal boolean, isRetry boolean) : Map<ShardAddress,List<LuceneWork>> in class org.infinispan.query.affinity.WorkPartitioner | From | To | |
| Change Return Type void to boolean in method protected abstract errorOccurred(context ErrorContext) : boolean in class org.infinispan.query.backend.WrappingErrorHandler | From | To | |
| Change Return Type void to boolean in method protected errorOccurred(context ErrorContext) : boolean in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Change Return Type ConfigurationBuilder to ConfigurationChildBuilder in method protected getBaseIndexCacheConfig(mode CacheMode) : ConfigurationChildBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute localAddress : Address to localShardAddress : ShardAddress in method package performOperations(workList List<LuceneWork>, monitor IndexingMonitor, originLocal boolean, isRetry boolean) : void in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Replace Variable With Attribute component : SearchIntegrator to searchIntegrator : SearchIntegrator in method public initialize(indexName String, properties Properties, similarity Similarity, buildContext WorkerBuildContext) : void in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute distributionManager : DistributionManager to shardAllocatorManager : ShardAllocatorManager in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type cache : Cache to cache : Cache<?,?> in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Change Attribute Type POLL_WAIT : int to POLL_WAIT : long in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Change Attribute Type distributionManager : DistributionManager to shardAllocatorManager : ShardAllocatorManager in class org.infinispan.query.affinity.AffinityIndexManager | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public initialize(rpcManager RpcManager, asyncExecutor ExecutorService) : void extracted from public initialize(indexName String, properties Properties, similarity Similarity, buildContext WorkerBuildContext) : void in class org.infinispan.query.affinity.AffinityIndexManager & moved to class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Extract And Move Method protected assertDocsIndexed(millis long) : void extracted from public testReadWriteUnderTopologyChanges() : void in class org.infinispan.query.affinity.AffinityTopologyChangeTest & moved to class org.infinispan.query.affinity.BaseAffinityTest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter lockHolder : Address to affinityIndexManager : AffinityIndexManager in method private clearLockIfNeeded(affinityIndexManager AffinityIndexManager) : void in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Rename Parameter context : ErrorContext to errorContext : ErrorContext in method private extractFailedWorks(errorContext ErrorContext) : List<LuceneWork> in class org.infinispan.query.affinity.AffinityErrorHandler | From | To | |
| Rename Parameter cacheMode : CacheMode to mode : CacheMode in method protected getBaseIndexCacheConfig(mode CacheMode) : ConfigurationChildBuilder in class org.infinispan.query.affinity.BaseAffinityTest | From | To |