6557ea138fcdf9d26aa6095a4912a8801dc48556
Files Diff
- Added: 9
- Removed: 1
- Renamed: 0
- Modified: 58
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 31 | ||
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public hasProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ProtobufPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isRepeatedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ProtobufPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public abstract isRepeatedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ObjectPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public abstract getPrimitivePropertyType(entityType String, propertyPath String[]) : Class<?> in class org.infinispan.objectfilter.impl.hql.ObjectPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public AggregationExpr(aggregationType PropertyPath.AggregationType, propertyPath String[], isRepeated boolean, primitiveType Class<?>) in class org.infinispan.objectfilter.impl.syntax.AggregationExpr | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public hasEmbeddedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.RowPropertyHelper | From | To | |
| Change Parameter Type path : List<String> to path : String[] in method public translatePropertyPath(path String[]) : List<Integer> in class org.infinispan.objectfilter.impl.RowMatcher.MetadataAdapterImpl | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isStored(propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.syntax.BooleShannonExpansion.IndexedFieldProvider | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public getPrimitivePropertyType(entityType String, propertyPath String[]) : Class<?> in class org.infinispan.objectfilter.impl.hql.ReflectionPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public PropertyValueExpr(propertyPath String[], isRepeated boolean, primitiveType Class<?>) in class org.infinispan.objectfilter.impl.syntax.PropertyValueExpr | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public abstract hasProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ObjectPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isIndexed(propertyPath String[]) : boolean in class org.infinispan.query.dsl.embedded.impl.HibernateSearchIndexedFieldProvider | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public abstract hasEmbeddedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ObjectPropertyHelper | From | To | |
| Change Parameter Type path : List<String> to path : String[] in method public translatePropertyPath(path String[]) : List<Integer> in class org.infinispan.objectfilter.impl.ProtobufMatcher.MetadataAdapterImpl | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isRepeatedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.RowPropertyHelper | From | To | |
| Change Parameter Type attributePath : String to attributePath : String[] in method private getFieldDescriptor(serCtx SerializationContext, type String, attributePath String[]) : FieldDescriptor in class org.infinispan.query.remote.impl.RemoteQueryEngine | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public getPrimitivePropertyType(entityType String, propertyPath String[]) : Class<?> in class org.infinispan.objectfilter.impl.hql.ProtobufPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public hasProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.RowPropertyHelper | From | To | |
| Change Parameter Type jpqlString : String to filterParsingResult : FilterParsingResult<?> in method protected buildLuceneQuery(filterParsingResult FilterParsingResult<?>, namedParameters Map<String,Object>, startOffset long, maxResults int) : CacheQuery in class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public hasEmbeddedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ReflectionPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method private getPropertyAccessor(entityClass Class<?>, propertyPath String[]) : ReflectionHelper.PropertyAccessor in class org.infinispan.objectfilter.impl.hql.ReflectionPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method private getField(entityType String, propertyPath String[]) : FieldDescriptor in class org.infinispan.objectfilter.impl.hql.ProtobufPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method private getColumnAccessor(propertyPath String[]) : ColumnMetadata in class org.infinispan.objectfilter.impl.hql.RowPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isStored(propertyPath String[]) : boolean in class org.infinispan.query.dsl.embedded.impl.HibernateSearchIndexedFieldProvider | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isIndexed(propertyPath String[]) : boolean in class org.infinispan.query.remote.impl.ProtobufIndexedFieldProvider | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public hasEmbeddedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ProtobufPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isStored(propertyPath String[]) : boolean in class org.infinispan.query.remote.impl.ProtobufIndexedFieldProvider | From | To | |
| Change Parameter Type path : List<String> to path : String[] in method public translatePropertyPath(path String[]) : List<String> in class org.infinispan.objectfilter.impl.ReflectionMatcher.MetadataAdapterImpl | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isRepeatedProperty(entityType String, propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.hql.ReflectionPropertyHelper | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public isIndexed(propertyPath String[]) : boolean in class org.infinispan.objectfilter.impl.syntax.BooleShannonExpansion.IndexedFieldProvider | From | To | |
| Change Parameter Type propertyPath : List<String> to propertyPath : String[] in method public getPrimitivePropertyType(entityType String, propertyPath String[]) : Class<?> in class org.infinispan.objectfilter.impl.hql.RowPropertyHelper | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private primitives : Map<Class<?>,Class<?>> from class org.infinispan.objectfilter.impl.hql.ReflectionPropertyHelper to protected primitives : Map<Class<?>,Class<?>> from class org.infinispan.objectfilter.impl.hql.ObjectPropertyHelper | From | To | |
| Move Attribute | 6 | ||
| Move Attribute protected queryParser : QueryParser from class org.infinispan.objectfilter.impl.hql.AbstractParsingTest to private queryParser : QueryParser from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Move Attribute private queryParser : QueryParser from class org.infinispan.objectfilter.impl.syntax.BooleShannonExpansionTest to private queryParser : QueryParser from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Move Attribute private entityNamesResolver : EntityNamesResolver from class org.infinispan.objectfilter.impl.RowMatcher to private entityNamesResolver : EntityNamesResolver from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Move Attribute private queryParser : QueryParser from class org.infinispan.objectfilter.impl.BaseMatcher to private queryParser : QueryParser from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Move Attribute private queryParser : QueryParser from class org.infinispan.objectfilter.impl.syntax.BooleanFilterNormalizerTest to private queryParser : QueryParser from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Move Attribute private entityNamesResolver : EntityNamesResolver from class org.infinispan.objectfilter.impl.ReflectionMatcher to private entityNamesResolver : EntityNamesResolver from class org.infinispan.objectfilter.impl.hql.JPQLParser | From | To | |
| Extract Class | 3 | ||
| Extract Class org.infinispan.objectfilter.impl.hql.JPQLParser from class org.infinispan.objectfilter.impl.ReflectionMatcher | From | To | |
| Extract Class org.infinispan.objectfilter.impl.hql.JPQLParser from class org.infinispan.objectfilter.impl.RowMatcher | From | To | |
| Extract Class org.infinispan.objectfilter.impl.hql.JPQLParser from class org.infinispan.objectfilter.impl.ProtobufMatcher | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type captor : ArgumentCaptor<LuceneQueryParsingResult> to captor : ArgumentCaptor<FilterParsingResult> in method public testQueryCache() : void in class org.infinispan.query.impl.QueryCacheEmbeddedTest | From | To | |
| Change Variable Type cachedParsingResult : LuceneQueryParsingResult to cachedParsingResult : FilterParsingResult in method public testQueryCache() : void in class org.infinispan.query.impl.QueryCacheEmbeddedTest | From | To | |
| Change Variable Type propType : TypeDescriptor to propType : FilterTypeDescriptor in method protected normalizeProperty(type FilterTypeDescriptor, path List<String>, propertyName String) : PathedPropertyReferenceSource in class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Change Variable Type propertyPath : List<String> to propertyPath : String[] in method private assertExpectedTree(jpaQuery String, expectedExprStr String, expectedJpa String) : void in class org.infinispan.objectfilter.impl.syntax.BooleShannonExpansionTest | From | To | |
| Extract Variable | 2 | ||
| Extract Variable alias : String in method public normalizeQualifiedRoot(root Tree) : PathedPropertyReferenceSource from class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Extract Variable property : String in method public normalizeUnqualifiedPropertyReference(propertyTree Tree) : PathedPropertyReferenceSource from class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Rename Method | 2 | ||
| Rename Method protected createFilterProcessingChain() : FilterProcessingChain<Class<?>> renamed to protected createParser() : JPQLParser<Class<?>> in class org.infinispan.objectfilter.impl.hql.ReflectionParsingTest | From | To | |
| Rename Method protected createFilterProcessingChain() : FilterProcessingChain<Descriptor> renamed to protected createParser() : JPQLParser<Descriptor> in class org.infinispan.objectfilter.impl.hql.ProtobufParsingTest | From | To | |
| Rename Variable | 4 | ||
| Rename Variable deduplicated : PropertyPath[] to deduplicatedProjection : PropertyPath[] in method private buildQueryNoAggregations(queryFactory QueryFactory, jpqlString String, namedParameters Map<String,Object>, startOffset long, maxResults int, parsingResult FilterParsingResult<?>) : BaseQuery in class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
| Rename Variable parsingResult : LuceneQueryParsingResult to luceneParsingResult : LuceneQueryParsingResult in method protected buildLuceneQuery(filterParsingResult FilterParsingResult<?>, namedParameters Map<String,Object>, startOffset long, maxResults int) : CacheQuery in class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
| Rename Variable protobufPropertyHelper : ProtobufPropertyHelper to propertyHelper : ProtobufPropertyHelper in method protected createParser() : JPQLParser<Descriptor> in class org.infinispan.objectfilter.impl.hql.ProtobufParsingTest | From | To | |
| Rename Variable reflectionPropertyHelper : ReflectionPropertyHelper to propertyHelper : ReflectionPropertyHelper in method protected createParser() : JPQLParser<Class<?>> in class org.infinispan.objectfilter.impl.hql.ReflectionParsingTest | From | To | |
| Change Return Type | 4 | ||
| Change Return Type List<String> to String[] in method public getPath() : String[] in class org.infinispan.objectfilter.PropertyPath | From | To | |
| Change Return Type List<String> to String[] in method public getPropertyPath() : String[] in class org.infinispan.objectfilter.impl.syntax.PropertyValueExpr | From | To | |
| Change Return Type FilterProcessingChain<Class<?>> to JPQLParser<Class<?>> in method protected createParser() : JPQLParser<Class<?>> in class org.infinispan.objectfilter.impl.hql.ReflectionParsingTest | From | To | |
| Change Return Type FilterProcessingChain<Descriptor> to JPQLParser<Descriptor> in method protected createParser() : JPQLParser<Descriptor> in class org.infinispan.objectfilter.impl.hql.ProtobufParsingTest | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable split : String[] to attributePath : String[] in method private getFieldDescriptor(serCtx SerializationContext, type String, attributePath String[]) : FieldDescriptor in class org.infinispan.query.remote.impl.RemoteQueryEngine | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute definingSelect : boolean to status : Status in class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type path : List<String> to path : String[] in class org.infinispan.objectfilter.PropertyPath | From | To | |
| Change Attribute Type propertyPath : List<String> to propertyPath : String[] in class org.infinispan.objectfilter.impl.syntax.PropertyValueExpr | From | To | |
| Change Attribute Type definingSelect : boolean to status : Status in class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter property : Tree to propertyTree : Tree in method public normalizeUnqualifiedPropertyReference(propertyTree Tree) : PathedPropertyReferenceSource in class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To | |
| Rename Parameter jpqlString : String to filterParsingResult : FilterParsingResult<?> in method protected buildLuceneQuery(filterParsingResult FilterParsingResult<?>, namedParameters Map<String,Object>, startOffset long, maxResults int) : CacheQuery in class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
| Rename Parameter propertyName : Tree to propertyNameTree : Tree in method public normalizePropertyPathIntermediary(path PropertyPath, propertyNameTree Tree) : PathedPropertyReferenceSource in class org.infinispan.objectfilter.impl.hql.FilterQueryResolverDelegate | From | To |