90eecaf4801f757a40e5c15265d9ebb0b273b6db
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private dispose(server SaslServer) : void renamed to private disposeSaslServer() : void in class org.infinispan.server.hotrod.Authentication | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type peerPrincipal : Principal to peerPrincipal : X500Principal in method package ExternalSaslServer(callbackHandler CallbackHandler, peerPrincipal X500Principal) in class org.infinispan.server.core.security.external.ExternalSaslServer | From | To | |
| Change Parameter Type peerPrincipal : Principal to peerPrincipal : X500Principal in method public ExternalSaslServerFactory(peerPrincipal X500Principal) in class org.infinispan.server.core.security.external.ExternalSaslServerFactory | From | To | |
| Change Parameter Type taskClasses : Class<? extends AdminServerTask>... to tasks : AdminServerTask<?>... in method protected AdminOperationsHandler(tasks AdminServerTask<?>...) in class org.infinispan.server.core.admin.AdminOperationsHandler | From | To | |
| Move Method | 1 | ||
| Move Method package normalizeAuthorizationId(id String) : String from class org.infinispan.server.hotrod.Authentication to private normalizeAuthorizationId(id String) : String from class org.infinispan.server.core.security.SubjectSaslServer | From | To | |
| Rename Variable | 1 | ||
| Rename Variable extraPrincipals : List<Principal> to principals : List<Principal> in method private createSaslServer(mech String) : SaslServer in class org.infinispan.server.hotrod.Authentication | From | To | |
| Change Return Type | 5 | ||
| Change Return Type Iterator<SaslClientFactory> to Collection<SaslClientFactory> in method public getSaslClientFactories(classLoader ClassLoader, includeGlobal boolean) : Collection<SaslClientFactory> in class org.infinispan.commons.util.SaslUtils | From | To | |
| Change Return Type Iterator<SaslServerFactory> to Collection<SaslServerFactory> in method public getSaslServerFactories(classLoader ClassLoader, includeGlobal boolean) : Collection<SaslServerFactory> in class org.infinispan.commons.util.SaslUtils | From | To | |
| Change Return Type Iterator<SaslClientFactory> to Collection<SaslClientFactory> in method public getSaslClientFactories() : Collection<SaslClientFactory> in class org.infinispan.commons.util.SaslUtils | From | To | |
| Change Return Type Iterator<SaslServerFactory> to Collection<SaslServerFactory> in method public getSaslServerFactories() : Collection<SaslServerFactory> in class org.infinispan.commons.util.SaslUtils | From | To | |
| Change Return Type Iterator<T> to Collection<T> in method private getFactories(type Class<T>, classLoader ClassLoader, includeGlobal boolean) : Collection<T> in class org.infinispan.commons.util.SaslUtils | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private callbackHandler : AuthorizingCallbackHandler from class org.infinispan.server.hotrod.Authentication to private callbackHandler : AuthorizingCallbackHandler from class org.infinispan.server.core.security.SubjectSaslServer | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute server : SaslServer to saslServer : SaslServer in method private disposeSaslServer() : void in class org.infinispan.server.hotrod.Authentication | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type clientFactories : Iterator<SaslClientFactory> to clientFactories : Collection<SaslClientFactory> in method private getSaslClientFactory(configuration AuthenticationConfiguration) : SaslClientFactory in class org.infinispan.client.hotrod.impl.transport.netty.ChannelInitializer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable authorizationId : String in method private initAuthentication(channel Channel, authentication AuthenticationConfiguration) : void from class org.infinispan.client.hotrod.impl.transport.netty.ChannelInitializer | From | To | |
| Extract Method | 2 | ||
| Extract Method private createSaslServer(mech String) : SaslServer extracted from private authInternal(header HotRodHeader, mech String, response byte[]) : void in class org.infinispan.server.hotrod.Authentication | From | To | |
| Extract Method private authComplete(header HotRodHeader, serverChallenge byte[]) : void extracted from private authInternal(header HotRodHeader, mech String, response byte[]) : void in class org.infinispan.server.hotrod.Authentication | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type peerPrincipal : Principal to peerPrincipal : X500Principal in class org.infinispan.server.core.security.external.ExternalSaslServerFactory | From | To | |
| Change Attribute Type peerPrincipal : Principal to peerPrincipal : X500Principal in class org.infinispan.server.core.security.external.ExternalSaslServer | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter taskClasses : Class<? extends AdminServerTask>... to tasks : AdminServerTask<?>... in method protected AdminOperationsHandler(tasks AdminServerTask<?>...) in class org.infinispan.server.core.admin.AdminOperationsHandler | From | To |