967da50b7a3201a1f3319821a8d6f55c1ad65815
Files Diff
- Added: 19
- Removed: 9
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 1 | ||
| Extract Subclass org.infinispan.query.remote.impl.BaseRemoteQueryManager from class org.infinispan.query.remote.impl.RemoteQueryManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type queryResponse : QueryResponse to queryResponse : Object in method public encodeQueryResponse(queryResponse Object, destinationType MediaType) : byte[] in class org.infinispan.query.remote.impl.DefaultQuerySerializer | From | To | |
| Move Method | 2 | ||
| Move Method public executeQuery(q String, offset Integer, maxResults Integer, queryMode IndexedQueryMode, cache AdvancedCache) : RemoteQueryResult from class org.infinispan.query.remote.impl.RemoteQueryManager to public executeQuery(q String, namedParametersMap Map<String,Object>, offset Integer, maxResults Integer, queryMode IndexedQueryMode, cache AdvancedCache, outputFormat MediaType) : byte[] from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Move Method public encodeQueryResponse(queryResponse QueryResponse, destinationType MediaType) : byte[] from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to public encodeQueryResponse(queryResponse Object, destinationType MediaType) : byte[] from class org.infinispan.query.remote.impl.DefaultQuerySerializer | From | To | |
| Pull Up Attribute | 5 | ||
| Pull Up Attribute private valueDataConversion : DataConversion from class org.infinispan.query.remote.impl.ProtobufRemoteQueryManager to package valueDataConversion : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Attribute private keyDataConversion : DataConversion from class org.infinispan.query.remote.impl.ProtobufRemoteQueryManager to package keyDataConversion : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Attribute private cache : AdvancedCache<?,?> from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to package cache : AdvancedCache<?,?> from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Attribute private valueDataConversion : DataConversion from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to package valueDataConversion : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Attribute private keyDataConversion : DataConversion from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to package keyDataConversion : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private mapper : ObjectMapper from class org.infinispan.rest.search.InfinispanSearchRequest to private mapper : ObjectMapper from class org.infinispan.query.remote.json.JsonQueryReader | From | To | |
| Move And Rename Class | 6 | ||
| Move And Rename Class org.infinispan.rest.search.Projection moved and renamed to org.infinispan.query.remote.json.JsonProjection | From | To | |
| Move And Rename Class org.infinispan.rest.search.ProjectedResult moved and renamed to org.infinispan.query.remote.json.ProjectedJsonResult | From | To | |
| Move And Rename Class org.infinispan.rest.search.QueryErrorResult moved and renamed to org.infinispan.query.remote.json.JsonQueryErrorResult | From | To | |
| Move And Rename Class org.infinispan.rest.search.BaseQueryResult moved and renamed to org.infinispan.query.remote.json.BaseJsonQueryResult | From | To | |
| Move And Rename Class org.infinispan.rest.search.QueryRequest moved and renamed to org.infinispan.query.remote.json.JsonQueryRequest | From | To | |
| Move And Rename Class org.infinispan.rest.search.QueryResult moved and renamed to org.infinispan.query.remote.json.JsonQueryResult | From | To | |
| Move Class | 2 | ||
| Move Class org.infinispan.rest.search.HitSerializer moved to org.infinispan.query.remote.json.HitSerializer | From | To | |
| Move Class org.infinispan.rest.search.Hit moved to org.infinispan.query.remote.json.Hit | From | To | |
| Extract Variable | 1 | ||
| Extract Variable destinationClass : Class<?> in method public transcode(content Object, contentType MediaType, destinationType MediaType) : Object from class org.infinispan.server.core.dataconversion.JsonTranscoder | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type response : QueryResponse to response : BaseQueryResponse in method private executeQuery() : void in class org.infinispan.client.hotrod.impl.query.RemoteQuery | From | To | |
| Change Variable Type startOffset : long to startOffset : int in method public query(cache AdvancedCache<byte[],byte[]>, query byte[]) : byte[] in class org.infinispan.query.remote.impl.QueryFacadeImpl | From | To | |
| Change Variable Type queryRequest : QueryRequest to jsonQueryRequest : JsonQueryRequest in method protected execute() : InfinispanResponse in class org.infinispan.rest.search.InfinispanSearchRequest | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public convertValue(value Object, destinationFormat MediaType) : Object from class org.infinispan.query.remote.impl.RemoteQueryManager to public convertValue(value Object, destinationFormat MediaType) : Object from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Push Down Method public convertKey(key Object, destinationFormat MediaType) : Object from class org.infinispan.query.remote.impl.RemoteQueryManager to public convertKey(key Object, destinationFormat MediaType) : Object from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method | 6 | ||
| Pull Up Method public getKeyDataConversion() : DataConversion from class org.infinispan.query.remote.impl.ProtobufRemoteQueryManager to public getKeyDataConversion() : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method public getKeyDataConversion() : DataConversion from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to public getKeyDataConversion() : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method public getValueDataConversion() : DataConversion from class org.infinispan.query.remote.impl.ProtobufRemoteQueryManager to public getValueDataConversion() : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method public decodeQueryRequest(queryRequest byte[], requestType MediaType) : QueryRequest from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to public decodeQueryRequest(queryRequest byte[], requestType MediaType) : QueryRequest from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method public decodeQueryRequest(queryRequest byte[], mediaType MediaType) : QueryRequest from class org.infinispan.query.remote.impl.ProtobufRemoteQueryManager to public decodeQueryRequest(queryRequest byte[], requestType MediaType) : QueryRequest from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Pull Up Method public getValueDataConversion() : DataConversion from class org.infinispan.query.remote.impl.ObjectRemoteQueryManager to public getValueDataConversion() : DataConversion from class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Rename Variable | 1 | ||
| Rename Variable queryRequest : QueryRequest to jsonQueryRequest : JsonQueryRequest in method protected execute() : InfinispanResponse in class org.infinispan.rest.search.InfinispanSearchRequest | From | To | |
| Change Return Type | 4 | ||
| Change Return Type QueryRequest to JsonQueryRequest in method private getQueryFromString() : JsonQueryRequest in class org.infinispan.rest.search.InfinispanSearchRequest | From | To | |
| Change Return Type List<Projection> to List<JsonProjection> in method public getHits() : List<JsonProjection> in class org.infinispan.query.remote.json.ProjectedJsonResult | From | To | |
| Change Return Type RemoteQueryResult to byte[] in method public executeQuery(q String, namedParametersMap Map<String,Object>, offset Integer, maxResults Integer, queryMode IndexedQueryMode, cache AdvancedCache, outputFormat MediaType) : byte[] in class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To | |
| Change Return Type QueryRequest to JsonQueryRequest in method private getQueryFromJSON() : JsonQueryRequest in class org.infinispan.rest.search.InfinispanSearchRequest | From | To | |
| Extract Superclass | 2 | ||
| Extract Superclass org.infinispan.query.remote.impl.BaseRemoteQueryManager from classes [org.infinispan.query.remote.impl.ObjectRemoteQueryManager, org.infinispan.query.remote.impl.ProtobufRemoteQueryManager] | From | To | |
| Extract Superclass org.infinispan.query.remote.json.JsonQueryResponse from classes [org.infinispan.query.remote.json.BaseJsonQueryResult, org.infinispan.query.remote.json.JsonQueryErrorResult] | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.infinispan.query.remote.client.BaseQueryResponse from classes [org.infinispan.query.remote.client.QueryResponse] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type hits : List<Projection> to hits : List<JsonProjection> in class org.infinispan.query.remote.json.ProjectedJsonResult | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public isQueryEnabled(cache AdvancedCache<byte[],byte[]>) : boolean extracted from public query(cache AdvancedCache<byte[],byte[]>, query byte[]) : byte[] in class org.infinispan.query.remote.impl.QueryFacadeImpl & moved to class org.infinispan.query.remote.impl.RemoteQueryManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter mediaType : MediaType to requestType : MediaType in method public decodeQueryRequest(queryRequest byte[], requestType MediaType) : QueryRequest in class org.infinispan.query.remote.impl.BaseRemoteQueryManager | From | To |