b85cf1fa6fb0f05e63bfa6fb2006f1ea5f44a46f
Files Diff
- Added: 23
- Removed: 9
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private commit() : int renamed to private onePhaseCommitTransaction() : int in class org.infinispan.server.hotrod.tx.PrepareCoordinator | From | To | |
| Rename Method public status() : int renamed to public getStatus() : Status in class org.infinispan.server.hotrod.tx.table.TxState | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private encodeCommitOrRollbackOp(op CommitOrRollbackOp, byteBuf ByteBuf) : void from class org.infinispan.server.hotrod.test.Encoder to public writeXid(xid Xid, buffer ByteBuf) : void from class org.infinispan.server.hotrod.transport.ExtendedByteBuf | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type status : int to status : Status in method private TxState(globalTransaction GlobalTransaction, status Status, modifications List<WriteCommand>, recoverable boolean, timeout long, accessTime long) in class org.infinispan.server.hotrod.tx.table.TxState | From | To | |
| Change Parameter Type context : PrepareTransactionDecodeContext to txCoordinator : PrepareCoordinator in method private checkExistingTxForPrepare(header HotRodHeader, txCoordinator PrepareCoordinator) : boolean in class org.infinispan.server.hotrod.TransactionRequestProcessor | From | To | |
| Rename Variable | 6 | ||
| Rename Variable serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty(cacheName String) : void in class org.infinispan.server.hotrod.tx.ServerConfigurationTest | From | To | |
| Rename Variable txContext : PrepareTransactionDecodeContext to prepareCoordinator : PrepareCoordinator in method private prepareTransactionInternal(header HotRodHeader, cache AdvancedCache<byte[],byte[]>, xid XidImpl, onePhaseCommit boolean, writes List<TransactionWrite>, recoverable boolean, timeout long) : void in class org.infinispan.server.hotrod.TransactionRequestProcessor | From | To | |
| Rename Variable globalTxTable : Cache<CacheXid,TxState> to cache : Cache<CacheXid,TxState> in method private createGlobalTxTable(cacheManager EmbeddedCacheManager) : void in class org.infinispan.server.hotrod.LifecycleCallbacks | From | To | |
| Rename Variable serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty() : void in class org.infinispan.server.hotrod.tx.TxFunctionalTest | From | To | |
| Rename Variable transactionTable : ServerTransactionTable to txTable : GlobalTxTable in method private createGlobalTxTable(cacheManager EmbeddedCacheManager) : void in class org.infinispan.server.hotrod.LifecycleCallbacks | From | To | |
| Rename Variable serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty() : void in class org.infinispan.server.hotrod.tx.TopologyChangeFunctionalTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type int to Status in method public getStatus() : Status in class org.infinispan.server.hotrod.tx.table.TxState | From | To | |
| Rename Class | 1 | ||
| Rename Class org.infinispan.server.hotrod.tx.PrepareTransactionDecodeContext renamed to org.infinispan.server.hotrod.tx.PrepareCoordinator | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.infinispan.server.hotrod.tx.ServerTransactionTable moved and renamed to org.infinispan.server.hotrod.tx.table.PerCacheTxTable | From | To | |
| Move Class | 3 | ||
| Move Class org.infinispan.server.hotrod.tx.ClientAddress moved to org.infinispan.server.hotrod.tx.table.ClientAddress | From | To | |
| Move Class org.infinispan.server.hotrod.tx.TxState moved to org.infinispan.server.hotrod.tx.table.TxState | From | To | |
| Move Class org.infinispan.server.hotrod.tx.CacheXid moved to org.infinispan.server.hotrod.tx.table.CacheXid | From | To | |
| Extract Variable | 1 | ||
| Extract Variable prepared : boolean in method public prepare(onePhaseCommit boolean) : int from class org.infinispan.server.hotrod.tx.PrepareCoordinator | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty() : void in class org.infinispan.server.hotrod.tx.TopologyChangeFunctionalTest | From | To | |
| Change Variable Type serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty() : void in class org.infinispan.server.hotrod.tx.TxFunctionalTest | From | To | |
| Change Variable Type serverTransactionTable : ServerTransactionTable to perCacheTxTable : PerCacheTxTable in method private assertServerTransactionTableEmpty(cacheName String) : void in class org.infinispan.server.hotrod.tx.ServerConfigurationTest | From | To | |
| Change Variable Type transactionTable : ServerTransactionTable to txTable : GlobalTxTable in method private createGlobalTxTable(cacheManager EmbeddedCacheManager) : void in class org.infinispan.server.hotrod.LifecycleCallbacks | From | To | |
| Change Variable Type txContext : PrepareTransactionDecodeContext to prepareCoordinator : PrepareCoordinator in method private prepareTransactionInternal(header HotRodHeader, cache AdvancedCache<byte[],byte[]>, xid XidImpl, onePhaseCommit boolean, writes List<TransactionWrite>, recoverable boolean, timeout long) : void in class org.infinispan.server.hotrod.TransactionRequestProcessor | From | To | |
| Extract Method | 2 | ||
| Extract Method private createGlobalTxTable(cacheManager EmbeddedCacheManager) : void extracted from private registerServerTransactionTable(componentRegistry ComponentRegistry, cacheName String) : void in class org.infinispan.server.hotrod.LifecycleCallbacks | From | To | |
| Extract Method public cache(header HotRodHeader, subject Subject, cacheName String) : AdvancedCache<byte[],byte[]> extracted from public cache(header HotRodHeader, subject Subject) : AdvancedCache<byte[],byte[]> in class org.infinispan.server.hotrod.HotRodServer | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type status : int to status : Status in class org.infinispan.server.hotrod.tx.table.TxState | From | To | |
| Change Attribute Type preparedCaches : Collection<TransactionContext<?,?>> to preparedCaches : List<TransactionContext<?,?>> in class org.infinispan.client.hotrod.impl.transaction.XaModeTransactionTable.XaAdapter | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter byteBuf : ByteBuf to buffer : ByteBuf in method public writeXid(xid Xid, buffer ByteBuf) : void in class org.infinispan.server.hotrod.transport.ExtendedByteBuf | From | To | |
| Rename Parameter context : PrepareTransactionDecodeContext to txCoordinator : PrepareCoordinator in method private checkExistingTxForPrepare(header HotRodHeader, txCoordinator PrepareCoordinator) : boolean in class org.infinispan.server.hotrod.TransactionRequestProcessor | From | To |