infinispan b8ffae1fd45a696a4c44ff76b48137d29bb9c702

b8ffae1fd45a696a4c44ff76b48137d29bb9c702

Files Diff

Added: 21
Removed: 1
Renamed: 0
Modified: 69

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	1
Move And Rename Method private getPathAsString(propertyPath List<String>) : String from class org.infinispan.objectfilter.impl.hql.predicate.FilterPredicateFactory to public asStringPath() : String from class org.infinispan.objectfilter.PropertyPath	From	To
Change Parameter Type	5
Change Parameter Type path : String to path : PropertyPath in method public SortFieldImpl(path PropertyPath, isAscending boolean) in class org.infinispan.objectfilter.impl.hql.FilterParsingResult.SortFieldImpl	From	To
Change Parameter Type q : org.infinispan.query.dsl.Query to q : Query in method private makeResponse(q Query) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl	From	To
Change Parameter Type attributePath : String to expression : Expression in method public AttributeCondition(queryFactory QueryFactory, expression Expression) in class org.infinispan.query.dsl.impl.AttributeCondition	From	To
Change Parameter Type propertyPath : PropertyPath to propertyPath : org.hibernate.hql.ast.origin.hql.resolve.path.PropertyPath in method protected addSortField(propertyPath org.hibernate.hql.ast.origin.hql.resolve.path.PropertyPath, collateName String, isAscending boolean) : void in class org.infinispan.objectfilter.impl.hql.FilterRendererDelegate	From	To
Change Parameter Type propertyPath : PropertyPath to propertyPath : org.hibernate.hql.ast.origin.hql.resolve.path.PropertyPath in method public setPropertyPath(propertyPath org.hibernate.hql.ast.origin.hql.resolve.path.PropertyPath) : void in class org.infinispan.objectfilter.impl.hql.FilterRendererDelegate	From	To
Move Method	2
Move Method private getFieldDescriptor(serCtx SerializationContext, type String, attributePath String) : FieldDescriptor from class org.infinispan.query.remote.QueryFacadeImpl to private getFieldDescriptor(serCtx SerializationContext, type String, attributePath String) : FieldDescriptor from class org.infinispan.query.remote.RemoteQueryEngine	From	To
Move Method private makeFilter(cache AdvancedCache<?,?>, isIndexed boolean, isCompatMode boolean, jpaQuery String) : JPAFilterAndConverter from class org.infinispan.query.remote.QueryFacadeImpl to protected makeFilter(jpaQuery String) : JPAFilterAndConverter from class org.infinispan.query.remote.RemoteQueryEngine	From	To
Move Attribute	1
Move Attribute private entityNamesResolver : EntityNamesResolver from class org.infinispan.query.dsl.embedded.impl.QueryEngine to private entityNamesResolver : EntityNamesResolver from class org.infinispan.objectfilter.impl.RowMatcher	From	To
Move Class	1
Move Class org.infinispan.query.remote.indexing.ProtobufIndexedFieldProvider moved to org.infinispan.query.remote.ProtobufIndexedFieldProvider	From	To
Change Variable Type	2
Change Variable Type projection : String to projection : Expression in method public visit(baseQueryBuilder BaseQueryBuilder<T>) : String in class org.infinispan.query.dsl.impl.JPAQueryGenerator	From	To
Change Variable Type results : List to results : List<Object> in method private listInternal() : List<Object> in class org.infinispan.query.dsl.embedded.impl.BaseEmbeddedQuery	From	To
Extract Method	9
Extract Method public orderBy(pathExpression Expression, sortOrder SortOrder) : QueryBuilder<T> extracted from public orderBy(attributePath String, sortOrder SortOrder) : QueryBuilder<T> in class org.infinispan.query.dsl.impl.BaseQueryBuilder	From	To
Extract Method protected makeProcessingChain() : LuceneProcessingChain extracted from private transformJpaToLucene(jpqlString String) : LuceneQueryParsingResult in class org.infinispan.query.dsl.embedded.impl.QueryEngine	From	To
Extract Method public having(expression Expression) : FilterConditionEndContext extracted from public having(attributePath String) : FilterConditionEndContext in class org.infinispan.query.dsl.impl.BaseQueryFactory	From	To
Extract Method protected makeTypeQuery(query Query, targetEntityName String) : Query extracted from public buildLuceneQuery(queryFactory QueryFactory, jpqlString String, startOffset long, maxResults int, additionalLuceneQuery Query) : LuceneQuery in class org.infinispan.query.dsl.embedded.impl.QueryEngine	From	To
Extract Method protected getBaseIterator() : Iterator<?> extracted from protected getIterator() : CloseableIterator<ObjectFilter.FilterResult> in class org.infinispan.query.dsl.embedded.impl.HybridQuery	From	To
Extract Method private buildQueryNoAggregations(queryFactory QueryFactory, jpqlString String, startOffset long, maxResults int, parsingResult FilterParsingResult<?>) : Query extracted from public buildQuery(queryFactory QueryFactory, jpqlString String, startOffset long, maxResults int) : Query in class org.infinispan.query.dsl.embedded.impl.QueryEngine	From	To
Extract Method public having(expression Expression) : FilterConditionEndContext extracted from public having(attributePath String) : FilterConditionEndContext in class org.infinispan.query.dsl.impl.BaseQueryBuilder	From	To
Extract Method public printTree(whereClause BooleanExpr) : String extracted from public printTree(entityTypeName String, query BooleanExpr, sortFields List<SortField>) : String in class org.infinispan.objectfilter.impl.syntax.JPATreePrinter	From	To
Extract Method public having(expression Expression) : FilterConditionEndContext extracted from public having(attributePath String) : FilterConditionEndContext in class org.infinispan.query.dsl.impl.IncompleteCondition	From	To
Rename Method	6
Rename Method protected getFilterCondition() : BaseCondition renamed to protected getWhereFilterCondition() : BaseCondition in class org.infinispan.query.dsl.impl.BaseQueryBuilder	From	To
Rename Method public getQuery() : BooleanExpr renamed to public getWhereClause() : BooleanExpr in class org.infinispan.objectfilter.impl.hql.FilterParsingResult	From	To
Rename Method public testIsNotNull() : void renamed to public testIsNotNull1() : void in class org.infinispan.objectfilter.test.AbstractMatcherTest	From	To
Rename Method public getMatchResult() : boolean renamed to public isMatching() : boolean in class org.infinispan.objectfilter.impl.predicateindex.FilterEvalContext	From	To
Rename Method public testIsNull() : void renamed to public testIsNull3() : void in class org.infinispan.all.embeddedquery.QueryDslConditionsTest	From	To
Rename Method public testIsNull() : void renamed to public testIsNull3() : void in class org.infinispan.query.dsl.embedded.QueryDslConditionsTest	From	To
Rename Variable	2
Rename Variable normalizedExpr : BooleanExpr to normalizedWhereClause : BooleanExpr in method private buildQueryNoAggregations(queryFactory QueryFactory, jpqlString String, startOffset long, maxResults int, parsingResult FilterParsingResult<?>) : Query in class org.infinispan.query.dsl.embedded.impl.QueryEngine	From	To
Rename Variable ready : boolean to isReady : boolean in method protected getIterator() : CloseableIterator<ObjectFilter.FilterResult> in class org.infinispan.query.dsl.embedded.impl.HybridQuery	From	To
Change Return Type	5
Change Return Type String to PropertyPath in method public getPath() : PropertyPath in class org.infinispan.objectfilter.SortField	From	To
Change Return Type List to List<Object> in method private listInternal() : List<Object> in class org.infinispan.query.dsl.embedded.impl.BaseEmbeddedQuery	From	To
Change Return Type String[] to Expression[] in method protected getProjection() : Expression[] in class org.infinispan.query.dsl.impl.BaseQueryBuilder	From	To
Change Return Type String to PropertyPath in method public getPath() : PropertyPath in class org.infinispan.objectfilter.impl.hql.FilterParsingResult.SortFieldImpl	From	To
Change Return Type String to Expression in method public getAttributePath() : Expression in class org.infinispan.query.dsl.impl.SortCriteria	From	To
Rename Attribute	9
Rename Attribute isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterRangePredicate	From	To
Rename Attribute isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterComparisonPredicate	From	To
Rename Attribute isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterIsNullPredicate	From	To
Rename Attribute isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterInPredicate	From	To
Rename Attribute attributePath : String to expression : Expression in class org.infinispan.query.dsl.impl.AttributeCondition	From	To
Rename Attribute projections : List<String> to projectedPaths : List<PropertyPath> in class org.infinispan.objectfilter.impl.hql.FilterParsingResult	From	To
Rename Attribute filter : BooleanExpr to whereFilter : BooleanExpr in class org.infinispan.objectfilter.impl.hql.FilterParsingResult	From	To
Rename Attribute isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterLikePredicate	From	To
Rename Attribute attributePath : String to pathExpression : Expression in class org.infinispan.query.dsl.impl.SortCriteria	From	To
Change Attribute Type	11
Change Attribute Type isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterRangePredicate	From	To
Change Attribute Type isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterComparisonPredicate	From	To
Change Attribute Type isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterInPredicate	From	To
Change Attribute Type projection : String[] to projection : Expression[] in class org.infinispan.query.dsl.impl.BaseQueryBuilder	From	To
Change Attribute Type isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterIsNullPredicate	From	To
Change Attribute Type projections : List<String> to projectedPaths : List<PropertyPath> in class org.infinispan.objectfilter.impl.hql.FilterParsingResult	From	To
Change Attribute Type attributePath : String to expression : Expression in class org.infinispan.query.dsl.impl.AttributeCondition	From	To
Change Attribute Type isRepeatedProperty : boolean to valueExpr : ValueExpr in class org.infinispan.objectfilter.impl.hql.predicate.FilterLikePredicate	From	To
Change Attribute Type attributePath : String to pathExpression : Expression in class org.infinispan.query.dsl.impl.SortCriteria	From	To
Change Attribute Type results : List to results : List<Object> in class org.infinispan.query.dsl.embedded.impl.BaseEmbeddedQuery	From	To
Change Attribute Type path : String to path : PropertyPath in class org.infinispan.objectfilter.impl.hql.FilterParsingResult.SortFieldImpl	From	To
Rename Parameter	6
Rename Parameter entityTypeName : String to fromEntityTypeName : String in method public printTree(fromEntityTypeName String, whereClause BooleanExpr, orderBy List<SortField>) : String in class org.infinispan.objectfilter.impl.syntax.JPATreePrinter	From	To
Rename Parameter sortFields : List<SortField> to orderBy : List<SortField> in method public printTree(fromEntityTypeName String, whereClause BooleanExpr, orderBy List<SortField>) : String in class org.infinispan.objectfilter.impl.syntax.JPATreePrinter	From	To
Rename Parameter attributePath : String to expression : Expression in method public AttributeCondition(queryFactory QueryFactory, expression Expression) in class org.infinispan.query.dsl.impl.AttributeCondition	From	To
Rename Parameter filter : BooleanExpr to whereFilter : BooleanExpr in method package FilterParsingResult(whereFilter BooleanExpr, havingFilter BooleanExpr, targetEntityName String, targetEntityMetadata TypeMetadata, projectedPaths List<PropertyPath>, groupBy List<PropertyPath>, sortFields List<SortField>) in class org.infinispan.objectfilter.impl.hql.FilterParsingResult	From	To
Rename Parameter query : BooleanExpr to whereClause : BooleanExpr in method public printTree(whereClause BooleanExpr) : String in class org.infinispan.objectfilter.impl.syntax.JPATreePrinter	From	To
Rename Parameter query : BooleanExpr to whereClause : BooleanExpr in method public printTree(fromEntityTypeName String, whereClause BooleanExpr, orderBy List<SortField>) : String in class org.infinispan.objectfilter.impl.syntax.JPATreePrinter	From	To

b8ffae1fd45a696a4c44ff76b48137d29bb9c702

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: