bd580e6254c1fc7c6cda4e43e4530b8229601fa4
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 59
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Merge Attribute | 1 | ||
Merge Attribute [dataContainer : InternalDataContainer<Object,Object>, persistenceManager : PersistenceManager, timeService : TimeService] to entryLoader : EntryLoader in class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Change Parameter Type | 4 | ||
Change Parameter Type listener : EvictionListener<K,InternalCacheEntry<K,V>> to listener : DefaultEvictionListener in method protected applyListener(caffeine Caffeine<K,InternalCacheEntry<K,V>>, listener DefaultEvictionListener, additionalWriter CacheWriter<K,InternalCacheEntry<K,V>>) : Caffeine<K,InternalCacheEntry<K,V>> in class org.infinispan.container.impl.AbstractInternalDataContainer | From | To | |
Change Parameter Type entry : InternalCacheEntry to entry : CacheEntry in method private doPassivate(key Object, entry CacheEntry) : CompletionStage<Boolean> in class org.infinispan.eviction.impl.PassivationManagerImpl | From | To | |
Change Parameter Type actual : CacheWriter to actual : CacheWriter<K,V> in method public DelegatingCacheWriter(actual CacheWriter<K,V>) in class org.infinispan.persistence.support.DelegatingCacheWriter | From | To | |
Change Parameter Type entry : MarshallableEntry to entry : MarshallableEntry<? extends K,? extends V> in method public write(entry MarshallableEntry<? extends K,? extends V>) : void in class org.infinispan.persistence.support.DelegatingCacheWriter | From | To | |
Change Return Type | 16 | ||
Change Return Type void to CompletionStage<Void> in method private commitEntry(entry CacheEntry, segment int, ctx InvocationContext) : CompletionStage<Void> in class org.infinispan.statetransfer.CommitManager | From | To | |
Change Return Type void to CompletionStage<Void> in method public commit(entry CacheEntry, operation Flag, segment int, l1Only boolean, ctx InvocationContext) : CompletionStage<Void> in class org.infinispan.statetransfer.CommitManager | From | To | |
Change Return Type void to CompletionStage<Void> in method public evict(segment int, key K) : CompletionStage<Void> in class org.infinispan.container.impl.InternalDataContainerAdapter | From | To | |
Change Return Type boolean to void in method private isEntryInStore(key String, expectPresent boolean) : void in class org.infinispan.eviction.impl.EvictionWithPassivationTest | From | To | |
Change Return Type void to CompletionStage<Void> in method public evict(segment int, key WrappedBytes) : CompletionStage<Void> in class org.infinispan.container.offheap.BoundedOffHeapDataContainer | From | To | |
Change Return Type CompletionStage<MarshallableEntry> to CompletionStage<MarshallableEntry<K,V>> in method public loadFromAllStores(key Object, segment int, localInvocation boolean, includeStores boolean) : CompletionStage<MarshallableEntry<K,V>> in class org.infinispan.persistence.manager.PersistenceManagerImpl | From | To | |
Change Return Type void to CompletionStage<Void> in method public evict(segment int, key K) : CompletionStage<Void> in class org.infinispan.container.impl.InternalDataContainer | From | To | |
Change Return Type EntryVersionsMap to CompletionStage<EntryVersionsMap> in method private totalOrderCreateNewVersionsAndCheckForWriteSkews(versionGenerator VersionGenerator, context TxInvocationContext, prepareCommand VersionedPrepareCommand) : CompletionStage<EntryVersionsMap> in class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Change Return Type void to CompletionStage<Void> in method public evict(segment int, key K) : CompletionStage<Void> in class org.infinispan.container.impl.AbstractInternalDataContainer | From | To | |
Change Return Type EntryVersionsMap to CompletionStage<EntryVersionsMap> in method public performWriteSkewCheckAndReturnNewVersions(prepareCommand VersionedPrepareCommand, entryLoader EntryLoader, versionGenerator VersionGenerator, context TxInvocationContext, ksl KeySpecificLogic, keyPartitioner KeyPartitioner) : CompletionStage<EntryVersionsMap> in class org.infinispan.transaction.impl.WriteSkewHelper | From | To | |
Change Return Type EntryVersionsMap to CompletionStage<EntryVersionsMap> in method private createNewVersionsMap(versionGenerator VersionGenerator, context TxInvocationContext, prepareCommand VersionedPrepareCommand) : CompletionStage<EntryVersionsMap> in class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Change Return Type EntryVersionsMap to CompletionStage<EntryVersionsMap> in method public performTotalOrderWriteSkewCheckAndReturnNewVersions(prepareCommand VersionedPrepareCommand, entryLoader EntryLoader, versionGenerator VersionGenerator, context TxInvocationContext, ksl KeySpecificLogic, keyPartitioner KeyPartitioner) : CompletionStage<EntryVersionsMap> in class org.infinispan.transaction.impl.WriteSkewHelper | From | To | |
Change Return Type void to CompletionStage<Void> in method public evict(segment int, key K) : CompletionStage<Void> in class org.infinispan.container.impl.AbstractDelegatingInternalDataContainer | From | To | |
Change Return Type boolean to CompletionStage<Boolean> in method public performWriteSkewCheck(entryLoader EntryLoader, segment int, ctx TxInvocationContext, versionSeen EntryVersion, versionGenerator VersionGenerator) : CompletionStage<Boolean> in class org.infinispan.container.entries.VersionedRepeatableReadEntry | From | To | |
Change Return Type EntryVersionsMap to CompletionStage<EntryVersionsMap> in method private clusteredCreateNewVersionsAndCheckForWriteSkews(versionGenerator VersionGenerator, context TxInvocationContext, prepareCommand VersionedPrepareCommand) : CompletionStage<EntryVersionsMap> in class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Change Return Type void to CompletionStage<Void> in method public commit(segment int, container InternalDataContainer) : CompletionStage<Void> in class org.infinispan.container.entries.ReadCommittedEntry | From | To | |
Move Attribute | 4 | ||
Move Attribute private trace : boolean from class org.infinispan.interceptors.impl.PassivationClusteredCacheLoaderInterceptor to private trace : boolean from class org.infinispan.interceptors.locking.OrderedClusteringDependentLogic | From | To | |
Move Attribute private trace : boolean from class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic to private trace : boolean from class org.infinispan.persistence.manager.PassivationPersistenceManager | From | To | |
Move Attribute private log : Log from class org.infinispan.interceptors.impl.PassivationClusteredCacheLoaderInterceptor to private log : Log from class org.infinispan.interceptors.locking.OrderedClusteringDependentLogic | From | To | |
Move Attribute private log : Log from class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic to private log : Log from class org.infinispan.persistence.manager.PassivationPersistenceManager | From | To | |
Extract Class | 2 | ||
Extract Class org.infinispan.persistence.manager.PassivationPersistenceManager from class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Extract Class org.infinispan.interceptors.locking.OrderedClusteringDependentLogic from class org.infinispan.interceptors.impl.PassivationClusteredCacheLoaderInterceptor | From | To | |
Change Variable Type | 1 | ||
Change Variable Type uv : EntryVersionsMap to uv : CompletionStage<EntryVersionsMap> in method private clusteredCreateNewVersionsAndCheckForWriteSkews(versionGenerator VersionGenerator, context TxInvocationContext, prepareCommand VersionedPrepareCommand) : CompletionStage<EntryVersionsMap> in class org.infinispan.interceptors.locking.ClusteringDependentLogic.AbstractClusteringDependentLogic | From | To | |
Extract Variable | 2 | ||
Extract Variable action : Consumer<? super InternalCacheEntry<K,V>> in method protected loadInContext(ctx InvocationContext, key Object, cmd FlagAffectedCommand) : CompletionStage<Void> from class org.infinispan.interceptors.impl.CacheLoaderInterceptor | From | To | |
Extract Variable gcb : GlobalConfigurationBuilder in method public configureCacheManager(passivation boolean, preload boolean, eviction boolean) : DefaultCacheManager from class org.infinispan.persistence.jdbc.stringbased.AbstractStringBasedCacheStore | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type actual : CacheWriter to actual : CacheWriter<K,V> in class org.infinispan.persistence.support.DelegatingCacheWriter | From | To | |
Change Attribute Type activations : AtomicLong to activations : LongAdder in class org.infinispan.eviction.impl.ActivationManagerImpl | From | To | |
Extract Method | 8 | ||
Extract Method private getCurrentEntryVersion(entryLoader EntryLoader, segment int, ctx TxInvocationContext, versionGenerator VersionGenerator) : CompletionStage<EntryVersion> extracted from public performWriteSkewCheck(container DataContainer, segment int, persistenceManager PersistenceManager, ctx TxInvocationContext, versionSeen EntryVersion, versionGenerator VersionGenerator, timeService TimeService) : boolean in class org.infinispan.container.entries.VersionedRepeatableReadEntry | From | To | |
Extract Method private commitOperation(entry RepeatableReadEntry, wasCommitted Predicate<RepeatableReadEntry>, ctx InvocationContext, command VisitableCommand) : CompletionStage<Void> extracted from private commitSingleEntryIfNewer(entry RepeatableReadEntry, ctx InvocationContext, command VisitableCommand) : CompletionStage<Void> in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
Extract Method private getActualPersistenceManager(cache Cache<?,?>) : PersistenceManagerImpl extracted from public getFirstWriter(cache Cache<K,V>) : T in class org.infinispan.test.TestingUtil | From | To | |
Extract Method private commitOperation(entry RepeatableReadEntry, wasCommitted Predicate<RepeatableReadEntry>, ctx InvocationContext, command VisitableCommand) : CompletionStage<Void> extracted from private commitSingleEntryIfNoChange(entry RepeatableReadEntry, ctx InvocationContext, command VisitableCommand) : CompletionStage<Void> in class org.infinispan.interceptors.distribution.ScatteredDistributionInterceptor | From | To | |
Extract Method private getActualPersistenceManager(cache Cache<?,?>) : PersistenceManagerImpl extracted from public getFirstLoader(cache Cache<K,V>) : T in class org.infinispan.test.TestingUtil | From | To | |
Extract Method public loadAndStoreInDataContainer(ctx InvocationContext, key Object, segment int, cmd FlagAffectedCommand) : CompletionStage<InternalCacheEntry<K,V>> extracted from protected loadInContext(ctx InvocationContext, key Object, cmd FlagAffectedCommand) : CompletionStage<Void> in class org.infinispan.interceptors.impl.CacheLoaderInterceptor | From | To | |
Extract Method private skewed(prevVersion EntryVersion, versionSeen EntryVersion, versionGenerator VersionGenerator) : boolean extracted from public performWriteSkewCheck(container DataContainer, segment int, persistenceManager PersistenceManager, ctx TxInvocationContext, versionSeen EntryVersion, versionGenerator VersionGenerator, timeService TimeService) : boolean in class org.infinispan.container.entries.VersionedRepeatableReadEntry | From | To | |
Extract Method private getActualPersistenceManager(cache Cache<?,?>) : PersistenceManagerImpl extracted from public getFirstTxWriter(cache Cache<K,V>) : T in class org.infinispan.test.TestingUtil | From | To |