infinispan c4c0bd2ce662437d7b3cf99b5240a82db4037fa3

c4c0bd2ce662437d7b3cf99b5240a82db4037fa3

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 30

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private create(command ReplicableCommand, reply Reply, preserveOrder boolean) : Runnable renamed to private invokeReplicableCommand(command ReplicableCommand, reply Reply, preserveOrder boolean) : void in class org.infinispan.remoting.inboundhandler.GlobalInboundInvocationHandler	From	To
Change Parameter Type	31
Change Parameter Type id : CommandInvocationId to id : long in method public buildExceptionAckCommand(id long, throwable Throwable, topologyId int) : ExceptionAckCommand in class org.infinispan.util.mocks.ControlledCommandFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public backupAck(id long, from Address, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildPrimaryMultiKeyAckCommand(id long, topologyId int) : PrimaryMultiKeyAckCommand in class org.infinispan.util.mocks.ControlledCommandFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupAckCommand(id long, topologyId int) : BackupAckCommand in class org.infinispan.commands.CommandsFactoryImpl	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildExceptionAckCommand(id long, throwable Throwable, topologyId int) : ExceptionAckCommand in class org.infinispan.commands.CommandsFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupMultiKeyAckCommand(id long, segment int, topologyId int) : BackupMultiKeyAckCommand in class org.infinispan.commands.CommandsFactory	From	To
Change Parameter Type commandInvocationId : CommandInvocationId to id : long in method public BackupAckCommand(cacheName ByteString, id long, topologyId int) in class org.infinispan.commands.write.BackupAckCommand	From	To
Change Parameter Type id : CommandInvocationId to id : long in method package Collector(id long, topologyId int) in class org.infinispan.util.concurrent.CommandAckCollector.Collector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupAckCommand(id long, topologyId int) : BackupAckCommand in class org.infinispan.commands.CommandsFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public dispose(id long) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public multiKeyPrimaryAck(id long, from Address, returnValue Map<Object,Object>, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public completeExceptionally(id long, throwable Throwable, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type commandInvocationId : CommandInvocationId to id : long in method public PrimaryMultiKeyAckCommand(cacheName ByteString, id long, topologyId int) in class org.infinispan.commands.write.PrimaryMultiKeyAckCommand	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildExceptionAckCommand(id long, throwable Throwable, topologyId int) : ExceptionAckCommand in class org.infinispan.commands.CommandsFactoryImpl	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupMultiKeyAckCommand(id long, segment int, topologyId int) : BackupMultiKeyAckCommand in class org.infinispan.commands.CommandsFactoryImpl	From	To
Change Parameter Type id : CommandInvocationId to id : long in method private SingleKeyCollector(id long, owners Collection<Address>, topologyId int) in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupAckCommand(id long, topologyId int) : BackupAckCommand in class org.infinispan.util.mocks.ControlledCommandFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildPrimaryMultiKeyAckCommand(id long, topologyId int) : PrimaryMultiKeyAckCommand in class org.infinispan.commands.CommandsFactoryImpl	From	To
Change Parameter Type id : CommandInvocationId to id : long in method private createTimeoutException(timeoutNanoSeconds long, id long) : TimeoutException in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method package MultiKeyCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildBackupMultiKeyAckCommand(id long, segment int, topologyId int) : BackupMultiKeyAckCommand in class org.infinispan.util.mocks.ControlledCommandFactory	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public primaryAck(id long, returnValue Object, success boolean, from Address, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public create(id long, owners Collection<Address>, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public buildPrimaryMultiKeyAckCommand(id long, topologyId int) : PrimaryMultiKeyAckCommand in class org.infinispan.commands.CommandsFactory	From	To
Change Parameter Type commandInvocationId : CommandInvocationId to id : long in method public BackupMultiKeyAckCommand(cacheName ByteString, id long, segment int, topologyId int) in class org.infinispan.commands.write.BackupMultiKeyAckCommand	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public getCollectorCompletableFuture(id long) : CompletableFuture<T> in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public hasPendingBackupAcks(id long) : boolean in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public multiKeyBackupAck(id long, from Address, segment int, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public createMultiKeyCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Parameter Type commandInvocationId : CommandInvocationId to id : long in method public ExceptionAckCommand(cacheName ByteString, id long, throwable Throwable, topologyId int) in class org.infinispan.commands.write.ExceptionAckCommand	From	To
Change Parameter Type id : CommandInvocationId to id : long in method public getCollectorCompletableFutureToWait(id long) : CompletableFuture<T> in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Inline Method	1
Inline Method private logCommandSequence(id CommandInvocationId, segment int, sequence long) : void inlined to private primaryOwnerWrite(context InvocationContext, command DataWriteCommand, distributionInfo DistributionInfo) : Object in class org.infinispan.interceptors.distribution.TriangleDistributionInterceptor	From	To
Change Return Type	3
Change Return Type Runnable to void in method private invokeReplicableCommand(command ReplicableCommand, reply Reply, preserveOrder boolean) : void in class org.infinispan.remoting.inboundhandler.GlobalInboundInvocationHandler	From	To
Change Return Type Object to void in method private localWriteInvocation(context InvocationContext, command DataWriteCommand, distributionInfo DistributionInfo) : void in class org.infinispan.interceptors.distribution.TriangleDistributionInterceptor	From	To
Change Return Type List<CommandInvocationId> to List<Long> in method public getPendingCommands() : List<Long> in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Rename Attribute	5
Rename Attribute commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.BackupAckCommand	From	To
Rename Attribute commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.BackupMultiKeyAckCommand	From	To
Rename Attribute commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.ExceptionAckCommand	From	To
Rename Attribute commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.PrimaryAckCommand	From	To
Rename Attribute commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.PrimaryMultiKeyAckCommand	From	To
Change Variable Type	3
Change Variable Type pendingIds : List<CommandInvocationId> to pendingIds : List<Long> in method protected assertL1PutWithConcurrentUpdate(nonOwnerCache Cache<Object,String>, ownerCache Cache<Object,String>, replace boolean, key Object, originalValue String, nonOwnerValue String, updateValue String) : void in class org.infinispan.distribution.DistSyncL1FuncTest	From	To
Change Variable Type pendingCommands : List<CommandInvocationId> to pendingCommands : List<Long> in method protected awaitForBackups(cache Cache<?,?>) : void in class org.infinispan.notifications.cachelistener.cluster.AbstractClusterListenerNonTxTest	From	To
Change Variable Type pendingIds : List<CommandInvocationId> to pendingIds : List<Long> in method public testNonOwnerRemovesValueFromL1ProperlyOnWrite() : void in class org.infinispan.distribution.DistSyncL1FuncTest	From	To
Extract Variable	2
Extract Variable collector : SingleKeyCollector in method public create(id long, owners Collection<Address>, topologyId int) : void from class org.infinispan.util.concurrent.CommandAckCollector	From	To
Extract Variable collector : MultiKeyCollector in method public createMultiKeyCollector(id long, primary Collection<Address>, backups Map<Address,Collection<Integer>>, topologyId int) : void from class org.infinispan.util.concurrent.CommandAckCollector	From	To
Extract Method	11
Extract Method package isWrongTopologyOrIsDone(topologyId int) : boolean extracted from package completeExceptionally(throwable Throwable, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector.Collector	From	To
Extract Method private asyncRequestOptions(rsvp boolean, deliverOrder DeliverOrder) : RequestOptions extracted from public sendTo(destination Address, rpcCommand ReplicableCommand, deliverOrder DeliverOrder) : void in class org.infinispan.remoting.transport.jgroups.JGroupsTransport	From	To
Extract Method private haveAllBackupsLeft(members Collection<Address>) : boolean extracted from public onMembersChange(members Collection<Address>) : void in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector	From	To
Extract Method private removeBackupOwner(member Address) : boolean extracted from package backupAck(topologyId int, from Address) : void in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector	From	To
Extract Method private handleReplicableCommand(origin Address, command ReplicableCommand, reply Reply, order DeliverOrder) : void extracted from public handleFromCluster(origin Address, command ReplicableCommand, reply Reply, order DeliverOrder) : void in class org.infinispan.remoting.inboundhandler.GlobalInboundInvocationHandler	From	To
Extract Method private hasSomeBackupLeft(members Collection<Address>) : boolean extracted from public onMembersChange(members Collection<Address>) : void in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Extract Method private hasSomePrimaryLeft(members Collection<Address>) : boolean extracted from public onMembersChange(members Collection<Address>) : void in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Extract Method private checkPrimaryAck(returnValue Object, from Address) : boolean extracted from package primaryAck(topologyId int, returnValue Object, success boolean, from Address) : void in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector	From	To
Extract Method private backupMultiKeyAckCommand(input ObjectInput) : BackupMultiKeyAckCommand extracted from public readObject(input ObjectInput) : CacheRpcCommand in class org.infinispan.marshall.exts.TriangleAckExternalizer	From	To
Extract Method private asyncRequestOptions(rsvp boolean, deliverOrder DeliverOrder) : RequestOptions extracted from private sendToAll(rpcCommand ReplicableCommand, deliverOrder DeliverOrder) : void in class org.infinispan.remoting.transport.jgroups.JGroupsTransport	From	To
Extract Method private asyncRequestOptions(rsvp boolean, deliverOrder DeliverOrder) : RequestOptions extracted from public sendToMany(destinations Collection<Address>, rpcCommand ReplicableCommand, deliverOrder DeliverOrder) : void in class org.infinispan.remoting.transport.jgroups.JGroupsTransport	From	To
Change Attribute Type	11
Change Attribute Type commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.BackupAckCommand	From	To
Change Attribute Type commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.BackupMultiKeyAckCommand	From	To
Change Attribute Type commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.ExceptionAckCommand	From	To
Change Attribute Type commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.PrimaryAckCommand	From	To
Change Attribute Type collectorMap : ConcurrentHashMap<CommandInvocationId,Collector<?>> to collectorMap : ConcurrentHashMap<Long,Collector<?>> in class org.infinispan.util.concurrent.CommandAckCollector	From	To
Change Attribute Type commandInvocationId : CommandInvocationId to id : long in class org.infinispan.commands.write.PrimaryMultiKeyAckCommand	From	To
Change Attribute Type returnValue : Map<Object,Object> to returnValue : HashMap<Object,Object> in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Change Attribute Type id : CommandInvocationId to id : long in class org.infinispan.util.concurrent.CommandAckCollector.Collector	From	To
Change Attribute Type owners : Collection<Address> to owners : HashSet<Address> in class org.infinispan.util.concurrent.CommandAckCollector.SingleKeyCollector	From	To
Change Attribute Type primary : Collection<Address> to primary : HashSet<Address> in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Change Attribute Type backups : Map<Address,Collection<Integer>> to backups : HashMap<Address,Collection<Integer>> in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector	From	To
Extract And Move Method	3
Extract And Move Method package isWrongTopologyOrIsDone(topologyId int) : boolean extracted from package backupAck(from Address, segment int, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector & moved to class org.infinispan.util.concurrent.CommandAckCollector.Collector	From	To
Extract And Move Method package isWrongTopologyOrIsDone(topologyId int) : boolean extracted from package primaryAck(returnValue Map<Object,Object>, from Address, topologyId int) : void in class org.infinispan.util.concurrent.CommandAckCollector.MultiKeyCollector & moved to class org.infinispan.util.concurrent.CommandAckCollector.Collector	From	To
Extract And Move Method public create(id long, returnValue Object, primaryOwner Address, backupOwners Collection<Address>, topologyId int) : void extracted from private primaryOwnerWrite(context InvocationContext, command DataWriteCommand, distributionInfo DistributionInfo) : Object in class org.infinispan.interceptors.distribution.TriangleDistributionInterceptor & moved to class org.infinispan.util.concurrent.CommandAckCollector	From	To
Rename Parameter	6
Rename Parameter commandInvocationId : CommandInvocationId to id : long in method public PrimaryMultiKeyAckCommand(cacheName ByteString, id long, topologyId int) in class org.infinispan.commands.write.PrimaryMultiKeyAckCommand	From	To
Rename Parameter ctx : InvocationContext to ignored : InvocationContext in method private onPutMapNoLocalEntriesException(ignored InvocationContext, rCommand VisitableCommand, t Throwable) : Object in class org.infinispan.interceptors.distribution.TriangleDistributionInterceptor	From	To
Rename Parameter commandInvocationId : CommandInvocationId to id : long in method public BackupAckCommand(cacheName ByteString, id long, topologyId int) in class org.infinispan.commands.write.BackupAckCommand	From	To
Rename Parameter ctx : InvocationContext to ignored : InvocationContext in method private afterPutMapCommand(ignored InvocationContext, rCommand VisitableCommand, rv Object, t Throwable) : void in class org.infinispan.interceptors.distribution.TriangleDistributionInterceptor	From	To
Rename Parameter commandInvocationId : CommandInvocationId to id : long in method public BackupMultiKeyAckCommand(cacheName ByteString, id long, segment int, topologyId int) in class org.infinispan.commands.write.BackupMultiKeyAckCommand	From	To
Rename Parameter commandInvocationId : CommandInvocationId to id : long in method public ExceptionAckCommand(cacheName ByteString, id long, throwable Throwable, topologyId int) in class org.infinispan.commands.write.ExceptionAckCommand	From	To

c4c0bd2ce662437d7b3cf99b5240a82db4037fa3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: