ee84affcbc5e985533326aea1e7b7096a3a3e946
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 26
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Merge Attribute | 1 | ||
Merge Attribute [searchManager : SearchManager, queryCache : QueryCache, entityNamesResolver : EntityNamesResolver] to queryEngine : QueryEngine in class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryFactory | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method private parse(jpqlString String) : LuceneQueryParsingResult from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryBuilder to private transformJpaToLucene(jpqlString String) : LuceneQueryParsingResult from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Change Parameter Type | 2 | ||
Change Parameter Type cache : AdvancedCache<?,?> to queryEngine : QueryEngine in method public EmbeddedQueryFactory(queryEngine QueryEngine) in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory | From | To | |
Change Parameter Type cache : AdvancedCache<?,?> to queryEngine : QueryEngine in method public EmbeddedQueryBuilder(queryFactory EmbeddedQueryFactory, queryEngine QueryEngine, rootType String) in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder | From | To | |
Move Attribute | 9 | ||
Move Attribute private searchManager : SearchManager from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryBuilder to private searchManager : SearchManager from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private entityNamesResolver : EntityNamesResolver from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryFactory to private entityNamesResolver : EntityNamesResolver from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private queryCache : QueryCache from class org.infinispan.query.impl.SearchManagerImpl to private queryCache : QueryCache from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private entityNamesResolver : EntityNamesResolver from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryBuilder to private entityNamesResolver : EntityNamesResolver from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private cache : AdvancedCache<?,?> from class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory to private cache : AdvancedCache<?,?> from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private searchManager : SearchManager from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryFactory to private searchManager : SearchManager from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private cache : AdvancedCache<?,?> from class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder to private cache : AdvancedCache<?,?> from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private queryCache : QueryCache from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryBuilder to private queryCache : QueryCache from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Move Attribute private queryCache : QueryCache from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryFactory to private queryCache : QueryCache from class org.infinispan.query.dsl.embedded.impl.QueryEngine | From | To | |
Extract Class | 5 | ||
Extract Class org.infinispan.query.dsl.embedded.impl.QueryEngine from class org.infinispan.query.impl.SearchManagerImpl | From | To | |
Extract Class org.infinispan.query.dsl.embedded.impl.QueryEngine from class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory | From | To | |
Extract Class org.infinispan.query.dsl.embedded.impl.QueryEngine from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryFactory | From | To | |
Extract Class org.infinispan.query.dsl.embedded.impl.QueryEngine from class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder | From | To | |
Extract Class org.infinispan.query.dsl.embedded.impl.QueryEngine from class org.infinispan.query.dsl.embedded.impl.EmbeddedLuceneQueryBuilder | From | To | |
Rename Class | 1 | ||
Rename Class org.infinispan.query.dsl.embedded.impl.JPAFilterAndConverter.FilterAndConverterExternalizer renamed to org.infinispan.query.dsl.embedded.impl.JPAFilterAndConverter.JPAFilterAndConverterExternalizer | From | To | |
Change Variable Type | 1 | ||
Change Variable Type matcherImplClass : Class<? extends Matcher> to isIndexed : boolean in method private executeNonIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Extract Variable | 3 | ||
Extract Variable serCtx : SerializationContext in method protected initProtoSchema(remoteCacheManager RemoteCacheManager) : void from class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest | From | To | |
Extract Variable isCompatMode : boolean in method private executeIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse from class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Extract Variable advancedCache : AdvancedCache<?,?> in method public getSearchManager(cache Cache<?,?>) : SearchManager from class org.infinispan.query.Search | From | To | |
Inline Variable | 1 | ||
Inline Variable cacheConfiguration : Configuration in method public getQueryFactory(cache Cache<?,?>) : QueryFactory from class org.infinispan.query.Search | From | To | |
Extract Method | 3 | ||
Extract Method private makeResponse(isCompatMode boolean, serCtx SerializationContext, list List<?>, projSize int, totalResults long, numResults int) : QueryResponse extracted from private executeIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Extract Method private makeResponse(isCompatMode boolean, serCtx SerializationContext, list List<?>, projSize int, totalResults long, numResults int) : QueryResponse extracted from private executeNonIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Extract Method protected initProtoSchema(remoteCacheManager RemoteCacheManager) : void extracted from protected createCacheManagers() : void in class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest | From | To | |
Rename Method | 3 | ||
Rename Method private createRemoteIndexingInterceptor(cr ComponentRegistry, cfg Configuration) : void renamed to private createRemoteValueWrapperInterceptor(cr ComponentRegistry, cfg Configuration) : void in class org.infinispan.query.remote.LifecycleManager | From | To | |
Rename Method public testEqNonIndexed() : void renamed to public testEqNonIndexedField() : void in class org.infinispan.all.embeddedquery.QueryDslConditionsTest | From | To | |
Rename Method public testEqNonIndexed() : void renamed to public testEqNonIndexedField() : void in class org.infinispan.query.dsl.embedded.QueryDslConditionsTest | From | To | |
Pull Up Method | 6 | ||
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.query.dsl.embedded.QueryDslConditionsTest | From | To | |
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.client.hotrod.query.RemoteNonIndexedQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.all.embeddedquery.QueryDslConditionsTest | From | To | |
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.query.dsl.embedded.NonIndexedQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.all.embeddedquery.QueryDslConditionsTest | From | To | |
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.all.embeddedquery.QueryDslConditionsTest | From | To | |
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.query.dsl.embedded.NonIndexedQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.query.dsl.embedded.QueryDslConditionsTest | From | To | |
Pull Up Method public testEqNonIndexed() : void from class org.infinispan.client.hotrod.query.RemoteNonIndexedQueryDslConditionsTest to public testEqNonIndexedType() : void from class org.infinispan.query.dsl.embedded.QueryDslConditionsTest | From | To | |
Rename Variable | 2 | ||
Rename Variable compatMode : boolean to isCompatMode : boolean in method private executeNonIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Rename Variable matcherImplClass : Class<? extends Matcher> to isIndexed : boolean in method private executeNonIndexedQuery(cache AdvancedCache<byte[],byte[]>, cacheConfiguration Configuration, serCtx SerializationContext, request QueryRequest) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable compatMode : boolean to isCompatMode : boolean in method private makeResponse(isCompatMode boolean, serCtx SerializationContext, list List<?>, projSize int, totalResults long, numResults int) : QueryResponse in class org.infinispan.query.remote.QueryFacadeImpl | From | To | |
Rename Attribute | 2 | ||
Rename Attribute cache : AdvancedCache<?,?> to queryEngine : QueryEngine in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder | From | To | |
Rename Attribute cache : AdvancedCache<?,?> to queryEngine : QueryEngine in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory | From | To | |
Change Attribute Type | 4 | ||
Change Attribute Type ENTRY_LIFESPAN : int to ENTRY_LIFESPAN : long in class org.infinispan.query.dsl.embedded.impl.QueryCache | From | To | |
Change Attribute Type cache : AdvancedCache<?,?> to queryEngine : QueryEngine in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder | From | To | |
Change Attribute Type MAX_ENTRIES : int to MAX_ENTRIES : long in class org.infinispan.query.dsl.embedded.impl.QueryCache | From | To | |
Change Attribute Type cache : AdvancedCache<?,?> to queryEngine : QueryEngine in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method protected initProtoSchema(remoteCacheManager RemoteCacheManager) : void extracted from protected createCacheManagers() : void in class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsIspnDirTest & moved to class org.infinispan.client.hotrod.query.RemoteQueryDslConditionsTest | From | To | |
Rename Parameter | 2 | ||
Rename Parameter cache : AdvancedCache<?,?> to queryEngine : QueryEngine in method public EmbeddedQueryFactory(queryEngine QueryEngine) in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryFactory | From | To | |
Rename Parameter cache : AdvancedCache<?,?> to queryEngine : QueryEngine in method public EmbeddedQueryBuilder(queryFactory EmbeddedQueryFactory, queryEngine QueryEngine, rootType String) in class org.infinispan.query.dsl.embedded.impl.EmbeddedQueryBuilder | From | To |