04e605ae0668825fe3ab54ea8977b0cb35c0d008
Files Diff
- Added: 6
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private writeLong(os OutputStream, i long) : long renamed to package writeLongAsUint32(os OutputStream, i long) : long in class java.util.zip.ZipOutputStream | From | To | |
| Rename Method private writeShort(os OutputStream, i int) : int renamed to package writeIntAsUint16(os OutputStream, i int) : int in class java.util.zip.ZipOutputStream | From | To | |
| Pull Up Method | 14 | ||
| Pull Up Method public test_NUL_in_filename() : void from class libcore.java.util.zip.ZipFileTest to public test_NUL_in_filename() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testInflatingStreamsRequiringZipRefill() : void from class libcore.java.util.zip.ZipFileTest to public testInflatingStreamsRequiringZipRefill() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method private makeString(count int, ch String) : String from class libcore.java.util.zip.ZipFileTest to private makeString(count int, ch String) : String from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testDuplicateEntries() : void from class libcore.java.util.zip.ZipFileTest to public testDuplicateEntries() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testStoredEntrySize() : void from class libcore.java.util.zip.ZipFileTest to public testStoredEntrySize() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method private createTemporaryZipFile() : File from class libcore.java.util.zip.ZipFileTest to package createTemporaryZipFile() : File from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method private writeBytes(f File, bytes byte[]) : void from class libcore.java.util.zip.ZipFileTest to private writeBytes(f File, bytes byte[]) : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method private createZipOutputStream(f File) : ZipOutputStream from class libcore.java.util.zip.ZipFileTest to private createZipOutputStream(f File) : ZipOutputStream from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public test_getComment_unset() : void from class libcore.java.util.zip.ZipFileTest to public test_getComment_unset() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testComments() : void from class libcore.java.util.zip.ZipFileTest to public testComments() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testCrc() : void from class libcore.java.util.zip.ZipFileTest to public testCrc() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testSTORED() : void from class libcore.java.util.zip.ZipFileTest to public testSTORED() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method public testZipFileWithLotsOfEntries() : void from class libcore.java.util.zip.ZipFileTest to public testZipFileWithLotsOfEntries() : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Pull Up Method private replaceBytes(buffer byte[], original byte[], replacement byte[]) : void from class libcore.java.util.zip.ZipFileTest to private replaceBytes(buffer byte[], original byte[], replacement byte[]) : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private createZipFile(entryCount int, entrySize int) : File from class libcore.java.util.zip.ZipFileTest to protected writeEntries(out ZipOutputStream, entryCount int, entrySize long, setEntrySize boolean) : void from class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type out : int to out : long in method private readAndVerifyDataDescriptor(inB long, out long, isZip64 boolean) : void in class java.util.zip.ZipInputStream | From | To | |
| Change Parameter Type entrySize : int to entrySize : long in method protected writeEntries(out ZipOutputStream, entryCount int, entrySize long, setEntrySize boolean) : void in class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Change Parameter Type inB : int to inB : long in method private readAndVerifyDataDescriptor(inB long, out long, isZip64 boolean) : void in class java.util.zip.ZipInputStream | From | To | |
| Rename Variable | 1 | ||
| Rename Variable cdirSize : int to cdirEntriesSize : int in method public finish() : void in class java.util.zip.ZipOutputStream | From | To | |
| Change Return Type | 1 | ||
| Change Return Type File to void in method protected writeEntries(out ZipOutputStream, entryCount int, entrySize long, setEntrySize boolean) : void in class libcore.java.util.zip.AbstractZipFileTest | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable newCommentBytes : byte[] to bytes : byte[] in method private checkSizeIsWithinShort(property String, bytes byte[]) : void in class java.util.zip.ZipOutputStream | From | To | |
| Parameterize Variable nameLength : int to byteLength : int in method private readString(byteLength int) : String in class java.util.zip.ZipInputStream | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass libcore.java.util.zip.AbstractZipFileTest from classes [libcore.java.util.zip.ZipFileTest] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute nameBuf : byte[] to stringBytesBuf : byte[] in class java.util.zip.ZipInputStream | From | To | |
| Rename Attribute charBuf : char[] to stringCharBuf : char[] in class java.util.zip.ZipInputStream | From | To | |
| Rename Attribute nameLength : int to dataOffset : long in class java.util.zip.ZipEntry | From | To | |
| Extract Variable | 1 | ||
| Extract Variable charset : Charset in method package ZipEntry(cdeHdrBuf byte[], cdStream InputStream, defaultCharset Charset, isZip64 boolean) from class java.util.zip.ZipEntry | From | To | |
| Extract Method | 3 | ||
| Extract Method private parseEocdRecord(raf RandomAccessFile, offset long, isZip64 boolean) : EocdRecord extracted from private readCentralDir() : void in class java.util.zip.ZipFile | From | To | |
| Extract Method private checkSizeIsWithinShort(property String, bytes byte[]) : void extracted from public setComment(comment String) : void in class java.util.zip.ZipOutputStream | From | To | |
| Extract Method private readString(byteLength int) : String extracted from public getNextEntry() : ZipEntry in class java.util.zip.ZipInputStream | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type nameLength : int to dataOffset : long in class java.util.zip.ZipEntry | From | To | |
| Change Attribute Type offset : int to offset : long in class java.util.zip.ZipOutputStream | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter in : InputStream to cdStream : InputStream in method package ZipEntry(cdeHdrBuf byte[], cdStream InputStream, defaultCharset Charset, isZip64 boolean) in class java.util.zip.ZipEntry | From | To | |
| Rename Parameter hdrBuf : byte[] to cdeHdrBuf : byte[] in method package ZipEntry(cdeHdrBuf byte[], cdStream InputStream, defaultCharset Charset, isZip64 boolean) in class java.util.zip.ZipEntry | From | To |