157be0db425f59e3751ea4ebdcefe3cf4daf7ec2
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method protected doAuth(userid String, passwd String, session ImapSession, tag String, command ImapCommand, responder Responder, failed HumanReadableText) : void renamed to protected doAuthWithDelegation(authenticationAttempt AuthenticationAttempt, session ImapSession, tag String, command ImapCommand, responder Responder, failed HumanReadableText) : void in class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Rename Method public getAuthorizeId() : Optional<String> renamed to public getDelegateUserName() : Optional<String> in class org.apache.james.imap.processor.AbstractAuthProcessor.AuthenticationAttempt | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method private delegation(authorizeId String, authenticationId String, password String) : AuthPlainAttempt from class org.apache.james.imap.processor.AuthenticateProcessor to protected delegation(authorizeId String, authenticationId String, password String) : AuthenticationAttempt from class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Pull Up Method private noDelegation(authenticationId String, password String) : AuthPlainAttempt from class org.apache.james.imap.processor.AuthenticateProcessor to protected noDelegation(authenticationId String, password String) : AuthenticationAttempt from class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable authPlainAttempt : AuthPlainAttempt to authenticationAttempt : AuthenticationAttempt in method protected doPlainAuth(initialClientResponse String, session ImapSession, tag String, command ImapCommand, responder Responder) : void in class org.apache.james.imap.processor.AuthenticateProcessor | From | To | |
| Change Return Type | 3 | ||
| Change Return Type AuthPlainAttempt to AuthenticationAttempt in method protected delegation(authorizeId String, authenticationId String, password String) : AuthenticationAttempt in class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Change Return Type AuthPlainAttempt to AuthenticationAttempt in method protected noDelegation(authenticationId String, password String) : AuthenticationAttempt in class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Change Return Type AuthPlainAttempt to AuthenticationAttempt in method private parseDelegationAttempt(initialClientResponse String) : AuthenticationAttempt in class org.apache.james.imap.processor.AuthenticateProcessor | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.james.imap.processor.AuthenticateProcessor.AuthPlainAttempt moved and renamed to org.apache.james.imap.processor.AbstractAuthProcessor.AuthenticationAttempt | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute authorizeId : Optional<String> to delegateUserName : Optional<String> in class org.apache.james.imap.processor.AbstractAuthProcessor.AuthenticationAttempt | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type authPlainAttempt : AuthPlainAttempt to authenticationAttempt : AuthenticationAttempt in method protected doPlainAuth(initialClientResponse String, session ImapSession, tag String, command ImapCommand, responder Responder) : void in class org.apache.james.imap.processor.AuthenticateProcessor | From | To | |
| Extract Method | 2 | ||
| Extract Method protected manageFailureCount(session ImapSession, tag String, command ImapCommand, responder Responder, failed HumanReadableText) : void extracted from protected doAuth(userid String, passwd String, session ImapSession, tag String, command ImapCommand, responder Responder, failed HumanReadableText) : void in class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Extract Method private provisionInbox(session ImapSession, mailboxManager MailboxManager, mailboxSession MailboxSession) : void extracted from protected doAuth(userid String, passwd String, session ImapSession, tag String, command ImapCommand, responder Responder, failed HumanReadableText) : void in class org.apache.james.imap.processor.AbstractAuthProcessor | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter authorizeId : Optional<String> to delegateUserName : Optional<String> in method public AuthenticationAttempt(delegateUserName Optional<String>, authenticationId String, password String) in class org.apache.james.imap.processor.AbstractAuthProcessor.AuthenticationAttempt | From | To |