36b0ef6e89e3eea5941322450ebff623e4028c19
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getMessageShouldReturnMessageBelongToUser() : void renamed to public getMessageShouldReturnOnlyMessageBelongingToCurrentUser() : void in class org.apache.james.mailbox.store.AbstractMessageIdManagerStorageTest | From | To | |
| Rename Method public deleteMessageShouldWorkWhenDeletingOnSystemSession() : void renamed to public deleteMessageShouldThrowExceptionWhenDeletingOnSystemSession() : void in class org.apache.james.mailbox.store.AbstractMessageIdManagerStorageTest | From | To | |
| Move Method | 1 | ||
| Move Method private createMailbox(mailboxManager InMemoryMailboxManager, mailboxPath MailboxPath, mailboxSession MailboxSession) : SimpleMailbox from class org.apache.james.mailbox.inmemory.MessageIdManagerTestSystemProvider to public createMailbox(mailboxPath MailboxPath, mailboxSession MailboxSession) : Mailbox from class org.apache.james.mailbox.inmemory.InMemoryMessageIdManagerTestSystem | From | To | |
| Rename Variable | 1 | ||
| Rename Variable isForbidden : boolean to mailboxForbidden : Optional<MailboxId> in method private allowOnMailboxSession(mailboxIds List<MailboxId>, mailboxSession MailboxSession, mailboxMapper MailboxMapper) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type SimpleMailbox to Mailbox in method public createMailbox(mailboxPath MailboxPath, mailboxSession MailboxSession) : Mailbox in class org.apache.james.mailbox.inmemory.InMemoryMessageIdManagerTestSystem | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private USER : String from class org.apache.james.mailbox.inmemory.MessageIdManagerTestSystemProvider to public USER : String from class org.apache.james.mailbox.manager.MailboxManagerFixture | From | To | |
| Move Attribute private OTHER_USER : String from class org.apache.james.mailbox.inmemory.MessageIdManagerTestSystemProvider to public OTHER_USER : String from class org.apache.james.mailbox.manager.MailboxManagerFixture | From | To | |
| Move Attribute private UID_VALIDITY : int from class org.apache.james.mailbox.inmemory.MessageIdManagerTestSystemProvider to private UID_VALIDITY : int from class org.apache.james.mailbox.inmemory.InMemoryMessageIdManagerTestSystem | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.james.mailbox.manager.MailboxManagerFixture from class org.apache.james.mailbox.inmemory.MessageIdManagerTestSystemProvider | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute EMPTY_MAILBOX_SESSION : MailboxSession to DEFAULT_MAILBOX_SESSION : MailboxSession in class org.apache.james.mailbox.store.StoreMessageIdManagerTestSystem | From | To | |
| Rename Attribute OTHER_USER : MailboxSession to otherSession : MailboxSession in class org.apache.james.mailbox.store.AbstractMessageIdManagerStorageTest | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type isForbidden : boolean to mailboxForbidden : Optional<MailboxId> in method private allowOnMailboxSession(mailboxIds List<MailboxId>, mailboxSession MailboxSession, mailboxMapper MailboxMapper) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Method | 1 | ||
| Extract Method private filterByMessageId(messageId MessageId) : Predicate<MessageResult> extracted from private findMessageWithId(mailboxId MailboxId, messageId MessageId, fetchGroup FetchGroup, mailboxSession MailboxSession) : Optional<MessageResult> in class org.apache.james.mailbox.inmemory.InMemoryMessageIdManager | From | To |