429e9b15939d452338b4388760f94d0ca1f14a3e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 61
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package setMailAttributeName(mailAttributeName String) : void renamed to package setMailAttribute(mailAttribute Attribute) : void in class org.apache.james.transport.matchers.AbstractHasMailAttributeTest | From | To | |
| Merge Attribute | 3 | ||
| Merge Attribute [MAIL_ATTRIBUTE_NAME2 : String, MAIL_ATTRIBUTE_VALUE2 : String] to MAIL_ATTRIBUTE2 : Attribute in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Merge Attribute [mailAttributeName : String, mailAttributeValue : String] to mailAttribute : Attribute in class org.apache.james.transport.matchers.AbstractHasMailAttributeTest | From | To | |
| Merge Attribute [MAIL_ATTRIBUTE_NAME1 : String, MAIL_ATTRIBUTE_VALUE1 : String] to MAIL_ATTRIBUTE1 : Attribute in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type headersAsAttribute : Map<String,String> to headersAsAttributes : List<Attribute> in method private SpamAssassinResult(hits String, requiredHits String, headersAsAttributes List<Attribute>) in class org.apache.james.spamassassin.SpamAssassinResult | From | To | |
| Change Parameter Type fileName : String to fileName : AttributeValue<String> in method private storeFileNameAsAttribute(mail Mail, fileName AttributeValue<String>, hasToBeStored boolean) : void in class org.apache.james.transport.mailets.StripAttachment | From | To | |
| Change Parameter Type mailAttributeName : String to mailAttribute : Attribute in method package setMailAttribute(mailAttribute Attribute) : void in class org.apache.james.transport.matchers.AbstractHasMailAttributeTest | From | To | |
| Change Parameter Type savedAttachments : Collection<String> to savedAttachments : Collection<AttributeValue<String>> in method private retrieveFilenameStartingWith(savedAttachments Collection<AttributeValue<String>>, filename String) : String in class org.apache.james.transport.mailets.StripAttachmentTest | From | To | |
| Rename Variable | 2 | ||
| Rename Variable key : String to attribute : Attribute in method private querySpamAssassin(mail Mail, message MimeMessage, sa SpamAssassinInvoker, recipient MailAddress) : void in class org.apache.james.transport.mailets.SpamAssassin | From | To | |
| Rename Variable headersAsAttribute : ImmutableMap.Builder<String,String> to headersAsAttributes : ImmutableList.Builder<Attribute> in method public build() : SpamAssassinResult in class org.apache.james.spamassassin.SpamAssassinResult.Builder | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute REMOVED_ATTACHMENTS_ATTRIBUTE_KEY : String to REMOVED_ATTACHMENTS : AttributeName in class org.apache.james.transport.mailets.StripAttachment | From | To | |
| Rename Attribute headersAsAttribute : Map<String,String> to headersAsAttributes : List<Attribute> in class org.apache.james.spamassassin.SpamAssassinResult | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type exceptionValue : Object to exceptionValue : Optional<Attribute> in method public match(mail Mail) : Collection<MailAddress> in class org.apache.james.transport.matchers.HasException | From | To | |
| Change Variable Type headersAsAttribute : ImmutableMap.Builder<String,String> to headersAsAttributes : ImmutableList.Builder<Attribute> in method public build() : SpamAssassinResult in class org.apache.james.spamassassin.SpamAssassinResult.Builder | From | To | |
| Change Variable Type key : String to attribute : Attribute in method private querySpamAssassin(mail Mail, message MimeMessage, sa SpamAssassinInvoker, recipient MailAddress) : void in class org.apache.james.transport.mailets.SpamAssassin | From | To | |
| Extract Method | 5 | ||
| Extract Method private retrieveUsername() : Optional<String> extracted from private checkUsernameAttribute() : boolean in class org.apache.james.jmap.send.PostDequeueDecorator | From | To | |
| Extract Method private retrieveMessageId() : Optional<?> extracted from private checkMessageIdAttribute() : boolean in class org.apache.james.jmap.send.PostDequeueDecorator | From | To | |
| Extract Method private trySendContent(content Stream<byte[]>) : void extracted from private sendContent(content Stream<byte[]>) : void in class org.apache.james.transport.mailets.AmqpForwardAttribute | From | To | |
| Extract Method private retrieveMessageId() : Optional<?> extracted from public done(success boolean) : void in class org.apache.james.jmap.send.PostDequeueDecorator | From | To | |
| Extract Method private retrieveUsername() : Optional<String> extracted from public done(success boolean) : void in class org.apache.james.jmap.send.PostDequeueDecorator | From | To | |
| Change Attribute Type | 17 | ||
| Change Attribute Type MAIL_ATTRIBUTE_NAME2 : String to MAIL_ATTRIBUTE_NAME2 : AttributeName in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Change Attribute Type IS_DELIVERED : String to IS_DELIVERED : Attribute in class org.apache.james.jmap.send.PostDequeueDecorator | From | To | |
| Change Attribute Type MAIL_PRIORITY : String to MAIL_PRIORITY : AttributeName in class org.apache.james.queue.api.MailPrioritySupport | From | To | |
| Change Attribute Type attribute : String to attribute : AttributeName in class org.apache.james.transport.mailets.AmqpForwardAttribute | From | To | |
| Change Attribute Type priority : int to priority : Attribute in class org.apache.james.transport.mailets.WithPriority | From | To | |
| Change Attribute Type ATTRIBUTE_CONTENT : ImmutableMap<String,byte[]> to ATTRIBUTE_CONTENT : Optional<Attribute> in class org.apache.james.transport.mailets.AmqpForwardAttributeTest | From | To | |
| Change Attribute Type MAIL_ATTRIBUTE : String to MAIL_ATTRIBUTE : AttributeName in class org.apache.james.transport.mailets.MimeDecodingMailetTest | From | To | |
| Change Attribute Type MAIL_ATTRIBUTE_VALUE1 : String to MAIL_ATTRIBUTE_VALUE1 : AttributeValue<String> in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Change Attribute Type MAIL_METADATA_MESSAGE_ID_ATTRIBUTE : String to MAIL_METADATA_MESSAGE_ID_ATTRIBUTE : AttributeName in class org.apache.james.jmap.send.MailMetadata | From | To | |
| Change Attribute Type MAIL_ATTRIBUTE_VALUE2 : String to MAIL_ATTRIBUTE_VALUE2 : AttributeValue<String> in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Change Attribute Type MAIL_METADATA_USERNAME_ATTRIBUTE : String to MAIL_METADATA_USERNAME_ATTRIBUTE : AttributeName in class org.apache.james.jmap.send.MailMetadata | From | To | |
| Change Attribute Type RECIPIENT_1_MAILBOX_1 : String to RECIPIENT_1_MAILBOX_1 : AttributeValue<String> in class org.apache.james.jmap.mailet.filter.JMAPFilteringFixture | From | To | |
| Change Attribute Type MAIL_ATTRIBUTE_NAME1 : String to MAIL_ATTRIBUTE_NAME1 : AttributeName in class org.apache.james.transport.mailets.MailAttributesToMimeHeadersTest | From | To | |
| Change Attribute Type TEST_ATTRIBUTE : String to TEST_ATTRIBUTE : Attribute in class org.apache.james.mailrepository.MailRepositoryContract | From | To | |
| Change Attribute Type headersAsAttribute : Map<String,String> to headersAsAttributes : List<Attribute> in class org.apache.james.spamassassin.SpamAssassinResult | From | To | |
| Change Attribute Type MAIL_ATTRIBUTE : String to MAIL_ATTRIBUTE : AttributeName in class org.apache.james.transport.mailets.AmqpForwardAttributeTest | From | To | |
| Change Attribute Type REMOVED_ATTACHMENTS_ATTRIBUTE_KEY : String to REMOVED_ATTACHMENTS : AttributeName in class org.apache.james.transport.mailets.StripAttachment | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter mailAttributeName : String to mailAttribute : Attribute in method package setMailAttribute(mailAttribute Attribute) : void in class org.apache.james.transport.matchers.AbstractHasMailAttributeTest | From | To | |
| Rename Parameter headersAsAttribute : Map<String,String> to headersAsAttributes : List<Attribute> in method private SpamAssassinResult(hits String, requiredHits String, headersAsAttributes List<Attribute>) in class org.apache.james.spamassassin.SpamAssassinResult | From | To |