61c6309f65d43889f98c1984d3f040603f43d9d0
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method private calcTotalAttempts(delayList List<Delay>) : int renamed to private computeTotalAttempts(delayList List<Delay>) : int in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Rename Method public stringConstructorShouldDefaultToZeroForNegatives() : void renamed to public stringConstructorShouldThrowOnNegativeNumbers() : void in class org.apache.james.transport.mailets.remoteDelivery.DelayTest | From | To | |
| Rename Method public getDelayTime() : long renamed to public getDelayTimeInMs() : long in class org.apache.james.transport.mailets.remoteDelivery.Delay | From | To | |
| Rename Variable | 1 | ||
| Rename Variable delay : Delay to lastDelay : Delay in method private addExtraAttemptToLastDelay(intendedMaxRetries int, extra int, delayTimesList List<Delay>) : DelaysAndMaxRetry in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Change Return Type | 2 | ||
| Change Return Type ArrayList<Delay> to List<Delay> in method private createDelayList(delaysAsString String) : List<Delay> in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Change Return Type long[] to List<Long> in method public getExpendedDelays() : List<Long> in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute delayTime : long to delayTimeInMs : long in class org.apache.james.transport.mailets.remoteDelivery.Delay | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type delayTimesList : ArrayList<Delay> to delayTimesList : List<Delay> in method public from(intendedMaxRetries int, delaysAsString String) : DelaysAndMaxRetry in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Extract Method | 2 | ||
| Extract Method private addExtraAttemptToLastDelay(intendedMaxRetries int, extra int, delayTimesList List<Delay>) : DelaysAndMaxRetry extracted from public from(intendedMaxRetries int, delaysAsString String) : DelaysAndMaxRetry in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Extract Method private getDelaysAndMaxRetry(intendedMaxRetries int, totalAttempts int, delayTimesList List<Delay>) : DelaysAndMaxRetry extracted from public from(intendedMaxRetries int, delaysAsString String) : DelaysAndMaxRetry in class org.apache.james.transport.mailets.remoteDelivery.DelaysAndMaxRetry | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type delayTimes : long[] to delayTimes : List<Long> in class org.apache.james.transport.mailets.RemoteDelivery | From | To |