62bdbd74762341eb91b6ad5b24d5da8a19042774
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 5 | ||
| Change Parameter Type mailboxIds : SetView<MailboxId> to mailboxIds : Set<MailboxId> in method private addMessageToMailboxes(mailboxMessage MailboxMessage, mailboxIds Set<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Change Parameter Type mailboxIds : List<MailboxId> to mailboxIds : Collection<MailboxId> in method private inMailboxes(mailboxIds Collection<MailboxId>) : Predicate<MailboxMessage> in class org.apache.james.mailbox.store.TestMailboxSessionMapperFactory | From | To | |
| Change Parameter Type mailboxIds : List<MailboxId> to mailboxIds : Collection<MailboxId> in method public delete(messageId MessageId, mailboxIds Collection<MailboxId>) : void in class org.apache.james.mailbox.cassandra.mail.CassandraMessageIdMapper | From | To | |
| Change Parameter Type mailboxIds : List<MailboxId> to mailboxIds : Collection<MailboxId> in method public delete(messageId MessageId, mailboxIds Collection<MailboxId>) : void in class org.apache.james.mailbox.inmemory.mail.InMemoryMessageIdMapper | From | To | |
| Change Parameter Type mailboxIds : List<MailboxId> to mailboxIds : Collection<MailboxId> in method public delete(messageId MessageId, mailboxIds Collection<MailboxId>) : void in class org.apache.james.mailbox.store.mail.MessageIdMapper | From | To | |
| Rename Variable | 2 | ||
| Rename Variable message : MailboxMessage to mailboxId : MailboxId in method private removeMessageFromMailboxes(message MailboxMessage, mailboxesToRemove Set<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Rename Variable metadatasWithMailbox : ImmutableList<MetadataWithMailboxId> to metadataWithMailbox : ImmutableList<MetadataWithMailboxId> in method public delete(messageId MessageId, mailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Merge Variable | 1 | ||
| Merge Variable [mailboxesToAdd : SetView<MailboxId>, mailboxesToRemove : List<MailboxId>] to messageMoves : MessageMoves in method private applyMessageMoves(mailboxSession MailboxSession, currentMailboxMessages List<MailboxMessage>, messageMoves MessageMoves) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Merge Parameter | 2 | ||
| Merge Parameter [mailboxIdsToBeAdded : Collection<MailboxId>, mailboxIdsToBeRemove : Collection<MailboxId>] to messageMoves : MessageMoves in method private buildMapQuotaRoot(messageMoves MessageMoves, mailboxMapper MailboxMapper) : Map<QuotaRoot,Integer> in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Merge Parameter [mailboxIdsToBeAdded : Collection<MailboxId>, mailboxIdsToBeRemove : Collection<MailboxId>] to messageMoves : MessageMoves in method private validateQuota(messageMoves MessageMoves, mailboxSession MailboxSession, mailboxMessage MailboxMessage) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type message : MailboxMessage to mailboxId : MailboxId in method private removeMessageFromMailboxes(message MailboxMessage, mailboxesToRemove Set<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Variable | 1 | ||
| Extract Variable eventPayload : SimpleMessageMetaData in method private removeMessageFromMailboxes(message MailboxMessage, mailboxesToRemove Set<MailboxId>, mailboxSession MailboxSession) : void from class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Method | 4 | ||
| Extract Method private findRelatedMailboxMessages(messageId MessageId, mailboxSession MailboxSession) : List<MailboxMessage> extracted from public setInMailboxes(messageId MessageId, mailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Method private applyMessageMoves(mailboxSession MailboxSession, currentMailboxMessages List<MailboxMessage>, messageMoves MessageMoves) : void extracted from public setInMailboxes(messageId MessageId, mailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Method private removeMessageFromMailboxes(message MailboxMessage, mailboxesToRemove Set<MailboxId>, mailboxSession MailboxSession) : void extracted from public setInMailboxes(messageId MessageId, mailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Extract Method private toMailboxIds(mailboxMessages List<MailboxMessage>) : ImmutableSet<MailboxId> extracted from public setInMailboxes(messageId MessageId, mailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter mailboxIds : List<MailboxId> to targetMailboxIds : List<MailboxId> in method public setInMailboxes(messageId MessageId, targetMailboxIds List<MailboxId>, mailboxSession MailboxSession) : void in class org.apache.james.mailbox.store.StoreMessageIdManager | From | To |