8ce351489a6ade4411170307cb6db0bba638e209
Files Diff
- Added: 0
- Removed: 2
- Renamed: 0
- Modified: 84
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public queueShouldPreserveNullSender() : void renamed to public queueShouldHandleSender() : void in class org.apache.james.queue.api.MailQueueContract | From | To | |
Change Parameter Type | 5 | ||
Change Parameter Type sender : MailAddress to mail : Mail in method package handleMappings(mappings Mappings, mail Mail, recipient MailAddress, message MimeMessage) : List<MailAddress> in class org.apache.james.transport.mailets.RecipientRewriteTableProcessor | From | To | |
Change Parameter Type mail : Mail to sender : MailAddress in method private isLocalServer(sender MailAddress) : boolean in class org.apache.james.transport.matchers.SenderHostIsLocal | From | To | |
Change Parameter Type sender : MailAddress to mail : Mail in method private forwardToRemoteAddress(mail Mail, recipient MailAddress, message MimeMessage, mailAddresses ImmutableList<MailAddress>) : void in class org.apache.james.transport.mailets.RecipientRewriteTableProcessor | From | To | |
Change Parameter Type sender : MailAddress to sender : MaybeSender in method private setSender(node Node, sender MaybeSender) : void in class org.apache.james.mailrepository.jcr.JCRMailRepository | From | To | |
Change Parameter Type sender : MailAddress to sender : Optional<MailAddress> in method private assertUserIsSender(session MailboxSession, sender Optional<MailAddress>) : void in class org.apache.james.jmap.methods.SetMessagesUpdateProcessor | From | To | |
Change Return Type | 6 | ||
Change Return Type MailAddress to Optional<MailAddress> in method private getMailAddress(s String) : Optional<MailAddress> in class org.apache.james.transport.matchers.utils.MailAddressCollectionReader | From | To | |
Change Return Type MailAddress to Optional<MailAddress> in method private retrieveAddressFromString(address String) : Optional<MailAddress> in class org.apache.james.transport.mailets.jsieve.VacationReply.Builder | From | To | |
Change Return Type Collection<MailAddress> to List<MailAddress> in method private customizeHeadersAndDeliver(mail Mail) : List<MailAddress> in class org.apache.james.transport.mailets.delivery.MailDispatcher | From | To | |
Change Return Type Set<MailAddress> to Set<Optional<MailAddress>> in method public read(condition String) : Set<Optional<MailAddress>> in class org.apache.james.transport.matchers.utils.MailAddressCollectionReader | From | To | |
Change Return Type Set<MailAddress> to Set<Optional<MailAddress>> in method package getSenders() : Set<Optional<MailAddress>> in class org.apache.james.transport.matchers.SenderIs | From | To | |
Change Return Type Collection<MailAddress> to List<MailAddress> in method private deliver(mail Mail, message MimeMessage) : List<MailAddress> in class org.apache.james.transport.mailets.delivery.MailDispatcher | From | To | |
Change Variable Type | 4 | ||
Change Variable Type errors : Collection<MailAddress> to errors : List<MailAddress> in method private customizeHeadersAndDeliver(mail Mail) : List<MailAddress> in class org.apache.james.transport.mailets.delivery.MailDispatcher | From | To | |
Change Variable Type errors : Collection<MailAddress> to errors : List<MailAddress> in method public dispatch(mail Mail) : void in class org.apache.james.transport.mailets.delivery.MailDispatcher | From | To | |
Change Variable Type errors : Collection<MailAddress> to errors : List<MailAddress> in method private deliver(mail Mail, message MimeMessage) : List<MailAddress> in class org.apache.james.transport.mailets.delivery.MailDispatcher | From | To | |
Change Variable Type reversePath : MailAddress to reversePath : MaybeSender in method private getSenderAsList(originalMail Mail) : List<MailAddress> in class org.apache.james.transport.mailets.DSNBounce | From | To | |
Extract Method | 2 | ||
Extract Method public sender(sender Optional<MailAddress>) : Builder extracted from public sender(sender MailAddress) : Builder in class org.apache.james.server.core.MailImpl.Builder | From | To | |
Extract Method public sender(sender MaybeSender) : Builder extracted from public sender(sender MailAddress) : Builder in class org.apache.james.server.core.MailImpl.Builder | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type recipients : Collection<MailAddress> to recipients : Collection<Optional<MailAddress>> in class org.apache.james.transport.matchers.RecipientIs | From | To | |
Change Attribute Type senders : Set<MailAddress> to senders : Set<Optional<MailAddress>> in class org.apache.james.transport.matchers.SenderIs | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public toSet(optional Optional<T>) : ImmutableSet<T> extracted from private getSender(mail Mail) : Set<MailAddress> in class org.apache.james.transport.util.SpecialAddressesUtils & moved to class org.apache.james.util.OptionalUtils | From | To | |
Rename Parameter | 3 | ||
Rename Parameter sender : MailAddress to mail : Mail in method private forwardToRemoteAddress(mail Mail, recipient MailAddress, message MimeMessage, mailAddresses ImmutableList<MailAddress>) : void in class org.apache.james.transport.mailets.RecipientRewriteTableProcessor | From | To | |
Rename Parameter mail : Mail to sender : MailAddress in method private isLocalServer(sender MailAddress) : boolean in class org.apache.james.transport.matchers.SenderHostIsLocal | From | To | |
Rename Parameter sender : MailAddress to mail : Mail in method package handleMappings(mappings Mappings, mail Mail, recipient MailAddress, message MimeMessage) : List<MailAddress> in class org.apache.james.transport.mailets.RecipientRewriteTableProcessor | From | To |