9481435b89ec32e3220202e4e2198e1bbb8b3b73
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 10
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 4 | ||
Rename Method public MDNNotSent(creationMessageId CreationMessageId, error SetError) : Builder renamed to public mdnNotSent(creationMessageId CreationMessageId, error SetError) : Builder in class org.apache.james.jmap.model.SetMessagesResponse.Builder | From | To | |
Rename Method public MDNNotSent(notCreated Map<CreationMessageId,SetError>) : Builder renamed to public mdnNotSent(notCreated Map<CreationMessageId,SetError>) : Builder in class org.apache.james.jmap.model.SetMessagesResponse.Builder | From | To | |
Rename Method public sendMDNIsNotSupportedYet() : void renamed to public sendMDNShouldReturnCreatedMessageId() : void in class org.apache.james.jmap.methods.integration.SendMDNMethodTest | From | To | |
Rename Method public handleMDNCreation(request SetMessagesRequest) : SetMessagesResponse renamed to private generateReport(mdn JmapMDN, originalMessage Message, mailboxSession MailboxSession) : MDNReport in class org.apache.james.jmap.methods.SendMDNProcessor | From | To | |
Change Parameter Type | 4 | ||
Change Parameter Type mdns : Map<CreationMessageId,MDN> to mdns : Map<CreationMessageId,JmapMDN> in method public sendMDN(mdns Map<CreationMessageId,JmapMDN>) : Builder in class org.apache.james.jmap.model.SetMessagesRequest.Builder | From | To | |
Change Parameter Type mdn : MDN to mdn : JmapMDN in method public MDNCreationEntry(creationId CreationMessageId, mdn JmapMDN) in class org.apache.james.jmap.methods.ValueWithId.MDNCreationEntry | From | To | |
Change Parameter Type sendMDN : List<CreationMDNEntry> to sendMDN : List<MDNCreationEntry> in method package SetMessagesRequest(accountId Optional<String>, ifInState Optional<String>, create List<CreationMessageEntry>, sendMDN List<MDNCreationEntry>, update Map<MessageId,Function<UpdateMessagePatchConverter,UpdateMessagePatch>>, destroy List<MessageId>) in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
Change Parameter Type mdn : MDN to mdn : JmapMDN in method public sendMDN(creationMessageId CreationMessageId, mdn JmapMDN) : Builder in class org.apache.james.jmap.model.SetMessagesRequest.Builder | From | To | |
Change Return Type | 4 | ||
Change Return Type SetMessagesResponse to MDNReport in method private generateReport(mdn JmapMDN, originalMessage Message, mailboxSession MailboxSession) : MDNReport in class org.apache.james.jmap.methods.SendMDNProcessor | From | To | |
Change Return Type MDN to JmapMDN in method public build() : JmapMDN in class org.apache.james.jmap.model.JmapMDN.Builder | From | To | |
Change Return Type List<CreationMDNEntry> to List<MDNCreationEntry> in method public getSendMDN() : List<MDNCreationEntry> in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
Change Return Type ImmutableList<CreationMDNEntry> to ImmutableList<MDNCreationEntry> in method private mdnSendings() : ImmutableList<MDNCreationEntry> in class org.apache.james.jmap.model.SetMessagesRequest.Builder | From | To | |
Rename Class | 3 | ||
Rename Class org.apache.james.jmap.methods.ValueWithId.CreationMDNEntry renamed to org.apache.james.jmap.methods.ValueWithId.MDNCreationEntry | From | To | |
Rename Class org.apache.james.jmap.model.MDN renamed to org.apache.james.jmap.model.JmapMDN | From | To | |
Rename Class org.apache.james.jmap.model.MDNTest renamed to org.apache.james.jmap.model.JmapMDNTest | From | To | |
Rename Attribute | 2 | ||
Rename Attribute MDNNotSent : ImmutableMap.Builder<CreationMessageId,SetError> to mdnNotSent : ImmutableMap.Builder<CreationMessageId,SetError> in class org.apache.james.jmap.model.SetMessagesResponse.Builder | From | To | |
Rename Attribute MDNNotSent : ImmutableMap<CreationMessageId,SetError> to mdnNotSent : ImmutableMap<CreationMessageId,SetError> in class org.apache.james.jmap.model.SetMessagesResponse | From | To | |
Change Variable Type | 1 | ||
Change Variable Type that : MDN to that : JmapMDN in method public equals(o Object) : boolean in class org.apache.james.jmap.model.JmapMDN | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type sendMDN : List<CreationMDNEntry> to sendMDN : List<MDNCreationEntry> in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
Change Attribute Type sendMDN : HashMap<CreationMessageId,MDN> to sendMDN : HashMap<CreationMessageId,JmapMDN> in class org.apache.james.jmap.model.SetMessagesRequest.Builder | From | To | |
Extract Method | 2 | ||
Extract Method public asBytes(message Message) : byte[] extracted from public convert(creationMessageEntry ValueWithId.CreationMessageEntry, messageAttachments ImmutableList<MessageAttachment>) : byte[] in class org.apache.james.jmap.methods.MIMEMessageConverter | From | To | |
Extract Method private generateDisposition(disposition MDNDisposition) : Disposition extracted from public handleMDNCreation(request SetMessagesRequest) : SetMessagesResponse in class org.apache.james.jmap.methods.SendMDNProcessor | From | To |