a40313a5aad177a63345b12c894440c47b287fb1
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 2 | ||
Rename Method public testPutScriptUnauthorised() : void renamed to public testPutScriptinvalidLiteral() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Rename Method protected haveSpace(session Session, operands String) : MimeMultipart renamed to private computeMultiPartResponse(session Session, message MimeMessage) : MimeMultipart in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Change Parameter Type | 2 | ||
Change Parameter Type operands : String to message : MimeMessage in method private computeMultiPartResponse(session Session, message MimeMessage) : MimeMultipart in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Change Parameter Type adapter : LineToCoreToLine to manageSieveProcessor : ManageSieveProcessor in method public MessageToCoreToMessage(manageSieveProcessor ManageSieveProcessor, helpProvider HelpProvider) in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Replace Variable With Attribute | 2 | ||
Replace Variable With Attribute sender : String to USER : String in method private prepareMimeMessage(subject String) : MimeMessage in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Replace Variable With Attribute recipient : String to SIEVE_LOCALHOST : String in method private prepareMimeMessage(subject String) : MimeMessage in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Rename Attribute | 1 | ||
Rename Attribute adapter : LineToCoreToLine to manageSieveProcessor : ManageSieveProcessor in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Change Variable Type | 39 | ||
Change Variable Type mail : Mail to mail : FakeMail in method private createUnauthenticatedMail(message MimeMessage) : Mail in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method | 56 | ||
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testDeleteScriptExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScriptNoScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCheckScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testSetActive() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testRenameScriptsExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testGetScriptExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCheckScriptUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testRenameScripts() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCapability() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testCheckScriptExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCheckScriptSyntaxError() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpace() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testSetActiveNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testGetScriptNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testRenameScriptsNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testDeleteScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testListScriptsExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScriptNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testGetScriptNoScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScriptExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testSetActiveExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testListScripts() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testGetScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testDeleteScriptNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScriptSyntaxError() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCheckScriptNoScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpaceNoScriptSize() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCapabilityUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testCheckScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testSetActive() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCapabilityExtraArguments() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpaceUnauthenticated() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testListScriptsUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testRenameScripts() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private verifyHeaders(subject String) : MimeMessage extracted from private ensureResponse(subject String, recipient Address, contents String...) : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testCheckScriptSyntaxError() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testCheckScriptExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testHaveSpace() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testRenameScriptsNoNewScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testDeleteScriptUnauthenticated() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testSetActiveUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testRenameScriptsUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testPutScriptUnauthorised() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testDeleteScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testListScriptsExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpaceInvalidScriptSize() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpaceNoScriptName() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private initializeMailet() : void extracted from public setUp() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testPutScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private verifyHeaders(subject String) : MimeMessage extracted from private ensureResponseContains(subject String, recipient Address, contents String...) : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testHaveSpaceExtraArgs() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testGetScriptNonAuthorized() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createUnauthenticatedMail(message MimeMessage) : Mail extracted from public testListScripts() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testPutScriptSyntaxError() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Extract Method private createAuthentificatedMail(message MimeMessage) : Mail extracted from public testCheckScriptNoScript() : void in class org.apache.james.transport.mailets.managesieve.ManageSieveMailetTestCase | From | To | |
Change Attribute Type | 1 | ||
Change Attribute Type adapter : LineToCoreToLine to manageSieveProcessor : ManageSieveProcessor in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Rename Parameter | 2 | ||
Rename Parameter operands : String to message : MimeMessage in method private computeMultiPartResponse(session Session, message MimeMessage) : MimeMultipart in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To | |
Rename Parameter adapter : LineToCoreToLine to manageSieveProcessor : ManageSieveProcessor in method public MessageToCoreToMessage(manageSieveProcessor ManageSieveProcessor, helpProvider HelpProvider) in class org.apache.james.transport.mailets.managesieve.transcode.MessageToCoreToMessage | From | To |