af067c6877e1edd810e19d484ce99f295389ef19
Files Diff
- Added: 2
- Removed: 2
- Renamed: 0
- Modified: 3
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Variable | 5 | ||
Rename Variable pc : int to charsetOffset : int in method private getPatternsFromFileList(filepar String) : List<ReplacingPattern> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Rename Variable filepar : String to filePattern : String in method private initSubjectPatternFile(builder ReplaceConfig.Builder) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Rename Variable ct : ContentType to contentType : ContentType in method private getContentType(mail Mail) : String in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Rename Variable pattern : String to patternProcessing : String in method protected getPatternsFromString(pattern String) : List<ReplacingPattern> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Rename Variable f : File to file : File in method private retrieveInputStream(fileAsString String) : Optional<? extends InputStream> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Return Type | 4 | ||
Change Return Type PatternList to List<ReplacingPattern> in method private getPatternsFromFileList(filepar String) : List<ReplacingPattern> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Return Type PatternList to List<ReplacingPattern> in method protected getPatternsFromStream(stream InputStream, charset String) : List<ReplacingPattern> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Return Type PatternBean to ReplacingPattern in method private getPattern(line String) : ReplacingPattern in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Return Type PatternList to List<ReplacingPattern> in method protected getPatternsFromString(pattern String) : List<ReplacingPattern> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Parameterize Variable | 1 | ||
Parameterize Variable line : String to pattern : String in method private ensurePatternIsValid(pattern String) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method | 12 | ||
Extract Method private applyBodyReplacingUnits(mail Mail) : boolean extracted from public service(mail Mail) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private ensurePatternIsValid(pattern String) : void extracted from protected getPatternsFromStream(stream InputStream, charset String) : PatternList in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private retrieveInputStream(fileAsString String) : Optional<? extends InputStream> extracted from private getPatternsFromFileList(filepar String) : PatternList in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private ensurePatternIsValid(pattern String) : void extracted from protected getPatternsFromString(pattern String) : PatternList in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private unescapeSubstitutions(substitutions String) : String extracted from protected getPattern(line String) : PatternBean in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private initSubjectPattern(builder ReplaceConfig.Builder) : void extracted from private initPatterns() : ReplaceConfig in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private extractOptions(optionsAsString String) : int extracted from protected getPattern(line String) : PatternBean in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private applySubjectReplacingUnits(mail Mail) : boolean extracted from public service(mail Mail) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private initBodyPattern(builder ReplaceConfig.Builder) : void extracted from private initPatterns() : ReplaceConfig in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private getContentType(mail Mail) : String extracted from public service(mail Mail) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private setContent(mail Mail, body String) : void extracted from public service(mail Mail) : void in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Extract Method private initSubjectPatternFile(builder ReplaceConfig.Builder) : void extracted from private initPatterns() : ReplaceConfig in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type charset : String to charset : Optional<Charset> in class org.apache.james.transport.mailets.ReplaceContent | From | To | |
Change Attribute Type debug : int to debug : boolean in class org.apache.james.transport.mailets.ReplaceContent | From | To |