b0f4d067ad6c1c0095a3898b71f59c976e215e11
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 2
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type entry : CreationMessageEntry to entry : ValueWithId.CreationMessageEntry in method public assertAttachmentsExist(entry ValueWithId.CreationMessageEntry, session MailboxSession) : void in class org.apache.james.jmap.methods.AttachmentChecker | From | To | |
| Change Parameter Type attachmentManager : AttachmentManager to attachmentChecker : AttachmentChecker in method package SetMessagesCreationProcessor(messageFactory MessageFactory, systemMailboxesProvider SystemMailboxesProvider, attachmentChecker AttachmentChecker, metricFactory MetricFactory, mailboxManager MailboxManager, mailboxIdFactory MailboxId.Factory, messageAppender MessageAppender, messageSender MessageSender) in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Move Method | 5 | ||
| Move Method package assertAttachmentsExist(entry CreationMessageEntry, session MailboxSession) : void from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to public assertAttachmentsExist(entry ValueWithId.CreationMessageEntry, session MailboxSession) : void from class org.apache.james.jmap.methods.AttachmentChecker | From | To | |
| Move Method private listAttachmentsNotFound(attachments List<Attachment>, session MailboxSession) : List<BlobId> from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private listAttachmentsNotFound(attachments List<Attachment>, session MailboxSession) : List<BlobId> from class org.apache.james.jmap.methods.AttachmentChecker | From | To | |
| Move Method private getAttachmentId(attachment Attachment) : AttachmentId from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private getAttachmentId(attachment Attachment) : AttachmentId from class org.apache.james.jmap.methods.AttachmentChecker | From | To | |
| Move Method public assertAttachmentsExistShouldThrowWhenUnknownBlobId() : void from class org.apache.james.jmap.methods.SetMessagesCreationProcessorTest to public assertAttachmentsExistShouldThrowWhenUnknownBlobId() : void from class org.apache.james.jmap.methods.AttachmentCheckerTest | From | To | |
| Move Method public assertAttachmentsExistShouldThrowWhenUnknownBlobIds() : void from class org.apache.james.jmap.methods.SetMessagesCreationProcessorTest to public assertAttachmentsExistShouldThrowWhenUnknownBlobIds() : void from class org.apache.james.jmap.methods.AttachmentCheckerTest | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private attachmentManager : AttachmentManager from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private attachmentManager : AttachmentManager from class org.apache.james.jmap.methods.AttachmentChecker | From | To | |
| Extract Class | 2 | ||
| Extract Class org.apache.james.jmap.methods.AttachmentChecker from class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Extract Class org.apache.james.jmap.methods.AttachmentCheckerTest from class org.apache.james.jmap.methods.SetMessagesCreationProcessorTest | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute attachmentManager : AttachmentManager to attachmentChecker : AttachmentChecker in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type attachmentManager : AttachmentManager to attachmentChecker : AttachmentChecker in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter attachmentManager : AttachmentManager to attachmentChecker : AttachmentChecker in method package SetMessagesCreationProcessor(messageFactory MessageFactory, systemMailboxesProvider SystemMailboxesProvider, attachmentChecker AttachmentChecker, metricFactory MetricFactory, mailboxManager MailboxManager, mailboxIdFactory MailboxId.Factory, messageAppender MessageAppender, messageSender MessageSender) in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To |