d59881815c9c5fcee73addb2a2562c28f3491e16
Files Diff
- Added: 7
- Removed: 2
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private hasRoleOutbox(mailBoxPath MailboxPath) : boolean from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private hasRole(aRole Role, mailBoxPath MailboxPath) : boolean from class org.apache.james.jmap.utils.SystemMailboxesProviderImpl | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type create : Map<CreationMessageId,CreationMessage> to create : List<CreationMessageEntry> in method package SetMessagesRequest(accountId Optional<String>, ifInState Optional<String>, create List<CreationMessageEntry>, update Map<MessageId,Function<UpdateMessagePatchConverter,UpdateMessagePatch>>, destroy List<MessageId>) in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
| Change Parameter Type creationMessageEntry : MessageWithId.CreationMessageEntry to creationMessageEntry : ValueWithId.CreationMessageEntry in method public convert(creationMessageEntry ValueWithId.CreationMessageEntry) : byte[] in class org.apache.james.jmap.methods.MIMEMessageConverter | From | To | |
| Change Parameter Type createdEntry : MessageWithId.CreationMessageEntry to createdEntry : CreationMessageEntry in method protected createMessageInOutboxAndSend(createdEntry CreationMessageEntry, session MailboxSession, outbox Mailbox, buildMessageIdFromUid Function<Long,MessageId>) : MessageWithId in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Change Parameter Type creationMessageEntry : MessageWithId.CreationMessageEntry to creationMessageEntry : ValueWithId.CreationMessageEntry in method package convertToMime(creationMessageEntry ValueWithId.CreationMessageEntry) : Message in class org.apache.james.jmap.methods.MIMEMessageConverter | From | To | |
| Move Method | 1 | ||
| Move Method private loadMailbox(session MailboxSession) : ThrowingFunction<MailboxPath,Mailbox> from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private loadMailbox(session MailboxSession) : ThrowingFunction<MailboxPath,Mailbox> from class org.apache.james.jmap.utils.SystemMailboxesProviderImpl | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private mailboxManager : MailboxManager from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private mailboxManager : MailboxManager from class org.apache.james.jmap.utils.SystemMailboxesProviderImpl | From | To | |
| Move Attribute private mailboxMapperFactory : MailboxMapperFactory from class org.apache.james.jmap.methods.SetMessagesCreationProcessor to private mailboxMapperFactory : MailboxMapperFactory from class org.apache.james.jmap.utils.SystemMailboxesProviderImpl | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.james.jmap.utils.SystemMailboxesProviderImpl from class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.james.jmap.methods.MessageWithId.CreationMessageEntry moved to org.apache.james.jmap.methods.ValueWithId.CreationMessageEntry | From | To | |
| Extract Variable | 1 | ||
| Extract Variable creationId : CreationMessageId in method protected createMessageInOutboxAndSend(createdEntry CreationMessageEntry, session MailboxSession, outbox Mailbox, buildMessageIdFromUid Function<Long,MessageId>) : MessageWithId from class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type responseBuilder : SetMessagesResponse.Builder to responseBuilder : Builder in method public process(request SetMessagesRequest, mailboxSession MailboxSession) : SetMessagesResponse in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Extract Method | 3 | ||
| Extract Method private collectMessageProperties(validationErrors List<ValidationResult>) : Set<MessageProperties.MessageProperty> extracted from private buildSetErrorFromValidationResult(validationErrors List<ValidationResult>) : SetError in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Extract Method private formatValidationErrorMessge(validationErrors List<ValidationResult>) : String extracted from private buildSetErrorFromValidationResult(validationErrors List<ValidationResult>) : SetError in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Extract Method private buildMessage(mailboxMessage MailboxMessage, jmapMessage Message) : Mail extracted from private sendMessage(mailboxMessage MailboxMessage, jmapMessage Message, session MailboxSession) : void in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Map<CreationMessageId,CreationMessage> to List<CreationMessageEntry> in method public getCreate() : List<CreationMessageEntry> in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
| Change Return Type MessageWithId<Message> to MessageWithId in method protected createMessageInOutboxAndSend(createdEntry CreationMessageEntry, session MailboxSession, outbox Mailbox, buildMessageIdFromUid Function<Long,MessageId>) : MessageWithId in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute fakeOutbox : Mailbox to outbox : Mailbox in method public processShouldCallMessageMapperWhenRequestHasNonEmptyCreate() : void in class org.apache.james.jmap.methods.SetMessagesCreationProcessorTest | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.james.jmap.methods.ValueWithId from classes [org.apache.james.jmap.methods.ValueWithId.CreationMessageEntry] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute mailboxManager : MailboxManager to systemMailboxesProvider : SystemMailboxesProvider in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type create : Map<CreationMessageId,CreationMessage> to create : List<CreationMessageEntry> in class org.apache.james.jmap.model.SetMessagesRequest | From | To | |
| Change Attribute Type create : ImmutableMap.Builder<CreationMessageId,CreationMessage> to create : HashMap<CreationMessageId,CreationMessage> in class org.apache.james.jmap.model.SetMessagesRequest.Builder | From | To | |
| Change Attribute Type mailboxManager : MailboxManager to systemMailboxesProvider : SystemMailboxesProvider in class org.apache.james.jmap.methods.SetMessagesCreationProcessor | From | To |